[lintian] 03/15: Rename fc-cache-used-in-maintainer-script to maintainer-script-should-not-use-fc-cache
This is an automated email from the git hooks/post-receive script.
broucaries-guest pushed a commit to branch master
in repository lintian.
commit c8cc70bb182c2b18e4e55c793fbd566da817b73b
Author: Bastien ROUCARIÈS <roucaries.bastien@gmail.com>
Date: Sat Dec 14 12:54:06 2013 +0100
Rename fc-cache-used-in-maintainer-script to maintainer-script-should-not-use-fc-cache
Add fontconfig to exception list.
Signed-off-by: Bastien ROUCARIÈS <roucaries.bastien+debian@gmail.com>
---
checks/scripts.desc | 2 +-
data/scripts/maintainer-script-bad-command | 2 +-
debian/changelog | 3 +++
t/tests/scripts-maintainer-general/desc | 2 +-
t/tests/scripts-maintainer-general/tags | 2 +-
5 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/checks/scripts.desc b/checks/scripts.desc
index 9a94efe..fb8ac4f 100644
--- a/checks/scripts.desc
+++ b/checks/scripts.desc
@@ -520,7 +520,7 @@ Certainty: possible
Info: This script apparently runs gconftool or gconftool-2. It should
probably be calling gconf-schemas or update-gconf-defaults instead.
-Tag: fc-cache-used-in-maintainer-script
+Tag: maintainer-script-should-not-use-fc-cache
Severity: normal
Certainty: possible
Info: This script apparently runs fc-cache. Updating of the fontconfig
diff --git a/data/scripts/maintainer-script-bad-command b/data/scripts/maintainer-script-bad-command
index 3874b24..b1013db 100644
--- a/data/scripts/maintainer-script-bad-command
+++ b/data/scripts/maintainer-script-bad-command
@@ -23,7 +23,6 @@ adduser-system-without-home ~~ 1 ~~ ~
ancient-dpkg-epoch-check ~~ 0 ~~ ~~ ~~${LEADIN}dpkg\s+--assert-working-epoch\b
ancient-dpkg-multi-conrep-check ~~ 0 ~~ ~~ ~~${LEADIN}dpkg\s+--assert-multi-conrep\b
deprecated-chown-usage ~~ 0 ~~ ~~ ~~(chown(?:\s+--?[A-Za-z-]+)*\s+[-_A-Za-z0-9]+\.[-_A-Za-z0-9]+)\s+
-fc-cache-used-in-maintainer-script ~~ 0 ~~ ~~ ~~${LEADIN}(?:/usr/bin/)?fc-cache(?:\s|\Z)
install-info-used-in-maintainer-script ~~ 1 ~~ ~~ ~~\binstall-info\b
install-sgmlcatalog-deprecated ~~ 1 ~~ ~~ ~~\binstall-sgmlcatalog\b
maintainer-script-hides-init-failure ~~ 0 ~~ ~~ ~~invoke-rc.d.*\|\| \s+ exit \s+ 0
@@ -31,6 +30,7 @@ maintainer-script-modifies-ld-so-conf ~~ 0 ~~^libc ~
maintainer-script-modifies-netbase-managed-file ~~ 0 ~~ ~~ ~~(?:\A\s*(?:cp|mv)\s+.*\s+|>\s*)(/etc/(?:services|protocols|rpc))\s*(?:\s|\Z)
maintainer-script-removes-device-files ~~ 0 ~~ ~~ ~~^\s*rm\s+(?:[^>]*\s)?(/dev/(?!(?:shm/|\.[^.]+))[^/ ]+)
maintainer-script-uses-dpkg-status-directly ~~ 1 ~~^(base-files|dpkg)$ ~~ ~~/var/lib/dpkg/status\b
+maintainer-script-should-not-use-fc-cache ~~ 0 ~~^(fontconfig)$ ~~ ~~${LEADIN}(?:/usr/bin/)?fc-cache(?:\s|\Z)
maintainer-script-should-not-use-gconftool ~~ 1 ~~^(gconf\d)$ ~~ ~~(?:/usr/bin/)?gconftool(?:-\d)?(?:\s|\Z)
update-alternatives-remove-called-in-postrm ~~ 1 ~~ ~~^postrm$ ~~\b update\-alternatives\s+\-\-remove\b
update-alternatives-set-called-in-maintainer-script ~~ 1 ~~ ~~ ~~\b update\-alternatives\s+\-\-(?:set|set\-selections|config)\b
diff --git a/debian/changelog b/debian/changelog
index 5609611..7ec4907 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -41,6 +41,9 @@ lintian (2.5.20) UNRELEASED; urgency=low
+ [BR] Rename gconftool-used-in-maintainer-script to
maintainer-script-should-not-use-gconftool. Add gconf\d package
to exception list.
+ + [BR] Rename fc-cache-used-in-maintainer-script to
+ maintainer-script-should-not-use-fc-cache. Add fontconfig
+ package to exception list.
* checks/standards-version:
+ [BR] Use Lintian::Data for ancient date check.
* checks/watch.{desc,pm}:
diff --git a/t/tests/scripts-maintainer-general/desc b/t/tests/scripts-maintainer-general/desc
index 0bae59e..34d99e3 100644
--- a/t/tests/scripts-maintainer-general/desc
+++ b/t/tests/scripts-maintainer-general/desc
@@ -9,7 +9,6 @@ Test-For:
adduser-system-without-home
command-with-path-in-maintainer-script
deprecated-chown-usage
- fc-cache-used-in-maintainer-script
install-info-used-in-maintainer-script
install-sgmlcatalog-deprecated
maintainer-script-has-unexpanded-debhelper-token
@@ -25,6 +24,7 @@ Test-For:
maintainer-script-removes-device-files
maintainer-script-uses-dpkg-status-directly
maintainer-shell-script-fails-syntax-check
+ maintainer-script-should-not-use-fc-cache
maintainer-script-should-not-use-gconftool
mknod-in-maintainer-script
possibly-insecure-handling-of-tmp-files-in-maintainer-script
diff --git a/t/tests/scripts-maintainer-general/tags b/t/tests/scripts-maintainer-general/tags
index 124cca0..9f5affa 100644
--- a/t/tests/scripts-maintainer-general/tags
+++ b/t/tests/scripts-maintainer-general/tags
@@ -21,7 +21,6 @@ W: scripts-maintainer-general: command-with-path-in-maintainer-script postinst:1
W: scripts-maintainer-general: command-with-path-in-maintainer-script postinst:91 /usr/bin/baz
W: scripts-maintainer-general: deprecated-chown-usage postinst:14 'chown root.root'
W: scripts-maintainer-general: deprecated-chown-usage postinst:84 'chown -R root.root'
-W: scripts-maintainer-general: fc-cache-used-in-maintainer-script postinst:95
W: scripts-maintainer-general: install-info-used-in-maintainer-script postinst:105
W: scripts-maintainer-general: maintainer-script-has-unexpanded-debhelper-token postinst
W: scripts-maintainer-general: maintainer-script-hides-init-failure postinst:31
@@ -30,6 +29,7 @@ W: scripts-maintainer-general: maintainer-script-needs-depends-on-adduser postin
W: scripts-maintainer-general: maintainer-script-needs-depends-on-gconf2 postinst
W: scripts-maintainer-general: maintainer-script-needs-depends-on-ucf postinst
W: scripts-maintainer-general: maintainer-script-needs-depends-on-xml-core postinst
+W: scripts-maintainer-general: maintainer-script-should-not-use-fc-cache postinst:95
W: scripts-maintainer-general: maintainer-script-should-not-use-gconftool postinst:153
W: scripts-maintainer-general: maintainer-script-should-not-use-gconftool postinst:44
W: scripts-maintainer-general: possibly-insecure-handling-of-tmp-files-in-maintainer-script postinst:26
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: