Re: Check for deprecated automake configure.in (wishlist #708482)
On 2013-08-16 22:18, Gautier Minster wrote:
> Hello,
>
Hi,
Thank you for your interest in helping Lintian. :)
> I wrote a lintian check for wishlist item #708482, which simply checks
> for an Automake Makefile.am and a deprecated configure.in in source
> packages.
>
> Since this is my first lintian check, I'm pretty sure it's far from
> perfect, so I would be grateful if you could give me some feedback!
>
It looks pretty good; I have interleaved my remarks in the patch below.
The only thing missing is a test for it. Getting started on that
should basically be a matter of:
mkdir -p t/tests/automake-general/debian
touch t/tests/automake-general/debian/configure.in
touch t/tests/automake-general/debian/Makefile.am
touch t/tests/automake-general/tags
cp t/tests/control-file-symlink/desc \
t/tests/automake-general
And then edit t/tests/automake-general/desc (Change the Testname,
Description and Test-For). You can run your test with:
debian/rules runtests onlyrun=automake
This should fail if my quick-test is correct and your check works. To
have it succeed, you have to update the t/tests/automake-general/tags
file to contain the (sorted) lintian output.
NB: The above assumes you have incorporated the changes below.
> Best regards,
>
> -- Gautier Minster
>
>
> automake.pm-708482.patch
>
>
> [..]
> --- /dev/null
> +++ b/checks/automake.desc
> @@ -0,0 +1,13 @@
> [...]
> +Tag: deprecated-configure-filename
> +Severity: pedantic
I think it should be at least a wishlist and possibly even normal.
> +Certainty: possible
This /might/ be certain. I believe we use it as a indicator of how
likely a false-positive is (i.e. if it only have false-negatives, then I
believe we would call it certain).
> +Info: The Autoconf input file name 'configure.in' is deprecated, use 'configure.ac'.
> +Ref: https://lists.gnu.org/archive/html/automake/2013-05/msg00049.html
> +Experimental: yes
> diff --git a/checks/automake.pm b/checks/automake.pm
> new file mode 100644
> index 0000000..952ddb6
> --- /dev/null
> +++ b/checks/automake.pm
> [...]
> +
> -- 1.8.4.rc2
>
The code itself looks good at first glance. There are some minor
stylistic things, but I believe we are currently considering to use
perltidy. Hopefully soon such things will be a thing of the past. :)
The perltidy rules suggested are available at [1] in case you want to
try it. :)
~Niels
[1] http://lists.debian.org/<[🔎] 520A80EF.1090106@thykier.net>
Reply to: