Bug#718862: composer-package-without-pkg-php-tools-builddep should not be a warning
On Wed, August 7, 2013 11:32, Mathieu Parent wrote:
> Le 6 août 2013 12:03, "Thijs Kinkhorst" <thijs@debian.org> a écrit :
>>
>> Package: lintian
>> Version: 2.5.15
>> Severity: normal
>>
>> Hi,
> Hi Thijs,
>
>> Lintian 2.5.15 added a number of tests related to pkg-php-tools.
>> The test "composer-package-without-pkg-php-tools-builddep" displays
>> a warning on every package containing a composer.json file.
>
> Yes, when this file is on package's root.
>
>> This seems over the top to me. My PHP application has functional
>> packaging developed over the years and I see no urgent need to
>> throw it away and rebuild it in pkh-php-tools just because upstream
>> also ships a composer.json.
>
> Composer support in pkg-php-tools is very useful to manage dependencies.
> See dh_phpcomposer man page.
I know about it. However, e.g. for my package phpMyAdmin, it doesn't
provide any value currently (it detects only the PHP dependency out of the
18 dependencies that my package needs). This is not a problem with
Composer per se, but may be due to the shipped composer.json not being
elaborate enough.
Also, dh_phpcomposer seems to be not very mature. It generates more than
30 warnings when building my package, including PHP warnings written to
the substvars file.
Just to be clear: I'm not at all wishing to diminish your work, and it
will no doubt improve - I'm just arguing that this is not something we
should be raising Lintian Warnings about at this point if people are not
using it. It needs more time before it can be generically usable and
before we can claim that it's a problem if your package is not using it.
>> I would recommend to flag this as "info" at best. In general,
>
> Probably yes.
>
>> I would also advise to add new tests as "experimental" initially.
>
> This is not a false positive, and tagging it experimental basically means
> fewer testing.
That's why I said "initially". Gain some experience with it first; when
proven, raise severity appropriately.
Thijs
Reply to: