[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.14-29-g71b0a0c



The following commit has been merged in the master branch:
commit cdc505f541ec8b30c793d4e391193fded2da4ee3
Author: Bastien ROUCARIÈS <roucaries.bastien@gmail.com>
Date:   Sun Jun 30 21:26:12 2013 +0200

    c/manpages.pm: Check if manapage name include buildd
    
    Example:
        usr/share/man/man3/_build_buildd-openchange_1.0-3-i386-mbKpOA_openchange-1.0_doc_.3.gz
    
    [nthykier: rename tag and reword description]
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/manpages.desc b/checks/manpages.desc
index 1b22764..2a6e77d 100644
--- a/checks/manpages.desc
+++ b/checks/manpages.desc
@@ -271,3 +271,11 @@ Info: Lintian found a spelling error in the manpage. Lintian has a list
  avoid making the translations fuzzy.  With gettext, for example, this
  means you should also fix the spelling mistake in the corresponding
  msgids in the *.po files.
+
+Tag: manpage-named-after-build-path
+Severity: important
+Certainty: certain
+Info: The manual page appear to be named after its build path and
+ not after its content.
+ .
+ Please check your debian/rules or upstream Makefile.
diff --git a/checks/manpages.pm b/checks/manpages.pm
index be67f6f..ebe7558 100644
--- a/checks/manpages.pm
+++ b/checks/manpages.pm
@@ -80,8 +80,12 @@ foreach my $file ($info->sorted_index) {
         (($path =~ m,^usr/man(/\S+),o)
          or ($path =~ m,^usr/X11R6/man(/\S+),o)
          or ($path =~ m,^usr/share/man(/\S+),o) );
-
     my $t = $1;
+
+    if( $file =~ m/_build_buildd/ or $file =~ /_tmp_buildd/) {
+        tag 'manpage-named-after-build-path', $file;
+    }
+
     if (not $t =~ m,^.*man(\d)/$,o) {
         tag 'manpage-in-wrong-directory', $file;
         next;
diff --git a/debian/changelog b/debian/changelog
index cf2eb55..03d46ad 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,9 +1,17 @@
 lintian (2.5.15) UNRELEASED; urgency=low
 
+  * Summary of tag changes:
+    + Added:
+      - manpage-named-after-build-path
+
   * checks/*.pm:
     + [NT] Add final return to all subs in checks and ensure
       that the "run" sub complies with Lintian's own
       recommendation.
+  * checks/manpages.{desc,pm}:
+    + [NT] Apply patch from Bastien Roucariès to test for
+      manpages named after their build path.
+      (Closes: #713884)
   * checks/systemd.{desc,pm}:
     + [NT] New check for systemd related files.  Thanks to
       Michael Stapelberg for providing the check and the
diff --git a/t/tests/manpages-general/debian/debian/rules b/t/tests/manpages-general/debian/debian/rules
index ca84f25..2dd7774 100755
--- a/t/tests/manpages-general/debian/debian/rules
+++ b/t/tests/manpages-general/debian/debian/rules
@@ -47,6 +47,9 @@ override_dh_auto_install:
 	pod2man --section 6 simple.pod | gzip -c --best > \
 		$(tmp)/usr/share/man/man6/simple.pod.gz
 
+	pod2man --section 6 simple.pod | gzip -c --best > \
+		$(tmp)/usr/share/man/man6/_build_buildd-openchangex_1.0-3-i386-mbKpOA_openchange-1.0_simple.6.gz
+
 	gzip -c9 < test.1p.de \
 	    > $(tmp)/usr/share/man/man1/test-latin1-chars.1p.gz
 	gzip -c9 < test.1p.de \
diff --git a/t/tests/manpages-general/desc b/t/tests/manpages-general/desc
index f1779e4..e4b8aba 100644
--- a/t/tests/manpages-general/desc
+++ b/t/tests/manpages-general/desc
@@ -17,6 +17,7 @@ Test-For:
  manpage-has-wrong-extension
  manpage-is-dh_make-template
  manpage-locale-dir-country-specific
+ manpage-named-after-build-path
  manpage-not-compressed
  manpage-not-compressed-with-gzip
  manpage-not-compressed-with-max-compression
diff --git a/t/tests/manpages-general/tags b/t/tests/manpages-general/tags
index 497efff..5e3e3df 100644
--- a/t/tests/manpages-general/tags
+++ b/t/tests/manpages-general/tags
@@ -8,6 +8,7 @@ E: manpages-general: empty-manual-page usr/share/man/man6/usr-games-binary.6.gz
 E: manpages-general: manpage-has-wrong-extension usr/share/man/man6/simple.pod.gz
 E: manpages-general: manpage-is-dh_make-template usr/X11R6/man/man1/rstartd.1x.gz
 E: manpages-general: manpage-is-dh_make-template usr/share/man/man1/program.1.gz
+E: manpages-general: manpage-named-after-build-path usr/share/man/man6/_build_buildd-openchangex_1.0-3-i386-mbKpOA_openchange-1.0_simple.6.gz
 E: manpages-general: manpage-not-compressed usr/share/man/de/man1/binary-without-english-manpage.1
 E: manpages-general: manpage-not-compressed usr/share/man/man1/usr-bin-binary.1
 E: manpages-general: manpage-not-compressed-with-gzip usr/share/man/man1/usr-bin-binary-alt.1.gz

-- 
Debian package checker


Reply to: