[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.14-15-gaa2aad7



The following commit has been merged in the master branch:
commit aa2aad759903d6e9747421fad8447fea7914daf6
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Jun 30 18:14:24 2013 +0200

    Add (and comply with) "RequireFinalReturn" perlcritic policy
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/.perlcriticrc b/.perlcriticrc
index 170054a..6e53433 100644
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -8,7 +8,7 @@ severity = 1
 # Work based on a whitelist
 only = 1
 # Our whitelist (ignores severity):
-include = ExplicitReturnUndef GlobFunction NegativeIndices PrivateVars UselessInitialization MatchVars NumberSeparators NullStatements LongChainsOfMethodCalls UseStrict UseWarnings EndWithOne ConditionalUseStatements PackageMatchesPodName JoinedReadline UnreachableCode TrailingWhitespace InterpolationOfLiterals ImplicitNewlines CommaSeparatedStatements UseStrict UseWarnings UnusedVariables UnusedCapture TwoArgOpen ProhibitHardTabs MismatchedOperators IndirectSyntax Modules:: BuiltinFunctions:: ClassHierarchies:: CommaSeparatedStatements QuotesAsQuotelikeOperatorDelimiters MixedBooleanOperators ProhibitBarewordFileHandles
+include = ExplicitReturnUndef GlobFunction NegativeIndices PrivateVars UselessInitialization MatchVars NumberSeparators NullStatements LongChainsOfMethodCalls UseStrict UseWarnings EndWithOne ConditionalUseStatements PackageMatchesPodName JoinedReadline UnreachableCode TrailingWhitespace InterpolationOfLiterals ImplicitNewlines CommaSeparatedStatements UseStrict UseWarnings UnusedVariables UnusedCapture TwoArgOpen ProhibitHardTabs MismatchedOperators IndirectSyntax Modules:: BuiltinFunctions:: ClassHierarchies:: CommaSeparatedStatements QuotesAsQuotelikeOperatorDelimiters MixedBooleanOperators ProhibitBarewordFileHandles ConditionalUseStatements
 #include = MixedBooleanOperators InteractiveTest UpperCaseHeredoc ReusedNames PackageVars ConditionalDeclarations SingleCharAlternation FixedStringMatches ConditionalUseStatements QuotedWordLists
 
 exclude = RequireFilenameMatchesPackage RequireVersionVar ProhibitExcessMainComplexity ProhibitStringySplit ComplexMappings StringyEval
@@ -40,6 +40,9 @@ functions = open opendir chdir read readdir readline closedir sysopen sysread sy
 # Maybe some day...
 [-Modules::ProhibitExcessMainComplexity]
 
+[Subroutines::RequireFinalReturn]
+terminal_funcs = CORE::exec fail Lintian::Util::fail Die
+
 [ValuesAndExpressions::ProhibitInterpolationOfLiterals]
 
 [ValuesAndExpressions::ProhibitCommaSeparatedStatements]
diff --git a/collection/ar-info b/collection/ar-info
index 0cb827b..537d210 100755
--- a/collection/ar-info
+++ b/collection/ar-info
@@ -66,6 +66,8 @@ foreach my $file ($info->sorted_index) {
 }
 
 close($out_fd);
+
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)ar-info$,;
diff --git a/collection/bin-pkg-control b/collection/bin-pkg-control
index f53ba69..0533867 100755
--- a/collection/bin-pkg-control
+++ b/collection/bin-pkg-control
@@ -86,6 +86,7 @@ for my $file (ERROR_FILES) {
     unlink($path) if -z $path;
 }
 
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)bin-pkg-control$,;
diff --git a/collection/changelog-file b/collection/changelog-file
index a9e8f61..0ca72ef 100755
--- a/collection/changelog-file
+++ b/collection/changelog-file
@@ -131,6 +131,7 @@ if (-f $news) {
     }
 }
 
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)changelog-file$,;
diff --git a/collection/copyright-file b/collection/copyright-file
index fc3042e..cd590ce 100755
--- a/collection/copyright-file
+++ b/collection/copyright-file
@@ -60,6 +60,7 @@ if (-l $file) {
     gunzip_file ("$file.gz", "$dir/copyright");
 }
 
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)copyright-file$,;
diff --git a/collection/debian-readme b/collection/debian-readme
index 3d79478..3e0d300 100755
--- a/collection/debian-readme
+++ b/collection/debian-readme
@@ -71,6 +71,7 @@ if (not defined $file) {
     link($file, "$dir/README.Debian");
 }
 
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)debian-readme$,;
diff --git a/collection/diffstat b/collection/diffstat
index f13a38f..5d2e5f8 100755
--- a/collection/diffstat
+++ b/collection/diffstat
@@ -68,6 +68,7 @@ while (<$in>) {
 close($out);
 close($in);
 
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)diffstat$,;
diff --git a/collection/doc-base-files b/collection/doc-base-files
index 552eca4..46e7df6 100755
--- a/collection/doc-base-files
+++ b/collection/doc-base-files
@@ -45,6 +45,8 @@ if ( -d "$dir/unpacked/usr/share/doc-base") {
     copy_dir ("$dir/unpacked/usr/share/doc-base", "$dir/doc-base")
         or fail('cannot copy directory unpacked/usr/share/doc-base');
 }
+
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)doc-base-files$,;
diff --git a/collection/file-info b/collection/file-info
index 907dd03..f59d317 100755
--- a/collection/file-info
+++ b/collection/file-info
@@ -66,6 +66,7 @@ foreach my $file ($info->sorted_index) {
 close($opts{pipe_in});
 reap(\%opts);
 
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)file-info$,;
diff --git a/collection/hardening-info b/collection/hardening-info
index 06d6e4f..5018d9d 100755
--- a/collection/hardening-info
+++ b/collection/hardening-info
@@ -80,6 +80,7 @@ if (%opts) {
     reap (\%opts);
 }
 
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)hardening-info$,;
diff --git a/collection/index b/collection/index
index d5a7dac..296caa9 100755
--- a/collection/index
+++ b/collection/index
@@ -60,6 +60,7 @@ if ($type ne 'source') {
            '|', ['sort', '-k', '6'], '|', ['gzip', '-9c']);
 }
 
+return;
 }
 
 # Creates an index for binary packages
diff --git a/collection/init.d b/collection/init.d
index ba9372b..1ca2ce4 100755
--- a/collection/init.d
+++ b/collection/init.d
@@ -45,6 +45,8 @@ if (-d "$dir/unpacked/etc/init.d") {
     copy_dir("$dir/unpacked/etc/init.d", "$dir/init.d")
         or fail('cannot copy init.d directory');
 }
+
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)init\.d$,;
diff --git a/collection/java-info b/collection/java-info
index 6265f7d..2974ef3 100755
--- a/collection/java-info
+++ b/collection/java-info
@@ -143,7 +143,8 @@ if (%opts) {
     reap (\%opts);
 }
 
-};
+return;
+}
 
 collect (@ARGV) if $0 =~ m,(?:^|/)java-info$,;
 1;
diff --git a/collection/md5sums b/collection/md5sums
index 02897f4..193ebed 100755
--- a/collection/md5sums
+++ b/collection/md5sums
@@ -53,6 +53,8 @@ foreach my $file ($info->sorted_index) {
 
 close($opts{pipe_in});
 reap(\%opts);
+
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)md5sums$,;
diff --git a/collection/menu-files b/collection/menu-files
index f33e4bb..c2c7949 100755
--- a/collection/menu-files
+++ b/collection/menu-files
@@ -63,6 +63,7 @@ while (my ($shortn, $path) = each %dirs) {
     }
 }
 
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)menu-files$,;
diff --git a/collection/objdump-info b/collection/objdump-info
index 3e32c75..f8e9a55 100755
--- a/collection/objdump-info
+++ b/collection/objdump-info
@@ -69,6 +69,7 @@ foreach my $bin ($info->sorted_index) {
 close($opts{pipe_in});
 reap(\%opts);
 
+return;
 };
 
 collect (@ARGV) if $0 =~ m,(?:^|/)objdump-info$,;
diff --git a/collection/override-file b/collection/override-file
index 2e8b7a3..c0c403a 100755
--- a/collection/override-file
+++ b/collection/override-file
@@ -68,6 +68,7 @@ if (not defined $file) {
     link($file, "$dir/override");
 }
 
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)override-file$,;
diff --git a/collection/scripts b/collection/scripts
index 710a042..106260c 100755
--- a/collection/scripts
+++ b/collection/scripts
@@ -82,6 +82,7 @@ for my $file (readdir($dirfd)) {
 closedir($dirfd);
 close($ctrl_fd);
 
+return;
 }
 
 sub shebang_line {
diff --git a/collection/src-orig-index b/collection/src-orig-index
index 63f9e58..f0d9fe2 100755
--- a/collection/src-orig-index
+++ b/collection/src-orig-index
@@ -50,6 +50,7 @@ if ($info->native) {
 
 index_orig ($pkg, $dir, $info);
 
+return;
 }
 
 # returns all (orig) tarballs.
diff --git a/collection/strings b/collection/strings
index 474ed5d..db75238 100755
--- a/collection/strings
+++ b/collection/strings
@@ -111,6 +111,7 @@ if (@manual) {
 }
 close($elf_fd);
 
+return;
 }
 
 collect (@ARGV) if $0 =~ m,(?:^|/)strings$,;
diff --git a/collection/unpacked b/collection/unpacked
index ff7597f..1322f22 100755
--- a/collection/unpacked
+++ b/collection/unpacked
@@ -90,6 +90,7 @@ if ($type eq 'source') {
 # Remove the error file if it is empty
 unlink("$dir/unpacked-errors") if -z "$dir/unpacked-errors";
 
+return;
 }
 
 sub dump_errors {
@@ -99,6 +100,7 @@ sub dump_errors {
         print STDERR $line;
     }
     close($fd);
+    return;
 }
 
 sub libdpkg_unpack_dsc {
diff --git a/frontend/lintian b/frontend/lintian
index 26053e3..79410e0 100755
--- a/frontend/lintian
+++ b/frontend/lintian
@@ -232,6 +232,7 @@ sub record_action {
         die("too many actions specified: $_[0]");
     }
     $action = "$_[0]";
+    return;
 }
 
 # Record Parts requested for checking
@@ -248,6 +249,7 @@ sub record_check_part {
     }
     $action = 'check';
     $checks = "$_[1]";
+    return;
 }
 
 # Record Parts requested for checking
@@ -267,6 +269,7 @@ sub record_check_tags {
     }
     $action = 'check';
     $check_tags = "$_[1]";
+    return;
 }
 
 # Record Parts requested for checking
@@ -283,7 +286,7 @@ sub record_check_tags_from_file {
         push(@tags, split(/\s*,\s*/, $line));
     }
     close($file);
-    record_check_tags($option, join(',', @tags));
+    return record_check_tags($option, join(',', @tags));
 }
 
 # Record tags that should be suppressed.
@@ -293,6 +296,7 @@ sub record_suppress_tags {
     for my $tag (split(/\s*,\s*/, $tags)) {
         $suppress_tags{$tag} = 1;
     }
+    return;
 }
 
 # Record tags that should be suppressed from a file.
@@ -308,6 +312,7 @@ sub record_suppress_tags_from_file {
         record_suppress_tags($option, $line);
     }
     close($file);
+    return;
 }
 
 # Record Parts requested not to check
@@ -324,6 +329,7 @@ sub record_dont_check_part {
     }
     $action = 'check';
     $dont_check = "$_[1]";
+    return;
 }
 
 # Record what type of data is specified
@@ -332,6 +338,7 @@ sub record_pkgmode {
     $pkg_mode = 'binary' if $_[0] eq 'binary';
     $pkg_mode = 'source' if $_[0] eq 'source';
     $pkg_mode = 'udeb' if $_[0] eq 'udeb';
+    return;
 }
 
 # Process -L|--display-level flag
@@ -354,16 +361,19 @@ sub record_display_level {
         }
     }
     push(@display_level, [ $op, $rel, $severity, $certainty ]);
+    return;
 }
 
 # Process -I|--display-info flag
 sub display_infotags {
     push(@display_level, [ '+', '>=', 'wishlist' ]);
+    return;
 }
 
 # Process --pedantic flag
 sub display_pedantictags {
     push(@display_level, [ '+', '=', 'pedantic' ]);
+    return;
 }
 
 # Process --default-display-level flag
@@ -373,16 +383,19 @@ sub default_display_level {
          ['+', '>=', 'normal', 'possible'],
          ['+', '>=', 'minor', 'certain'],
         );
+    return;
 }
 
 # Process --display-source flag
 sub record_display_source {
     $display_source{$_[1]} = 1;
+    return;
 }
 
 # Process -q|--quite flag
 sub record_quiet {
     $opt{'verbose'} = -1;
+    return;
 }
 
 # Process display-info and display-level options in cfg files
@@ -422,7 +435,7 @@ sub cfg_display_level {
             record_display_level('display-level', $dl);
         }
     }
-
+    return;
 }
 
 # Processes quiet and verbose options in cfg files.
@@ -446,6 +459,7 @@ sub cfg_verbosity {
     # "feature".
     $val = -$val if $var eq 'quiet';
     $opt{'verbose'} = $val;
+    return;
 }
 
 # Process overrides option in the cfg files
@@ -454,6 +468,7 @@ sub cfg_override {
     return if defined $opt{'no-override'};
     # This option is inverted in the config file
     $opt{'no-override'} = !$val;
+    return;
 }
 
 # Hash used to process commandline options
@@ -1242,6 +1257,7 @@ sub post_pkg_process_overrides{
         $overrides{warnings} += $warnings;
         $overrides{info} += $info;
     }
+    return;
 }
 
 sub prep_unpack_error {
@@ -1276,6 +1292,7 @@ sub unpack_group {
     );
 
     $unpacker->process_tasks (\%hooks);
+    return;
 }
 
 sub finish_hook {
@@ -1297,6 +1314,7 @@ sub finish_hook {
             $changed->() if $ret;
         }
     }
+    return;
 }
 
 sub coll_hook {
@@ -1486,6 +1504,7 @@ sub handle_lab_query {
         warning ("cannot find binary, udeb or source package $orig in lab (skipping)");
         $exit_code = 2;
     }
+    return;
 }
 
 sub _find_cfg_file {
@@ -1674,6 +1693,7 @@ sub _update_profile {
     if (%$sup_tags and not $check_tags) {
         $profile->disable_tags (keys %$sup_tags);
     }
+    return;
 }
 
 # }}}
diff --git a/helpers/coll/objdump-info-helper b/helpers/coll/objdump-info-helper
index 51ec04b..43f8eb1 100755
--- a/helpers/coll/objdump-info-helper
+++ b/helpers/coll/objdump-info-helper
@@ -226,4 +226,5 @@ sub finish_file {
     $section = '';
     %program_headers = ();
     $bin = '';
+    return;
 }
diff --git a/private/generate-lintian-pod b/private/generate-lintian-pod
index a1581ca..6fefb4b 100755
--- a/private/generate-lintian-pod
+++ b/private/generate-lintian-pod
@@ -70,6 +70,7 @@ sub pretty_print {
         print "$line\n";
     }
     print "\n\n";
+    return;
 }
 
 sub extract_data {
@@ -100,6 +101,7 @@ sub extract_data {
         }
     }
     print "=back\n\n";
+    return;
 }
 
 # Local Variables:
diff --git a/private/generate-profiles.pl b/private/generate-profiles.pl
index c0e666a..2890e8d 100755
--- a/private/generate-profiles.pl
+++ b/private/generate-profiles.pl
@@ -94,6 +94,7 @@ sub generate_profile {
         print $fd "\n";
     }
     close($fd) or die "$filename: $!";
+    return;
 }
 
 sub format_field {
@@ -112,6 +113,7 @@ sub format_field {
         }
     }
     print $fd "\n";
+    return;
 }
 
 sub read_tags {
diff --git a/private/graph b/private/graph
index c11e2ad..a3570ed 100755
--- a/private/graph
+++ b/private/graph
@@ -169,6 +169,7 @@ sub gen_depth_level {
     # Done - generate ranks and the graph
 
     @ranks = map { ['same', $_] } @levels;
+    return;
 }
 
 sub mark_longest_paths {
@@ -219,6 +220,7 @@ sub make_graph {
     }
     print "\n";
     _footer();
+    return;
 }
 
 sub is_marked {
@@ -264,6 +266,7 @@ sub gen_coll_check {
         }
     }
 
+    return;
 }
 
 sub _header {
@@ -275,6 +278,7 @@ digraph "lintian-collections" {
 
 EOF
 
+    return;
 }
 
 sub _footer {
@@ -287,6 +291,7 @@ sub _footer {
         print "\n";
     }
     print "}\n";
+    return;
 }
 
 sub usage {
diff --git a/private/refresh-archs b/private/refresh-archs
index 8590ced..9614843 100755
--- a/private/refresh-archs
+++ b/private/refresh-archs
@@ -175,6 +175,7 @@ sub write_data_line {
             push @{ $files{$filename}->{'lines'} }, $line;
         }
     }
+    return;
 }
 
 sub open_data_files {
@@ -204,6 +205,7 @@ sub open_data_files {
         }
         print $fd "\n";
     }
+    return;
 }
 
 sub add_data_file {
@@ -213,6 +215,7 @@ sub add_data_file {
     $data{'header'} //= '';
     $data{'keep'} //= 0;
     $files{$file} = \%data;
+    return;
 }
 
 sub close_and_rename {
@@ -229,5 +232,6 @@ sub close_and_rename {
         my $df = "$datapath/$filename";
         system ('mv', '-f', $tf, $df) == 0 or die "mv -f $tf $df failed.\n";
     }
+    return;
 }
 
diff --git a/private/refresh-locale-codes b/private/refresh-locale-codes
index 9cd46bb..cd8682f 100755
--- a/private/refresh-locale-codes
+++ b/private/refresh-locale-codes
@@ -103,14 +103,7 @@ sub parse_iso_xml {
     }
 
     close $fd;
-
-}
-
-sub translator {
-    return unless m/\bid=/;
-    # Skip "special" types (#692548, comment #10)
-    return if m/\btype=[\"\']S?[\"\']/;
-    s/^.*id="([^"]+)".*$/xxx $1 x/;
+    return;
 }
 
 sub parse_iso_query {
@@ -132,6 +125,7 @@ sub parse_iso_query {
         }
     }
     close $fd;
+    return;
 }
 
 sub check_requirements {
diff --git a/private/refresh-perl-provides b/private/refresh-perl-provides
index 5f81b78..0d1481c 100755
--- a/private/refresh-perl-provides
+++ b/private/refresh-perl-provides
@@ -166,7 +166,7 @@ sub cpan_version_to_deb {
                 $prefix .= '0' while length($prefix) < $digits;
         }
         $suffix = ".$suffix" if $suffix ne '';
-        $epoch.$major.$prefix.$suffix;
+        return $epoch.$major.$prefix.$suffix;
 }
 
 # Given a Debian binary package name, look up its latest version
diff --git a/private/update-coverage b/private/update-coverage
index 281c7bd..a0547fe 100755
--- a/private/update-coverage
+++ b/private/update-coverage
@@ -154,6 +154,7 @@ sub print_tags {
         }
         print {$out} "$file $tag\n";
     }
+    return;
 }
 
 # Local Variables:
diff --git a/reporting/harness b/reporting/harness
index 3025a24..2c3a307 100755
--- a/reporting/harness
+++ b/reporting/harness
@@ -472,6 +472,7 @@ exit 0;
 sub Log {
     print {$LOG_FD} $_[0],"\n";
     print $_[0], "\n" if $opt{'to-stdout'};
+    return;
 }
 
 sub run {
@@ -594,6 +595,7 @@ sub _parse_pkgs_pg {
     $data->{'timestamp'} = $ts;
 
     $manifest->set ($data);
+    return;
 }
 
 # Helper for local_mirror_manifests - it parses a paragraph from Sources file
@@ -626,6 +628,7 @@ sub _parse_srcs_pg {
 
     # $manifest strips redundant fields for us.
     $manifest->set ($data);
+    return;
 }
 
 # Local Variables:
diff --git a/reporting/html_reports b/reporting/html_reports
index 14bab83..5b0a234 100755
--- a/reporting/html_reports
+++ b/reporting/html_reports
@@ -738,6 +738,7 @@ sub output_template {
     $template->fill_in(OUTPUT => $fd, HASH => $data)
         or die "filling out $file failed: $Text::Template::ERROR\n";
     close($fd);
+    return;
 }
 
 # Sort function for sorting lists of tags.  Sort by package, version, area,
diff --git a/t/helpers/bin/create-deb b/t/helpers/bin/create-deb
index 8039c6e..d492e2d 100755
--- a/t/helpers/bin/create-deb
+++ b/t/helpers/bin/create-deb
@@ -205,12 +205,13 @@ Note: This does not use dpkg-deb, so it can be used to generate deb
 files that dpkg-deb would (now or in the future) refuse to build.
 
 EOF
-
+    return;
 }
 
 sub runsystem {
     print "create-deb system:  @_\n";
     my $r = system @_;
     die "system @_ failed (exit status: " . (($r >> 8) & 0xff) .")\n" if $r;
+    return;
 }
 
diff --git a/t/runtests b/t/runtests
index c16c2ce..b7197a9 100755
--- a/t/runtests
+++ b/t/runtests
@@ -384,6 +384,7 @@ sub copy_template_dir {
     runsystem('rsync', '-rpc', "$skel/", "$targetdir/", @exs);
     runsystem('rsync', '-rpc', "$tsrc/", "$targetdir/", @ext)
         if -d "$tsrc/";
+    return;
 }
 
 # Run a package test and show any diffs in the expected tags or any other
@@ -842,6 +843,7 @@ sub run_tests{
         }
     }
 
+    return;
 }
 
 sub dump_log{
@@ -862,6 +864,7 @@ sub runsystem {
     print "runsystem(@_)\n" if $DEBUG;
     system(@_) == 0
         or fail("failed: @_\n");
+    return;
 }
 
 sub runsystem_ok {
@@ -896,9 +899,10 @@ sub fill_in_tmpl {
     open(my $out, '>', $file);
 
     unless ($template->fill_in(OUTPUT => $out, HASH => $data)) {
-        fail("cannout create $file");
+        fail("cannot create $file");
     }
     close($out);
+    return;
 }
 
 sub check_test_is_sane {
@@ -1009,11 +1013,13 @@ sub skip_reason {
 sub msg_flush {
     my %msg = ( id => threads->tid() );
     $MSG_Q->enqueue(\%msg);
+    return;
 }
 
 sub msg_print {
     my %msg = ( id => threads->tid(), msg => "@_" );
     $MSG_Q->enqueue(\%msg);
+    return;
 }
 
 sub _flush {
@@ -1024,6 +1030,7 @@ sub _flush {
     }
     print "\n";
     delete $thrs->{$id};
+    return;
 }
 
 sub msg_queue_handler {
@@ -1083,6 +1090,8 @@ sub _msg_qh {
         printf "%-${length}s\r", $output;
         $length = length($output);
     }
+    # This should not be reachable, but perlcritic doesn't know that.
+    return;
 }
 
 # Local Variables:
diff --git a/t/scripts/Lintian/Lab/repair.t b/t/scripts/Lintian/Lab/repair.t
index 96ae46a..9a4b40e 100755
--- a/t/scripts/Lintian/Lab/repair.t
+++ b/t/scripts/Lintian/Lab/repair.t
@@ -128,5 +128,5 @@ sub do_tests {
 
     $LAB_B->close;
 
-    done_testing;
+    return done_testing;
 }
diff --git a/t/scripts/check-load.t b/t/scripts/check-load.t
index f9b40b1..9d14a4e 100755
--- a/t/scripts/check-load.t
+++ b/t/scripts/check-load.t
@@ -28,7 +28,7 @@ use Test::Lintian;
 # Test that all checks can be loaded (except lintian.desc, which is
 # a special case).
 sub accept_filter {
-    !m,/lintian\.desc$,;
+    return !m,/lintian\.desc$,;
 }
 
 my $opts = {
diff --git a/t/scripts/implemented-tags.t b/t/scripts/implemented-tags.t
index 2cf4ba6..bbc22f0 100755
--- a/t/scripts/implemented-tags.t
+++ b/t/scripts/implemented-tags.t
@@ -49,7 +49,7 @@ our $EXCLUDE =
 # Exclude "lintian.desc" as it does not have a perl module like other
 # checks.
 sub accept_filter {
-    !m,/lintian\.desc$,;
+    return !m,/lintian\.desc$,;
 }
 
 my $opts = {
diff --git a/t/scripts/profiles-coverage.t b/t/scripts/profiles-coverage.t
index bd77557..2ffc508 100755
--- a/t/scripts/profiles-coverage.t
+++ b/t/scripts/profiles-coverage.t
@@ -45,6 +45,7 @@ sub parse_check {
         push @$list, $tag->{tag};
         $TAGS{$tag->{tag}} = 0;
     }
+    return;
 }
 
 sub trim_split {
@@ -85,13 +86,16 @@ sub parse_profile {
             die "Unknown tag ($tag) in $profile.\n" unless exists $TAGS{$tag};
         }
     }
+    return;
 }
 
 sub check_wanted {
     parse_check ($_) if -f && m/\.desc$/o;
+    return;
 }
 
 sub prof_wanted {
     parse_profile($_) if -f && m/\.profile$/o;
+    return;
 }
 

-- 
Debian package checker


Reply to: