[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.13-36-g22d830b



The following commit has been merged in the master branch:
commit 22d830b6952ce5cbb84160c59896ef48c3ea4675
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Jun 16 12:53:49 2013 +0200

    c/fields: Retire upstream-version-not-numeric
    
    Dpkg::Version does not consider such upstream versions for valid
    anymore, so it is not possible to trigger this tag.  Packages will
    instead trigger "bad-version-number".
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/fields.desc b/checks/fields.desc
index 36f4f91..dc4d17f 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -53,12 +53,6 @@ Certainty: certain
 Info: The version number fails one of the syntactic requirements of dpkg.
 Ref: policy 5.6.12
 
-Tag: upstream-version-not-numeric
-Severity: important
-Certainty: certain
-Info: The upstream version number should start with a digit. 
-Ref: policy 5.6.12
-
 Tag: debian-revision-not-well-formed
 Severity: normal
 Certainty: certain
diff --git a/checks/fields.pm b/checks/fields.pm
index 81f83a2..47687d4 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -240,9 +240,6 @@ if (not defined $info->field('version')) {
 
     if ($dversion->is_valid) {
         my ($upstream, $debian) = ($dversion->version, $dversion->revision);
-        if ($upstream !~ /^\d/i) {
-            tag 'upstream-version-not-numeric', $version;
-        }
         # Dpkg::Version sets the debian revision to 0 if there is no revision.
         # - so we need to check if the raw version ends with "-0".
         tag 'debian-revision-should-not-be-zero', $version
diff --git a/debian/changelog b/debian/changelog
index 2efe90f..4d674e3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,9 @@
 lintian (2.5.14) UNRELEASED; urgency=low
 
+  * Summary of tag changes:
+    + Removed:
+      - upstream-version-not-numeric
+
   * checks/*:
     + [NT] Rename all checks to include the extension ".pm".
       (Closes: #710405)
@@ -13,8 +17,11 @@ lintian (2.5.14) UNRELEASED; urgency=low
       positives in the GDFL related checks.  (Closes: #711119)
     + [NT] Show the full path with source-contains-unsafe-symlink
       rather than just the "basename".
-  * checks/fields.desc:
+  * checks/fields.{desc,pm}:
     + [NT] Fix typo, thanks to Adrien Cunin.
+    + [NT] Retire upstream-version-not-numeric which can no longer
+      be emitted.  Versions that would previously trigger this tag
+      will now trigger bad-version-number instead.
 
   * coll/*:
     + [NT] Set "Auto-Remove: yes" on several collections to
diff --git a/t/COVERAGE b/t/COVERAGE
index 296b423..0ad3732 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,14 +1,12 @@
 Last generated 2013-06-16
-Coverage (Tags): 924/1002 (92.22%), w. legacy tests: 990/1002 (98.80%)
-Coverage (Checks): 33/42 (78.57%), w. legacy tests: 36/42 (85.71%)
+Coverage (Tags): 924/1001 (92.31%), w. legacy tests: 990/1001 (98.90%)
+Coverage (Checks): 34/42 (80.95%), w. legacy tests: 37/42 (88.10%)
 
 The following tags are not tested by the test suite:
 
 binaries binary-file-compressed-with-upx
 binaries ocaml-custom-executable
 
-fields upstream-version-not-numeric
-
 files debug-package-should-be-named-dbg
 files udeb-contains-documentation-file
 

-- 
Debian package checker


Reply to: