Bug#710559: lintian: init.d-script-call-internal-API contradicts /etc/init.d/skeleton

[Russ Allbery <rra@debian.org>]

Package: lintian
Version: 2.5.13
Severity: normal

The new init.d-script-call-internal-API tag says:

W: libapache2-mod-shib2: init.d-script-call-internal-API etc/init.d/shibd
N: 
N:    The given init script call an internal API under /lib/init. /lib/init/rw
N:    has gone away, and the scripts in /lib/init/*.sh represent internal
N:    implementation details of initscripts. They are not public API for other
N:    packages to use. Nonetheless, some packages incorrectly reference those
N:    scripts, notably /lib/init/vars.sh.
N:    
N:    Severity: normal, Certainty: possible
N:    
N:    Check: init.d, Type: binary

but /etc/init.d/skeleton has:

# Load the VERBOSE setting and other rcS variables
. /lib/init/vars.sh

and then uses $VERBOSE extensively, and I don't see any other way for it
to be set.  This is inconsistent; if what skeleton is doing is wrong, then
that file needs to be updated and we need to provide better guidance in
the Lintian tag as to how $VERBOSE is supposed to be handled.

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.8-2-686-pae (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils                       2.22-8
ii  bzip2                          1.0.6-4
ii  diffstat                       1.55-3
ii  file                           1:5.14-2
ii  gettext                        0.18.1.1-10
ii  hardening-includes             2.3
ii  intltool-debian                0.35.0+20060710.1
ii  libapt-pkg-perl                0.1.28
ii  libarchive-zip-perl            1.30-6
ii  libclass-accessor-perl         0.34-1
ii  libclone-perl                  0.34-1
ii  libdpkg-perl                   1.16.10
ii  libemail-valid-perl            0.190-1
ii  libfile-basedir-perl           0.03-1
ii  libipc-run-perl                0.92-1
ii  liblist-moreutils-perl         0.33-1+b1
ii  libparse-debianchangelog-perl  1.2.0-1
ii  libtext-levenshtein-perl       0.06~01-2
ii  libtimedate-perl               1.2000-1
ii  liburi-perl                    1.60-1
ii  man-db                         2.6.3-6
ii  patchutils                     0.3.2-1.1
ii  perl [libdigest-sha-perl]      5.14.2-21
ii  t1utils                        1.37-2

Versions of packages lintian recommends:
pn  libperlio-gzip-perl             <none>
ii  perl-modules [libautodie-perl]  5.14.2-21

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  dpkg-dev               1.16.10
ii  libhtml-parser-perl    3.71-1
ii  libtext-template-perl  1.45-2
ii  xz-utils               5.1.1alpha+20120614-2

-- no debconf information