[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.13-2-gcd5ffc0



The following commit has been merged in the master branch:
commit cd5ffc0ab0ca60d7e0c6b6dd71b2a25678c803e3
Author: Niels Thykier <niels@thykier.net>
Date:   Thu May 30 13:38:45 2013 +0200

    r/harness: Reduce scope a variable and remove another one
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/reporting/harness b/reporting/harness
index a41721c..e971369 100755
--- a/reporting/harness
+++ b/reporting/harness
@@ -377,7 +377,6 @@ unless ($opt{'reports-only'}) {
 
     if (@worklist) {
         # incremental run cmd changes
-        my $lintpipe;
         my $scs = $opt{'schedule-chuck-size'};
         my $round = 0;
         my $rounds = 1;
@@ -394,7 +393,6 @@ unless ($opt{'reports-only'}) {
                       scalar @worklist, $rounds, $scs > 0 ? $scs : 'none'));
 
         while (@worklist) {
-            my $start = 0;
             my $len = scalar @worklist;
             $round++;
             # correct bounds to fit chuck size
@@ -402,17 +400,17 @@ unless ($opt{'reports-only'}) {
 
             Log ("Running Lintian (round $round/$rounds) ...");
             Log (" - cmd: $cmd $output");
-            Log (" - Range: $worklist[$start] ... " . $worklist[$start + $len - 1]);
+            Log(' - Range: ' . $worklist[0] . q{ ... } . $worklist[$len - 1]);
 
             if ($opt{'dry-run'}) {
-                splice @worklist, $start, $len;
+                splice(@worklist, 0, $len);
                 $output = " >>$lintian_log 2>&1";
                 next;
             }
 
-            open $lintpipe, '|-', "$cmd $output"
+            open(my $lintpipe, '|-', "$cmd $output")
                 or Die ("fork failed: $!");
-            foreach my $query (splice @worklist, $start, $len) {
+            foreach my $query (splice(@worklist, 0, $len)) {
                 # Technically, we emit these items in reverse order to Lintian,
                 # but Lintian sorts it anyway
                 print {$lintpipe} "!query: $query\n";

-- 
Debian package checker


Reply to: