[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.12-42-g71c2f54



The following commit has been merged in the master branch:
commit 71c2f54f6f0707f4699ea65c959c86ad6557fba7
Author: Niels Thykier <niels@thykier.net>
Date:   Thu Apr 25 23:40:40 2013 +0200

    c/cruft: Correct bug in is_ancestor_of usage
    
    While the test has a minor flaw on its own, the mistake is caught by a
    separate test immediately after is_ancestor_of check.
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/cruft b/checks/cruft
index bc9f381..fef5c10 100644
--- a/checks/cruft
+++ b/checks/cruft
@@ -381,7 +381,7 @@ sub find_cruft {
         # normalize_pkg_path would approve of "safe-symlink", but if we
         # were to open it we would actually end up escaping the
         # package root.
-        if (-e and not is_ancestor_of($info->unpacked, $_)) {
+        if ( ! -e || ! is_ancestor_of($info->unpacked, $_)) {
             return;
         }
     }

-- 
Debian package checker


Reply to: