[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.12-34-g03c2052

The following commit has been merged in the master branch:
commit 03c2052316d592233ffa0a50fae0c44dcb05a6e5
Author: Russ Allbery <rra@debian.org>
Date:   Mon Apr 22 16:02:21 2013 -0700

    Check for a translation Language-Team pointing to debian-i18n
    
    * checks/po-debconf{,.desc}:
      + [RA] Add new check for a Language-Team field in a translation
        pointing to the debian-i18n mailing list.  Based on work by
        victory.  (Closes: #705197)

diff --git a/checks/po-debconf b/checks/po-debconf
index 47c5bc8..5663e2a 100644
--- a/checks/po-debconf
+++ b/checks/po-debconf
@@ -145,7 +145,12 @@ while (defined(my $file=readdir($po_dirfd))) {
     next if -l "$debfiles/po/$file" || ! -f "$debfiles/po/$file";
     open(PO, '<', "$debfiles/po/$file")
         or fail("Can't open debfiles/po/$file file.");
+    my ($saw_msgstr, $saw_team);
     while (<PO>) {
+        if (/Language\-Team:.*debian-i18n\@lists\.debian\.org/i) {
+            tag 'debconf-translation-using-general-list', $file;
+            $saw_team = 1;
+        }
         last if m/^msgstr/m;
     }
     close(PO);
diff --git a/checks/po-debconf.desc b/checks/po-debconf.desc
index a59fc31..d6e45f4 100644
--- a/checks/po-debconf.desc
+++ b/checks/po-debconf.desc
@@ -77,6 +77,18 @@ Info: Errors were found in the listed PO file that will cause its content
  to be discarded. Run <tt>msgfmt</tt> on the file to see the error
  messages.
 
+Tag: debconf-translation-using-general-list
+Severity: normal
+Certainty: certain
+Info: This debconf translation is using the general debconf-i18n list as
+ the address in the Language-Team field.
+ .
+ The intended purpose of the Language-Team field is to be an additional
+ contact for new translation requests in addition to the previous
+ translator (as recorded in Last-Translator).  The field should therefore
+ point to a mailing list dedicated to the language of this PO file, not
+ the general list for translation discussions.
+
 Tag: misnamed-po-file
 Severity: normal
 Certainty: possible
diff --git a/debian/changelog b/debian/changelog
index b8a4875..1a68162 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,6 +3,7 @@ lintian (2.5.13) UNRELEASED; urgency=low
   * Summary of tag changes:
     + Added:
       - conffile-is-not-in-package
+      - debconf-translation-using-general-list
 
   * checks/*:
     + [NT] Use Lintian::Path objects as arguments to unpacked
@@ -28,9 +29,12 @@ lintian (2.5.13) UNRELEASED; urgency=low
       to "Vcs-*" fields that the tags are based on a data list
       (and is not a result of a HTTP request while checking the
       package).
-  * checks/po-debconf:
+  * checks/po-debconf{,.desc}:
     + [NT] Remove tests for commands that are provided by
       Lintian's dependencies.
+    + [RA] Add new check for a Language-Team field in a translation
+      pointing to the debian-i18n mailing list.  Based on work by
+      victory.  (Closes: #705197)
 
   * collection/debfiles:
     + [NT] Replace makeshift "is_ancestor_of" check with the
diff --git a/t/COVERAGE b/t/COVERAGE
index f13a80a..e0d373b 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,5 +1,5 @@
-Last generated 2013-01-24
-Coverage (Tags): 909/986 (92.19%), w. legacy tests: 975/986 (98.88%)
+Last generated 2013-04-22
+Coverage (Tags): 926/1003 (92.32%), w. legacy tests: 992/1003 (98.90%)
 Coverage (Checks): 34/42 (80.95%), w. legacy tests: 37/42 (88.10%)
 
 The following tags are not tested by the test suite:
diff --git a/t/tests/debconf-maintscripts-deps/debian/debian/po/da.po b/t/tests/debconf-templates-general/debian/debian/po/en_US.po
similarity index 55%
copy from t/tests/debconf-maintscripts-deps/debian/debian/po/da.po
copy to t/tests/debconf-templates-general/debian/debian/po/en_US.po
index e7cceb3..02ead55 100644
--- a/t/tests/debconf-maintscripts-deps/debian/debian/po/da.po
+++ b/t/tests/debconf-templates-general/debian/debian/po/en_US.po
@@ -1,4 +1,4 @@
-# Danish translations for PACKAGE package.
+# English translations for PACKAGE package.
 # Copyright (C) 2012 THE PACKAGE'S COPYRIGHT HOLDER
 # This file is distributed under the same license as the PACKAGE package.
 # Niels Thykier <niels@thykier.net>, 2012.
@@ -7,18 +7,12 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2012-07-23 23:07+0200\n"
-"PO-Revision-Date: 2012-07-23 23:08+0200\n"
-"Last-Translator: Niels Thykier <niels@thykier.net>\n"
-"Language-Team: Danish\n"
-"Language: da\n"
+"POT-Creation-Date: 2012-10-01 22:54+0200\n"
+"PO-Revision-Date: 2012-10-01 22:54+0200\n"
+"Last-Translator: Russ Allbery <rra@debian.org>\n"
+"Language-Team: English <debian-i18n@lists.debian.org>\n"
+"Language: en_US\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=ASCII\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
-
-#. Type: error
-#. Description
-#: ../templates:1001
-msgid "Useless note"
-msgstr "Ubrugelig note"
diff --git a/t/tests/debconf-templates-general/desc b/t/tests/debconf-templates-general/desc
index 58c4309..a494f79 100644
--- a/t/tests/debconf-templates-general/desc
+++ b/t/tests/debconf-templates-general/desc
@@ -4,6 +4,7 @@ Version: 1.0
 Description: Test for various debconf template issues
 Test-For:
  boolean-template-has-bogus-default
+ debconf-translation-using-general-list
  duplicate-long-description-in-template
  empty-translated-choices
  making-assumptions-about-interfaces-in-templates
diff --git a/t/tests/debconf-templates-general/tags b/t/tests/debconf-templates-general/tags
index 3dfce0b..e81d73f 100644
--- a/t/tests/debconf-templates-general/tags
+++ b/t/tests/debconf-templates-general/tags
@@ -8,6 +8,7 @@ E: debconf-templates-general: no-template-type debconf/no-type
 E: debconf-templates-general: select-without-choices debconf/select-without-choices
 E: debconf-templates-general: unknown-field-in-templates debconf/unknown-field unknown-field
 E: debconf-templates-general: unknown-template-type lintian
+W: debconf-templates-general source: debconf-translation-using-general-list en_US.po
 W: debconf-templates-general source: template-uses-unsplit-choices debconf-templates-general - debconf/unsplit-choices
 W: debconf-templates-general: duplicate-long-description-in-template debconf/duplicate-long-desc
 W: debconf-templates-general: making-assumptions-about-interfaces-in-templates debconf/assumption

-- 
Debian package checker
Reply to: