[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.11-217-g1cd2ff5



The following commit has been merged in the master branch:
commit 1cd2ff58142391d7ba814c21cac443ce021afc60
Author: Niels Thykier <niels@thykier.net>
Date:   Wed Apr 3 22:29:36 2013 +0200

    c/deb-src-dir: Fix leaked file handle
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/debian-source-dir b/checks/debian-source-dir
index 0b91dc3..8e7a91b 100644
--- a/checks/debian-source-dir
+++ b/checks/debian-source-dir
@@ -40,10 +40,11 @@ my (undef, undef, $info) = @_;
 my $dsrc = $info->debfiles('source');
 
 if ( ! -l "$dsrc/format" && -e "$dsrc/format") {
-    open(FORMAT, '<', "$dsrc/format") or
         fail("cannot read debian/source/format: $!");
-    my $format = <FORMAT>;
+    open(my $fd, '<', "$dsrc/format");
+    my $format = <$fd>;
     chomp $format;
+    close $fd;
     tag 'unknown-source-format', $format unless $KNOWN_FORMATS{$format};
 } else {
     tag 'missing-debian-source-format';

-- 
Debian package checker


Reply to: