[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#700110: homepage-for-cpan-package-contains-version: check also for metacpan.org



Package: lintian
Version: 2.5.10.3
Severity: minor
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

homepage-for-cpan-package-contains-version should also check for
metacpan.org URLs in addition to search.cpan.org.

I'm attaching a patch which extends the check and improves the
examples in the description a bit (author-style URLs were never a
good idea; this might even be an additional check :)).

Cheers,
gregor

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJRFWREAAoJELs6aAGGSaoGraoP/jBSCYcFHyHEm4O9/H1yYqNf
JkbmkB1brU+XqpYYBzLb4HKUE2pUALi45aGdo9F7CNp26EgtRrZ/ZEvV0BeIGgcs
ZJkFvxvYJv8a3LpQ1LKhuQUWIxA8hWelLoAa2ENUwp4iJyC6OLwYpupov3yX0zDi
wu4CN0kvgCpGgMlJNEV6MALEiK5R2rWBLM7fxg/y8jsGanVDZr1eMZ6kGoUzur+x
ViT68eSKx1DgYnb/uOp1UALXiqaG+yDE06E12sVJW+x33b3PDOgAbUs/pQgz12yz
SZBnNG8bcP3PgiNZSV2jdsqN+tpMzjcBzrwIbgU8nshNMe1x6pShMiKnyOxRvOAl
wAD76bHg3AKasQjefzaNVJvmaS+Gvh2lB6i6himWEa0mqZNf+qppsoGCy+pMTHFa
mFGHdEJut/UstaHjwzxww3KJDWrxiYBCrOz5EkxyClPPK9/o4bhG9CdQ3ToeM1B9
ho6GUSSseQeLqzLZJnamhBiPKjns82wrYZyhnhd6SlSY+kBHpp40dZ0QE599Y7E0
koEbsprTys1mcI8jXqQTr5Eyr01dP3GhP9vdDZeB9jX5LrlrbUnoFSnkpKxSjtz6
QY0pmdjCYGN6gcb1REdauuHf4Dd8ccI5ad1KOxuG49HGqj6XXDZzRun1ABhaELVR
FHx8xfueGJERhV1e37us
=W1Xx
-----END PGP SIGNATURE-----
diff --git a/checks/fields b/checks/fields
index e702f71..7f4d9da 100644
--- a/checks/fields
+++ b/checks/fields
@@ -548,7 +548,7 @@ if (defined $info->field('homepage')) {
         tag 'bad-homepage', $orig;
     }
 
-    if ($homepage =~ m,/search\.cpan\.org/.*-[0-9._]+/*$,) {
+    if ($homepage =~ m,/(search\.cpan\.org|metacpan\.org)/.*-[0-9._]+/*$,) {
         tag 'homepage-for-cpan-package-contains-version', $orig;
     }
 } elsif ($type eq 'binary' and not $info->native) {
diff --git a/checks/fields.desc b/checks/fields.desc
index 8bc2091..cdce7c1 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -393,7 +393,11 @@ Info: The Homepage field for this package points to CPAN and the URL
  so that the URL doesn't have to be updated for each new release.  For
  example, use:
  .
-   http://search.cpan.org/~samtregar/HTML-Template/
+   http://search.cpan.org/dist/HTML-Template/
+ .
+ or
+ .
+   https://metacpan.org/release/HTML-Template/
  .
  not:
  .

Reply to: