Bug#692282: [new check] debian/tests/control but not (XS-)Testsuite: autopkgtest header in debian/control

[Niels Thykier <niels@thykier.net>]

Control: tags -1 pending

On 2013-01-21 00:46, Nicolas Boulenguez wrote:
> Package: lintian
> Followup-For: Bug #692282
> 
>>> > > if (not ($info->index ('debian/tests')->is_dir and $control->is_regular_file)) {
>> > directories must have a trailing "/" (i.e. 'debian/tests/').
> Not sure to understand what you mean by "must".
> On my machine, "$info->index ('debian/tests')->is_dir" returns true
> when the directory exists, as I expected from the documentation.
> 
> 
> [...]


Caused by a double mistake actually.  First, the documentation was not
clear in this point and secondly, the index code for souce packages did
not add the trailing slash as expected.  Both should be fixed now with
commits:

 * 0e9631839fe574d38826392c59850c0dc58300aa
 * 6dde19562b1283446da55469d0af34ae9658731f
 * 38df05466e28ab6d08ef2e8f822f9bc570844b2e

Anyway, merged your patch as 4fab7f84ba8d17f91f9e79a00a6b6e7272608e99
with some tests to go with it.

In case you are interested in extending the check, possible additional
checks could include checks for "syntax errors"/unparseable control file
(checks/source-copyright has a similar code piece for that).  Check that
all paragraphs have a "Tests" field.  Or even check that all the
restrictions are known.

Thanks for the check,
~Niels