[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.11-80-g7c3035b



The following commit has been merged in the master branch:
commit 7c3035bd440ac115bd6ab60fb171f453f00b315a
Author: Niels Thykier <niels@thykier.net>
Date:   Fri Jan 18 17:57:17 2013 +0100

    c/patch-systems: Retire unneeded-build-dep-on-quilt
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/patch-systems b/checks/patch-systems
index 1a3eb18..0b740fc 100644
--- a/checks/patch-systems
+++ b/checks/patch-systems
@@ -116,9 +116,6 @@ sub run {
     #----- quilt
     if ($build_deps->implies("quilt") or $quilt_format) {
         $uses_patch_system++;
-        if($quilt_format && $build_deps->implies("quilt")){
-            tag "unneeded-build-dep-on-quilt";
-        }
         #check for a debian/patches file:
         if (! -r "$dpdir/series") {
             tag 'quilt-build-dep-but-no-series-file' unless $quilt_format;
diff --git a/checks/patch-systems.desc b/checks/patch-systems.desc
index 63a3162..b3df514 100644
--- a/checks/patch-systems.desc
+++ b/checks/patch-systems.desc
@@ -174,16 +174,3 @@ Info: This package build-depends on a patch system such as dpatch or
  can refer to <tt>/usr/share/doc/dpatch/README.source.gz</tt> for dpatch.
 Ref: policy 4.14
 
-Tag: unneeded-build-dep-on-quilt
-Severity: pedantic
-Certainty: possible
-Info: This package build-depends on quilt, which is not required since
- dpkg-source will apply patches at unpack time for 3.0 (quilt) source
- packages.
- .
- Remember to remove any references to quilt in the rules file (e.g.
- "--with quilt", dh_quilt_* or quilt makefile includes).
- .
- This tag is meant to remind people that with 3.0 (quilt), quilt is
- not necessary.  If you keep the build-depends on quilt to ease
- backporting to older releases, then please ignore/override this tag.
diff --git a/debian/changelog b/debian/changelog
index a34dca1..7449319 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -12,6 +12,8 @@ lintian (2.5.12) UNRELEASED; urgency=low
       - package-contains-broken-symlink-wildcard
       - vcs-field-bitrotted
       - vcs-git-uses-invalid-user-uri
+    + Removed:
+      - unneeded-build-dep-on-quilt
 
   * checks/binaries{,.desc}:
     + [NT] Accept libx32 as a bi-arch directory.
@@ -46,6 +48,10 @@ lintian (2.5.12) UNRELEASED; urgency=low
       "Science" category.  (Closes: #697693)
     + [NT] Apply patch from Thomas Preud'homme to detect uses of
       relative icons in menu files.  (Closes: #697916)
+  * checks/patch-systems{,.desc}:
+    + [NT] Retire unneeded-build-dep-on-quilt, it is only a pedantic
+      tag and apparently not too accurate.  Thanks to Charles Plessy
+      and Frank Kuester for the reports.  (Closes: #615516, #681061)
   * checks/shared-libs:
     + [NT] Special case gcc packages when looking for dev symlinks.
       gcc stores its dev symlinks in some special directories.
diff --git a/t/tests/patch-systems-quilt-source/debian/debian/control.in b/t/tests/patch-systems-quilt-source/debian/debian/control.in
deleted file mode 100644
index c35b565..0000000
--- a/t/tests/patch-systems-quilt-source/debian/debian/control.in
+++ /dev/null
@@ -1,15 +0,0 @@
-Source: {$srcpkg}
-Priority: extra
-Section: {$section}
-Maintainer: {$author}
-Standards-Version: {$standards_version}
-Build-Depends: debhelper (>= 9), quilt
-
-Package: {$srcpkg}
-Architecture: {$architecture}
-Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
-Description: {$description}
- This is a test package designed to exercise some feature or tag of
- Lintian.  It is part of the Lintian test suite and may do very odd
- things.  It should not be installed like a regular package.  It may
- be an empty package.
diff --git a/t/tests/patch-systems-quilt-source/debian/debian/source/format b/t/tests/patch-systems-quilt-source/debian/debian/source/format
deleted file mode 100644
index 163aaf8..0000000
--- a/t/tests/patch-systems-quilt-source/debian/debian/source/format
+++ /dev/null
@@ -1 +0,0 @@
-3.0 (quilt)
diff --git a/t/tests/patch-systems-quilt-source/desc b/t/tests/patch-systems-quilt-source/desc
deleted file mode 100644
index eab4eb7..0000000
--- a/t/tests/patch-systems-quilt-source/desc
+++ /dev/null
@@ -1,8 +0,0 @@
-Testname: patch-systems-quilt-source
-Sequence: 6000
-Type: non-native
-Version: 1.0-1
-Options: --pedantic -I -E
-Description: Test for quilt patches which do not have accompanying descriptions
-Test-For: unneeded-build-dep-on-quilt
-References: Debian Bug #582767
diff --git a/t/tests/patch-systems-quilt-source/tags b/t/tests/patch-systems-quilt-source/tags
deleted file mode 100644
index 9ec166d..0000000
--- a/t/tests/patch-systems-quilt-source/tags
+++ /dev/null
@@ -1,3 +0,0 @@
-P: patch-systems-quilt-source source: unneeded-build-dep-on-quilt
-P: patch-systems-quilt-source: no-homepage-field
-P: patch-systems-quilt-source: no-upstream-changelog
diff --git a/t/tests/patch-systems-quilt-source/upstream/README b/t/tests/patch-systems-quilt-source/upstream/README
deleted file mode 100644
index e845566..0000000
--- a/t/tests/patch-systems-quilt-source/upstream/README
+++ /dev/null
@@ -1 +0,0 @@
-README

-- 
Debian package checker


Reply to: