[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#697916: lintian: Add a check for menu referencing icon by relative path



Another update following suggestions made by KiBi.

Best regards.
diff --git a/checks/menu-format b/checks/menu-format
index a1447b9..90f3160 100644
--- a/checks/menu-format
+++ b/checks/menu-format
@@ -525,6 +525,10 @@ sub VerifyIcon {
         return;
     }
 
+    if (not ($icon =~ m{^/})) {
+        tag 'menu-icon-uses-relative-path', $icon;
+    }
+
     $icon =~ s|^/*||og;
 
     if (not ($icon =~ m/\.xpm$/i)) {
diff --git a/checks/menu-format.desc b/checks/menu-format.desc
index 495cfec..2f01076 100644
--- a/checks/menu-format.desc
+++ b/checks/menu-format.desc
@@ -130,6 +130,13 @@ Certainty: certain
 Info: Icons in the Debian menu system should be in XPM format.
 Ref: menu 3.7
 
+Tag: menu-icon-uses-relative-path
+Severity: normal
+Certainty: certain
+Info: This package contains a menu file which references an icon by a relative
+ path. However, icons should be referenced by an absolute path in menu files.
+Ref: menu 3.2
+
 Tag: menu-icon-missing
 Severity: normal
 Certainty: possible

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: