[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.10-246-gdc6c4d7



The following commit has been merged in the master branch:
commit dc6c4d7082eb431220b72b878cba6607b96b6b23
Author: Niels Thykier <niels@thykier.net>
Date:   Mon Nov 19 22:19:45 2012 +0100

    c/scripts: Fix F-P caused by rm of /dev/shm
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/scripts b/checks/scripts
index 983d8b5..39f0d66 100644
--- a/checks/scripts
+++ b/checks/scripts
@@ -719,8 +719,13 @@ while (<SCRIPTS>) {
                 if (m/^\s*read(?:\s|\z)/ && !$saw_debconf) {
                     tag 'read-in-maintainer-script', "$file:$.";
                 }
-                if (m,^\s*rm\s+([^>]*\s)?/dev/,) {
-                    tag 'maintainer-script-removes-device-files', "$file:$.";
+                if (m,^\s*rm\s+(?:[^>]*\s)?/dev/([^/ ]+),) {
+                    my $f = $1//'';
+                    if ($f ne 'shm' && $f !~ m,^\.[^.]+,) {
+                        # Ignore /dev/shm (initscripts) and dot-files (which are probably
+                        # not a dev).
+                        tag 'maintainer-script-removes-device-files', "$file:$.";
+                    }
                 }
                 if (m,>\s*(/etc/(?:services|protocols|rpc))(\s|\Z),) {
                     tag 'maintainer-script-modifies-netbase-managed-file', "$file:$. $1";
diff --git a/debian/changelog b/debian/changelog
index 80fdc68..7e2aef2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -122,6 +122,9 @@ lintian (2.5.11) UNRELEASED; urgency=low
       the file is an executable hardlink to a script.
     + [NT] Check maintainer scripts for unexpanded #DEBHELPER# tokens.
       Thanks to Cyril "KiBi" Brulebois for the suggestion.
+    + [NT] Fix false-positive for removal of device files as /dev/shm
+      is not a device.  Thanks to Steve Langasek for the report and
+      Roger Leigh for the extra info.  (Closes: #693442)
   * checks/shared-libs{,.desc}:
     + [NT] Clearify the description of dev-pkg-without-shlib-symlink
       to mention that the dev symlink is always expected in /usr.

-- 
Debian package checker


Reply to: