[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.10-166-gc6c5b6a



The following commit has been merged in the master branch:
commit c6c5b6ae8c9bcccfd005341a59b1e028a7592b02
Author: Niels Thykier <niels@thykier.net>
Date:   Mon Sep 24 22:22:32 2012 +0200

    L::Collect: Remove auto-creation of "source" in field
    
    Since 7facd69 the field have not been "auto-created" created.
    
    The auto-creation used to serve as a work around for bugs like
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/lib/Lintian/Collect.pm b/lib/Lintian/Collect.pm
index 7e8c42f..f24ce98 100644
--- a/lib/Lintian/Collect.pm
+++ b/lib/Lintian/Collect.pm
@@ -117,7 +117,6 @@ sub _get_field {
             } else {
                 $fields = (get_deb_info("$base_dir/deb"));
             }
-            $fields->{'source'} = $fields->{'package'} unless $fields->{'source'};
         }
         $self->{field} = $fields;
     } else {
@@ -200,14 +199,6 @@ DEFAULT (if given) or undef.
 Otherwise this will return a hash of fields, where the key is the field
 name (in all lowercase).
 
-Note: For binary and udeb packages, this method will create the
-"source"-field if it does not exist (using the value of the
-"package"-field as described in §5.6.1 of the Debian Policy Manual).
-
-Some checks rely on the presence "source"-field to whitelist some
-packages, so removing this behaviour may cause regressions (see
-bug 640186 for an example).
-
 =item name()
 
 Returns the name of the package.

-- 
Debian package checker


Reply to: