[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, wheezy, updated. 2.5.10.1-4-g6f801f0



The following commit has been merged in the wheezy branch:
commit 6f801f099fd182eda2a952b83423cf5ab9ee7982
Author: Niels Thykier <niels@thykier.net>
Date:   Thu Aug 9 09:52:53 2012 +0200

    L::Profile, c/po-debconf: close dirhandles (properly)
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/po-debconf b/checks/po-debconf
index 5b6f52f..a21deac 100644
--- a/checks/po-debconf
+++ b/checks/po-debconf
@@ -162,6 +162,7 @@ while (defined(my $file=readdir(DEBIAN))) {
         $full_translation = 1;
     }
 }
+closedir DEBIAN;
 
 tag 'no-complete-debconf-translation' if !$full_translation;
 
diff --git a/debian/changelog b/debian/changelog
index b05fa9e..e56b02e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,7 @@
 lintian (2.5.10.2) UNRELEASED; urgency=low
 
+  * checks/po-debconf:
+    + [NT] Fix dirhandle leak.
   * checks/source-copyright{,.desc}:
     + [NT] Report the correct line number for the use of commas in
       the "Files" field in DEP-5 copyright files.  Thanks to Faheem
@@ -12,6 +14,10 @@ lintian (2.5.10.2) UNRELEASED; urgency=low
     + [NT] Fix typo of identifier method, which causes Lintian to
       crash in case a "coll" cannot be started or it fails.
 
+  * lib/Lintian/Profile.pm:
+    + [NT] Use "closedir" rather than "close" to close a dir
+      handle.
+
  -- Niels Thykier <niels@thykier.net>  Thu, 06 Sep 2012 09:55:09 +0200
 
 lintian (2.5.10.1) unstable; urgency=low
diff --git a/lib/Lintian/Profile.pm b/lib/Lintian/Profile.pm
index 817b000..5ca7348 100644
--- a/lib/Lintian/Profile.pm
+++ b/lib/Lintian/Profile.pm
@@ -517,7 +517,7 @@ sub _load_checks {
         next unless $desc =~ s/\.desc$//o;
         $self->_load_check($profile, $desc);
     }
-    close $dirfd;
+    closedir $dirfd;
 }
 
 =back

-- 
Debian package checker


Reply to: