[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.10-122-g4925fc6



The following commit has been merged in the master branch:
commit 4925fc69f35fe2297e4c04fba7ed52eb7fa4600b
Author: Niels Thykier <niels@thykier.net>
Date:   Mon Sep 3 09:26:05 2012 +0200

    c/chg: Emit "missing changelog" if missing u/s/d/$pkg
    
    Emit the relevant "missing changelog" tag if a package is missing
    its usr/share/doc/<pkg> dir (and it doesn't have a doc symlink).
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/changelog-file b/checks/changelog-file
index a2d088e..4c087d8 100644
--- a/checks/changelog-file
+++ b/checks/changelog-file
@@ -115,12 +115,6 @@ foreach ($info->sorted_index) {
     }
 }
 
-# ignore packages which don't have a /usr/share/doc/$pkg directory, since
-# the copyright check will complain about this
-if ($#doc_files < 0) {
-    return 0;
-}
-
 # Check a NEWS.Debian file if we have one.  Save the parsed version of the
 # flie for later checks against the changelog file.
 my $news;
diff --git a/debian/changelog b/debian/changelog
index 2547f56..fa04d77 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -20,6 +20,10 @@ lintian (2.5.11) UNRELEASED; urgency=low
       as Lintian uses readelf.
     + [JW,NT] Update the "extract SONAME" shell snippet to properly
       handle SONAMEs with uppercase letters.
+  * checks/changelog-file:
+    + [NT] Emit "missing changelog" for packages that are missing
+      their usr/share/doc/<pkg>/ dir and do not have a doc symlink.
+      Thanks to Faheem Mitha for the report.  (Closes: #683224)
   * checks/conffiles:
     + [NT] Remove leading slash on the filename when emitting
       file-in-etc-rc.d-marked-as-conffile.
diff --git a/t/tests/generic-empty/tags b/t/tests/generic-empty/tags
index 9ddcba6..db571e7 100644
--- a/t/tests/generic-empty/tags
+++ b/t/tests/generic-empty/tags
@@ -5,6 +5,7 @@ E: generic-empty source: debian-rules-missing-required-target binary-arch
 E: generic-empty source: debian-rules-missing-required-target binary-indep
 E: generic-empty source: maintainer-address-missing a
 E: generic-empty source: no-standards-version-field
+E: generic-empty: changelog-file-missing-in-native-package
 E: generic-empty: maintainer-address-missing a
 E: generic-empty: no-copyright-file
 E: generic-empty: package-has-no-description
diff --git a/testset/tags.fields b/testset/tags.fields
index 9345e94..9257e46 100644
--- a/testset/tags.fields
+++ b/testset/tags.fields
@@ -1,3 +1,4 @@
+E: another-version: debian-changelog-file-missing
 E: another-version: debian-revision-should-not-be-zero 123.4-0
 E: another-version: new-essential-package
 E: another-version: no-copyright-file
diff --git a/testset/tags.relations b/testset/tags.relations
index ce8e58c..310b676 100644
--- a/testset/tags.relations
+++ b/testset/tags.relations
@@ -19,6 +19,7 @@ E: relations-multiple-libs: package-depends-on-multiple-tcl-versions tcl8.0 tcl8
 E: relations-multiple-libs: package-depends-on-multiple-tk-versions tk8.2 tk8.3
 E: relations-multiple-libs: package-depends-on-multiple-tkx-versions tkx8.2 tkx8.3
 E: relations-multiple-libs: usr-share-doc-symlink-without-dependency relations
+E: relations: changelog-file-missing-in-native-package
 E: relations: conflicts-with-dependency depends foo
 E: relations: conflicts-with-dependency depends relations
 E: relations: depends-on-essential-package-without-using-version depends: coreutils

-- 
Debian package checker


Reply to: