[SCM] Debian package checker branch, master, updated. 2.5.10-111-g4384f00
The following commit has been merged in the master branch:
commit 4384f00718607171b142c6ba6056d6693b8f2278
Author: Niels Thykier <niels@thykier.net>
Date: Thu Aug 9 09:52:53 2012 +0200
L::Profile, c/po-debconf: close dirhandles (properly)
Signed-off-by: Niels Thykier <niels@thykier.net>
diff --git a/checks/po-debconf b/checks/po-debconf
index 7172733..e7d2074 100644
--- a/checks/po-debconf
+++ b/checks/po-debconf
@@ -160,6 +160,7 @@ while (defined(my $file=readdir(DEBIAN))) {
$full_translation = 1;
}
}
+closedir DEBIAN;
tag 'no-complete-debconf-translation' if !$full_translation;
diff --git a/debian/changelog b/debian/changelog
index 1d4f586..85f36f9 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -55,6 +55,8 @@ lintian (2.5.11) UNRELEASED; urgency=low
* checks/md5sums:
+ [NT] Use L::Collect's conffile API instead of accessing the
"conffiles" control file directly.
+ * checks/po-debconf:
+ + [NT] Fix dirhandle leak.
* checks/scripts{,.desc}:
+ [NT] Retire check for dpkg-maintscript-helper in preinst.
+ [NT] Fix false positive "executable-not-elf-or-script" when
@@ -123,6 +125,9 @@ lintian (2.5.11) UNRELEASED; urgency=low
* lib/Lintian/Path.pm:
+ [NT] Always resolve hardlinks relative to the package
root.
+ * lib/Lintian/Profile.pm:
+ + [NT] Use "closedir" rather than "close" to close a dir
+ handle.
* lib/Lintian/Tag/Info.pm:
+ [NT] Fix poor error message due to the wrong variable
being unused. Thanks to Christoph Biedl for the report
diff --git a/lib/Lintian/Profile.pm b/lib/Lintian/Profile.pm
index fa45d7e..e128c24 100644
--- a/lib/Lintian/Profile.pm
+++ b/lib/Lintian/Profile.pm
@@ -509,7 +509,7 @@ sub _load_checks {
next unless $desc =~ s/\.desc$//o;
$self->_load_check($profile, $desc);
}
- close $dirfd;
+ closedir $dirfd;
}
sub _default_inc_path {
--
Debian package checker
Reply to: