[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.10-106-g4589978



The following commit has been merged in the master branch:
commit 4589978858a1def88af95ab6f74f7ce2006c4408
Author: Niels Thykier <niels@thykier.net>
Date:   Tue Aug 7 11:57:50 2012 +0200

    c/source-copyright: Use correct line number
    
    Use the correct line number for
    comma-separated-files-in-dep5-copyright.
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/source-copyright b/checks/source-copyright
index 07918ab..6804335 100644
--- a/checks/source-copyright
+++ b/checks/source-copyright
@@ -201,7 +201,7 @@ if (@dep5) {
         }
     }
     if ($commas_in_files) {
-        tag 'comma-separated-files-in-dep5-copyright', 'paragraph at line', $lines[$i]
+        tag 'comma-separated-files-in-dep5-copyright', 'paragraph at line', $lines[$commas_in_files]
             unless grep(/,/, $info->sorted_index);
     }
     while ((my $license, $i) = each %required_standalone_licenses) {
diff --git a/debian/changelog b/debian/changelog
index c89ef34..581c29d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -62,6 +62,9 @@ lintian (2.5.11) UNRELEASED; urgency=low
   * checks/source-copyright{,.desc}:
     + [NT] Check for possible misspellings of known field
       names.  (Closes: #678639)
+    + [NT] Report the correct line number for the use of commas in
+      the "Files" field in DEP-5 copyright files.  Thanks to Faheem
+      Mitha for the report.  (Closes: #683946)
   * checks/version-substvars{,.desc}:
     + [JW,NT] Extend version-substvar-for-external-package to
       all relations.  Previously it was only triggered for
diff --git a/t/tests/source-copyright-dep5-general/tags b/t/tests/source-copyright-dep5-general/tags
index 3f1e1a7..9d43682 100644
--- a/t/tests/source-copyright-dep5-general/tags
+++ b/t/tests/source-copyright-dep5-general/tags
@@ -1,5 +1,5 @@
 I: source-copyright-dep5-general source: unused-license-paragraph-in-dep5-copyright expat (paragraph at line 40)
-W: source-copyright-dep5-general source: comma-separated-files-in-dep5-copyright paragraph at line 40
+W: source-copyright-dep5-general source: comma-separated-files-in-dep5-copyright paragraph at line 8
 W: source-copyright-dep5-general source: missing-field-in-dep5-copyright copyright (paragraph at line 15)
 W: source-copyright-dep5-general source: missing-field-in-dep5-copyright license (paragraph at line 12)
 W: source-copyright-dep5-general source: missing-license-paragraph-in-dep5-copyright mit (paragraph at line 18)

-- 
Debian package checker


Reply to: