[SCM] Debian package checker branch, master, updated. 2.5.10-72-g1200adc

["Niels Thykier" <niels@thykier.net>]

The following commit has been merged in the master branch:
commit 1200adc8c59124a06875178b76936f6a4e03eb9b
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Jul 22 17:38:28 2012 +0200

    c/fields: Retire no-source-field - it cannot be emitted
    
    The tag "no-source-field" cannot be emitted by Lintian due to
    dpkg-source/Dpkg::Source::Package, which refuses to extract a source
    package missing (among others) the "Source" field.  This causes
    collection/unpacked to fail and Lintian to skip the check of the
    source package.
    
    The tag cannot even be emitted via "-C fields" as checks/fields needs
    "debfiles" (which depends on "unpacked").
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/fields b/checks/fields
index f542fa3..7a46964 100644
--- a/checks/fields
+++ b/checks/fields
@@ -359,7 +359,11 @@ if (defined $info->field('uploaders') && defined $info->field('maintainer')) {
 #---- Source
 
 if (not defined $info->field('source')) {
-    tag 'no-source-field' if $type eq 'source';
+    # Optional in binary packages, required in source packages, but we
+    # cannot check it as dpkg-source(1) refuses to unpack source packages
+    # without this field (and fields indirectly depends on unpacked).  So
+    # "pass"...
+    1;
 } else {
     my $source = $info->field('source');
 
diff --git a/checks/fields.desc b/checks/fields.desc
index 94d1fde..4e62599 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -258,12 +258,6 @@ Info: The Maintainer address for this package is a mailing list and there
  maintainers in the Uploaders field.
 Ref: policy 3.3, devref 5.12
 
-Tag: no-source-field
-Severity: serious
-Certainty: certain
-Info: The package does not have a "Source:" field in its control file.
-Ref: policy 5.2
-
 Tag: source-field-does-not-match-pkg-name
 Severity: serious
 Certainty: certain
diff --git a/debian/changelog b/debian/changelog
index 527f085..6eea18c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,7 @@ lintian (2.5.11) UNRELEASED; urgency=low
     + Removed:
       - apparently-truncated-elf-binary
       - data.tar.xz-member-without-dpkg-pre-depends
+      - no-source-field
       - preinst-uses-dpkg-maintscript-helper-without-predepends
 
   * checks/*:
@@ -20,10 +21,13 @@ lintian (2.5.11) UNRELEASED; urgency=low
     + [NT] Detect MS-DOS executables as windows binaries.
   * checks/deb-format{,.desc}:
     + [NT] Retire data.tar.xz tag.  (Closes: #680391)
-  * checks/fields.desc:
+  * checks/fields{,.desc}:
     + [NT] Mention that cme can automate fixing some perl
       related tags.  Thanks to gregor herrmann for the report
       and patch.  (Closes: #680446)
+    + [NT] Retire no-source-field since Lintian cannot emit it any
+      more due to dpkg-source refusing to extract such source
+      packages.
   * checks/infofiles:
     + [NT] Use L::Util's gzip decompressor rather than zcat.
   * checks/manpages{,.desc}:
diff --git a/t/COVERAGE b/t/COVERAGE
index 1c0b118..a5021b0 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,5 +1,5 @@
 Last generated 2012-07-22
-Coverage: 835/963 (86.71%), w. legacy tests: 933/963 (96.88%)
+Coverage: 835/962 (86.80%), w. legacy tests: 933/962 (96.99%)
 
 The following tags are not tested by the test suite:
 
@@ -19,7 +19,6 @@ debconf unknown-template-type
 
 fields bad-menu-item
 fields malformed-python-version
-fields no-source-field
 
 files debug-package-should-be-named-dbg
 files udeb-contains-documentation-file

-- 
Debian package checker