Bug#664061: lintian: check for duplicate fields in control files

[Niels Thykier <niels@thykier.net>]

On 2012-03-15 12:37, Jakub Wilk wrote:
> Package: lintian
> Version: 2.5.6
> Severity: wishlist
> 
> Please see the attached patch.
> 
> Note that the patch breaks the control-file-duplicate-field test. I'm
> not sure what to with it: the test used to emit
> debian-control-with-duplicate-fields, now it also emits
> syntax-error-in-control-file. Perhaps the former tag could be removed:
> it isn't currently triggered by any package in the archive.
> 

Hi,

(As mentioned on IRC,) If we do accept this patch, I would personally
vote for dropping debian-control-with-duplicate-fields as it would
effectively become a part of syntax-error-in-control-file.

It does come with a behavioural change (two actualy).
  1 debian-control-with-duplicate-fields does not abort further checks
    of d/control, unlike syntax-error-in-control-file.
  2 Lintian would (most likely) refuse to check any processable where
    the control file (in control.tar.gz), dsc or changes contain
    duplicate fields.

For both points I am not really concerned.  On the plus side it also
means we get more strict checking of other dctrl "for free".

If no one objects, I will merge this patch during the weekend and at the
same time drop debian-control-with-duplicate-fields.

~Niels