[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.5-19-g4a5e39d



The following commit has been merged in the master branch:
commit 4a5e39d7cacd9c185a4cde79937f4e823bbfc3e5
Author: Felix Geyer <debfx-pkg@fobos.de>
Date:   Sun Mar 11 12:32:39 2012 +0100

    False positive: executable-debhelper-file-without-being-executable
    
    Lintian emits the executable-debhelper-file-without-being-executable
    tag for directories.  For example sdl-image1.2 has a directory called
    debian/examples.
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/debhelper b/checks/debhelper
index 44b8118..495fbf0 100644
--- a/checks/debhelper
+++ b/checks/debhelper
@@ -344,7 +344,7 @@ foreach my $file (sort readdir(DEBIAN)) {
                 # debhelper only use executable files in compat 9
                 _tag_if_executable ($file, "$droot/$file");
             } else {
-                if (-x "$droot/$file") {
+                if (-f "$droot/$file" && -x "$droot/$file") {
                     my $cmd =  _shebang_cmd  ("debian/$file", "$droot/$file");
                     unless ( $cmd ) {
                         tag 'executable-debhelper-file-without-being-executable', "debian/$file";
diff --git a/debian/changelog b/debian/changelog
index 73ceeb7..c5cffdb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -10,6 +10,10 @@ lintian (2.5.6) UNRELEASED; urgency=low
     + [NT] Added missing "unless" in the code.  Fixes false
       positive "source-contains-waf-binary".  Thanks to
       Dmitrijs Ledkovs for the report.  (Closes: #661561)
+  * checks/debhelper:
+    + [NT] Fix FP executable-debhelper-file-without-being-executable
+      emitted for directories.  Thanks to Felix Geyer for the report
+      and the patch.  (Closes: #663447)
   * checks/scripts:
     + [NT] Allow fontforge-nox as (alternative) provider for the
       fontforge interpreter.  Thanks to Martin Erik Werner for

-- 
Debian package checker


Reply to: