[SCM] Debian package checker branch, master, updated. 2.5.2-75-g2b1b28e
The following commit has been merged in the master branch:
commit 2b1b28e223d5f137eb2936b04dc7f702c58d3233
Author: Luk Claes <luk@debian.org>
Date: Sat Jul 2 19:20:06 2011 +0200
packaging-dev should not be (build) depended on or even be recommended
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Niels Thykier <niels@thykier.net>
diff --git a/checks/fields b/checks/fields
index bf043a6..4848647 100644
--- a/checks/fields
+++ b/checks/fields
@@ -629,6 +629,9 @@ if (($type eq 'binary') || ($type eq 'udeb')) {
tag 'package-depends-on-an-x-font-package', "$field: $part_d_orig"
if ($field =~ /^(pre-)?depends$/ && $d_pkg =~ /^xfont.*/ && $d_pkg ne 'xfonts-utils' && $d_pkg ne 'xfonts-encodings');
+ tag 'depends-on-packaging-dev', $field
+ if (($field =~ /^(?:pre-)?depends$/ || $field eq 'recommends') && $d_pkg eq 'packaging-dev');
+
tag 'needlessly-depends-on-awk', $field
if ($d_pkg eq 'awk' && ! $d_version->[0] && &$is_dep_field($field) && $pkg ne 'base-files');
@@ -776,6 +779,10 @@ if ($type eq 'source') {
tag 'conflicting-negation-in-source-relation', "$field: $part_d_orig"
unless (not $d_arch or $d_arch->[1] == 0 or $d_arch->[1] eq @{ $d_arch->[0] });
+
+ tag 'depends-on-packaging-dev', $field
+ if ($d_pkg eq 'packaging-dev');
+
tag 'build-depends-on-build-essential', $field
if ($d_pkg eq 'build-essential');
diff --git a/checks/fields.desc b/checks/fields.desc
index ad3a0ae..d231659 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -863,6 +863,12 @@ Severity: important
Certainty: certain
Ref: policy 7.7
+Tag: depends-on-packaging-dev
+Info: You depend/recommend/build-depend on packaging-dev, which is
+ only a metapackage to install common packages needed for packaging.
+Severity: normal
+Certainty: certain
+
Tag: malformed-python-version
Severity: important
Certainty: certain
diff --git a/debian/changelog b/debian/changelog
index 031f095..08c37ed 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,7 @@ lintian (2.5.3) UNRELEASED; urgency=low
- comma-separated-files-in-dep5-copyright
- copyright-has-crs
- debian-copyright-is-symlink
+ - depends-on-packaging-dev
- dh_installmanpages-is-obsolete
- missing-field-in-dep5-copyright
- missing-license-paragraph-in-dep5-copyright
@@ -43,11 +44,14 @@ lintian (2.5.3) UNRELEASED; urgency=low
all empty files from the check. The bug (#632789) only requests
an exception for "empty __init__.py" files and generally empty
files are unlikely to cause a serious size-waste.
- * checks/fields.desc:
+ * checks/fields{,.desc}:
+ [NT] Mention that perl modules included in perl itself should
be the first dependency if it is only included in the perl
from experimental. Thanks to Dominic Hargreaves for the
report and the patch. (Closes: #637793)
+ + [NT] Warn about (build)depending/recommending on packaging-dev.
+ Thanks to Luk Claes for the report and the initial patch.
+ (Closes: #629308)
* checks/{filenames,rules}.desc:
+ [NT] Improved the descriptions of some tags. (Closes: #639018)
* checks/files:
diff --git a/t/COVERAGE b/t/COVERAGE
index fb0cec5..a1c8ca9 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,5 +1,5 @@
-Last generated 2011-08-22
-Coverage: 712/930 (76.56%), w. legacy tests: 835/930 (89.78%)
+Last generated 2011-08-31
+Coverage: 715/933 (76.63%), w. legacy tests: 838/933 (89.82%)
The following tags are not tested by the test suite:
diff --git a/t/tests/fields-build-depends-general/debian/debian/control.in b/t/tests/fields-build-depends-general/debian/debian/control.in
index 5fe04ff..c302eae 100644
--- a/t/tests/fields-build-depends-general/debian/debian/control.in
+++ b/t/tests/fields-build-depends-general/debian/debian/control.in
@@ -7,7 +7,8 @@ Build-Depends: debhelper (>= 7.0.50~), bd-conflict, revision-1 (>= 1.0-1),
bash, make, x-dev, build-essential, new-package | xlibmesa-gl-dev,
xorg-dev, java-propose-classpath, python3.2-dev, foo [all],
bar [i386 any], baz [source i3!86], baz [i386 !amd64],
- other-pkg [kfreebsd-any], yet-another [any-powerpc]
+ other-pkg [kfreebsd-any], yet-another [any-powerpc],
+ packaging-dev
Build-Conflicts: bd-conflict
Package: {$srcpkg}
diff --git a/t/tests/fields-build-depends-general/desc b/t/tests/fields-build-depends-general/desc
index 1bb26b7..df21b30 100644
--- a/t/tests/fields-build-depends-general/desc
+++ b/t/tests/fields-build-depends-general/desc
@@ -13,6 +13,7 @@ Test-For:
build-depends-on-python-dev-with-no-arch-any
conflicting-negation-in-source-relation
depends-on-build-essential-package-without-using-version
+ depends-on-packaging-dev
invalid-arch-string-in-source-relation
ored-build-depends-on-obsolete-package
References: Debian Bug#540594, Debian Bug#551793
diff --git a/t/tests/fields-build-depends-general/tags b/t/tests/fields-build-depends-general/tags
index d0ff234..046a2a1 100644
--- a/t/tests/fields-build-depends-general/tags
+++ b/t/tests/fields-build-depends-general/tags
@@ -12,3 +12,4 @@ E: fields-build-depends-general source: invalid-arch-string-in-source-relation s
I: fields-build-depends-general source: ored-build-depends-on-obsolete-package build-depends: xlibmesa-gl-dev
W: fields-build-depends-general source: build-depends-on-1-revision build-depends: revision-1 (>= 1.0-1)
W: fields-build-depends-general source: build-depends-on-python-dev-with-no-arch-any
+W: fields-build-depends-general source: depends-on-packaging-dev build-depends
diff --git a/t/tests/fields-depends-general/debian/debian/control.in b/t/tests/fields-depends-general/debian/debian/control.in
index 57ebf72..8f137b2 100644
--- a/t/tests/fields-depends-general/debian/debian/control.in
+++ b/t/tests/fields-depends-general/debian/debian/control.in
@@ -9,7 +9,8 @@ Package: {$srcpkg}
Architecture: {$architecture}
Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, xorg, bash,
conflict-dep, gawk | awk, new-package | xbase-clients, {$srcpkg},
- gaim, emacs21, emacs22, makedev, libfile-temp-perl (>= 0.18)
+ gaim, emacs21, emacs22, makedev, libfile-temp-perl (>= 0.18),
+ packaging-dev
Breaks: package-without-version, {$srcpkg} (<< 0.1),
replaced-wo-version
Replaces: replaced-wo-version
diff --git a/t/tests/fields-depends-general/desc b/t/tests/fields-depends-general/desc
index eba4620..289d6a1 100644
--- a/t/tests/fields-depends-general/desc
+++ b/t/tests/fields-depends-general/desc
@@ -12,6 +12,7 @@ Test-For:
depends-on-metapackage
depends-on-obsolete-package
depends-on-old-emacs
+ depends-on-packaging-dev
depends-on-python-minimal
lib-recommends-documentation
needlessly-depends-on-awk
diff --git a/t/tests/fields-depends-general/tags b/t/tests/fields-depends-general/tags
index 2eab237..f3fb604 100644
--- a/t/tests/fields-depends-general/tags
+++ b/t/tests/fields-depends-general/tags
@@ -12,6 +12,7 @@ W: fields-depends-general: breaks-without-version package-without-version
W: fields-depends-general: depends-exclusively-on-makedev depends
W: fields-depends-general: depends-on-old-emacs depends: emacs21
W: fields-depends-general: depends-on-old-emacs depends: emacs22
+W: fields-depends-general: depends-on-packaging-dev depends
W: fields-depends-general: package-relation-with-self breaks: fields-depends-general (<< 0.1)
W: fields-depends-general: versioned-dependency-satisfied-by-perl depends: libfile-temp-perl (>= 0.18)
W: libfields-depends-general: lib-recommends-documentation recommends: debconf-doc
--
Debian package checker
Reply to: