Bug#637259: [checks/binaries] binary-or-shlib-defines-rpath for /usr/lib/$(DEB_HOST_MULTIARCH)

[Jakub Wilk <jwilk@debian.org>]

Package: lintian
Version: 2.5.1
Severity: wishlist
Tags: patch

lintian issues a warning if rpath is set to /usr/lib, but not if it's 
set to /usr/lib/$(DEB_HOST_MULTIARCH). The attached is a conservative 
patch to fix this problem.

An alternative approach would be to warn if rpath is set to any 
directory of the standard ldconfig search path. There's already some 
code to tell if a directory is such one in checks/shared-libs, so it'd 
have to be factored out.

--
Jakub Wilk

diff --git a/checks/binaries b/checks/binaries
--- a/checks/binaries
+++ b/checks/binaries
@@ -315,7 +315,7 @@
 	foreach my $rpath (map {File::Spec->canonpath($_)} keys %{$objdump->{RPATH}}) {
 	    next if $rpath =~ m,^/usr/lib/(?:games/)?\Q$pkg\E(?:/|\z),;
 	    next if $rpath =~ m,^\$\{?ORIGIN\}?,;
-	    next if $directories{$rpath} and $rpath !~ m,^(?:/usr)?/lib/?\z,;
+	    next if $directories{$rpath} and $rpath !~ m,^(?:/usr)?/lib(?:/$madir)?/?\z,;
 	    tag 'binary-or-shlib-defines-rpath', "$file $rpath";
 	}
     }