Bug#626587: lintian: negated arch-specific overrides don't work

[Andreas Beckmann <debian@abeckmann.de>]

Package: lintian
Version: 2.5.0
Severity: normal
Tags: patch

Hi,

thanks for implementing arch-specific overrides. Due to a small logic
error, the negated ones do not work. This patch for Tags.pm fixes that
behaviour:

                 # missing wildcard checks and sanity checking archs $arch
                 if ($negated) {
-                    $found = 1 if !$found;
-                } else {
-                    $found = 0 if $found;
+                    $found = $found ? 0 : 1;
                 }


Andreas

-- System Information:
Debian Release: 6.0.1
  APT prefers stable
  APT policy: (800, 'stable'), (700, 'testing'), (600, 'unstable'), (500, 'stable-updates'), (130, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils               2.21.0.20110327-3 The GNU assembler, linker and bina
ii  diffstat               1.54-1            produces graph of changes introduc
ii  dpkg-dev               1.16.0.3          Debian package development tools
ii  file                   5.04-5            Determines file type using "magic"
ii  gettext                0.18.1.1-3        GNU Internationalization utilities
ii  intltool-debian        0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-perl        0.1.24+b1         Perl interface to libapt-pkg
ii  libclass-accessor-perl 0.34-1            Perl module that automatically gen
ii  libdigest-sha-perl     5.48-1            Perl extension for SHA-1/224/256/3
ii  libemail-valid-perl    0.184-1           Perl module for checking the valid
ii  libipc-run-perl        0.89-1            Perl module for running processes
ii  libparse-debianchangel 1.1.1-2.1         parse Debian changelogs and output
ii  libtimedate-perl       1.2000-1          collection of modules to manipulat
ii  liburi-perl            1.54-2            module to manipulate and access UR
ii  locales                2.11.2-10         Embedded GNU C Library: National L
ii  man-db                 2.5.7-8           on-line manual pager
ii  perl [libdigest-sha-pe 5.10.1-20         Larry Wall's Practical Extraction 
ii  unzip                  6.0-4             De-archiver for .zip files

lintian recommends no packages.

Versions of packages lintian suggests:
ii  binutils-multiarch     2.21.0.20110327-3 Binary utilities that support mult
ii  libhtml-parser-perl    3.66-1            collection of modules that parse H
ii  libtext-template-perl  1.45-2            Text::Template perl module
ii  man-db                 2.5.7-8           on-line manual pager

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/lintian/lib/Lintian/Tags.pm (from lintian package)