[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#626256: debian/source.lintian-overrides not recognized



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2011-05-10 15:12, Casper Gielen wrote:
> Op 10-05-11 12:39, Niels Thykier schreef:
>> On 2011-05-10 11:55, Casper Gielen wrote:
>>
>>> The lintian manual appears to be off. Sectoin 2.4 on Overrides states:
>>
>>> "If the override is for a source package, you have to place it at
>>> debian/source/lintian-overrides or debian/source.lintian-overrides (the
>>> former path is preferred)."
>>
>>
>> Actually it is correct, since...
>>
>>> Unfortunately the overrides are not used when the file is named
>>> 'debian/source.lintian-overrides' . It is recognized when it is named
>>> 'debian/lintian-overrides'.
>>
>>
>> debian/lintian-overrides is not debian/source/lintian-overrides, but the
>> short form of debian/<firstpkg>.lintian-overrides.  
> 
> Hello,
> thanks for taking the time to help me. As far as I can tell this is not
> documented anywhere in the lintian manual.
> 

That is because debian/[<firstpackage>.]lintian-overrides is handled by
dh_lintian, which is a part of debhelper.  So you would need to read the
debhelper manual to find it.  Note that this is a general thing for
debhelper (and debhelper-like) tools, so you will probably find this in
man 7 debhelper than than man dh_lintian.

>> The tag in question
>> is emitted on a binary package (e.g. a deb file) and thus the override
>> has to be in the binary package.
>>   That being said, I would naturally have assumed this to be a source
>> check based on the tag alone (and the file being processed).
> 
> Thank you for explaining this to me, I think I now understand. I'm new
> to lintian so the distinction between source and binary packages does
> not come natural to me.
> 

You are welcome :)

> One further remark, that same page contains the line "If the override is
> for a binary or udeb package, you have to place it at
> /usr/share/lintian/overrides/<package> inside the package."
> Which lead me to believe that I had to create that file by hand and
> include it in the package. However, apparently this file is
> automatically created by debbuild from 'debian/lintian-overrides'.
> The 'type' field in the lintian-overrides reinforces the idea that all
> overrides should go in this file.
> 

As mentioned above, dh_lintian is likely to be the tool that installs
the overrides for you.  The Lintian manual describes here where you or
(in this case) a helper tool should install the override.  But I will
not rule out that the manual is a bit vague or poorly worded here.

> 
> I think the page says so with the following line, but the language is
> not very clear: "Note that Lintian extracts the override file from the
> (u)deb and stores it in the laboratory." although it was my
> understanding that the laboratory is something entirely else.
> 

The laboratory is the term for Lintian's little workspace where it
analyses the package; the laboratory is "temporary" in daily usage
(created in a temporary directory) and is therefore deleted when lintian
is done.  With the -v option, Lintian will tell you the name (path to)
the temporary laboratory.
  The important part here is that Lintian needs the override to be
present *in* the package - because it will not look for it in the source
package.
  While it could do that, it would not work in all cases (in some
uploads, the source package is not available - e.g. binNMU/buildd builds
etc.).

> I'm obviously new to Lintian so I will no longer claim that the manual
> is 'wrong'. but I do think the language is confusing.
> 

:) I would not be surprised if it was wrong or strongly outdated on some
parts.  Most of it bears a close resemblance to the original text about
Lintian from Jan in 1998[1].
  If you do spot an inconsistency, please feel free to report it (and
you are most welcome to include a patch as well).  It has been a long
standing item on our TODO list to get it up to date.

[1] http://lists.debian.org/debian-devel/1998/01/msg01503.html

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNyT8BAAoJEAVLu599gGRC0S4P/ifKI/nWpjBksTV8JqXTZ/TJ
jP3KK7RepZq0okvVEHa69CP2HvBogNOCOEJ76cJ9xpBSaoz7D6CjTucHo02DtY16
oWITnYAhIC8yBriPpvBQJXpfdzOzZLfS5JHc6tOFy3f7h0wjrP4i7kHDzdf1HSO9
Pldxos9vPd8oYm7bsih5Z1oB4vuNg+yhwzn4arTiScgduJfXzojnA5c04X7vwLYh
Uvci1bVT7iXUBEBDSgwxyfmRALCnDQm/7tjLeR4XQj083zGuhT6oooDpcHZzo8zt
ffsKINwA+Cat9EFviDuAcINpM70Xl43t4MBRGwdlz3yVDpZ7p7FaG/cpKl4P+RNF
48PLYW9r46TwfY0AlLX6gu1GRxy66CthByrr6xZ89BJvFJ/LFZYkaVmYK9BvON4K
7qZC+vvckeCM7wUhiDUvXucvS6diQ4/2E7WAWYV5nP4mlB5e3ydz/8V8jMj73BeX
4lHWx7ugozYdASEU9EWlVuANFqmFCoVDrppDq6eXTJ0EQnmVmq4z3JJ3xTpI0X5o
kZ93pPiLrKUHrHZbZE33Pq2T2fkXHCi23luZQ+W8cIV+OwPGMTXCy28N2a/jnxzy
vbnymNCwKm5J6xqO2v/GhQYvaxU4ZedD+y2Y1VnmeY92kB5jAAu4CdnLZlOQT3qL
noDrGA4ovYRpKZBUfLug
=itMf
-----END PGP SIGNATURE-----



Reply to: