[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.4.3-190-gccd5298



The following commit has been merged in the master branch:
commit d78d6dcef4b0fad0e668dff796ac514bd532da47
Author: Raphael Geissert <atomo64@gmail.com>
Date:   Thu Jan 27 12:21:19 2011 -0600

    Do criticise check scripts
    
    Perl::Critic ignores them by default because they have neither a
    perl shebang nor an extension.

diff --git a/t/scripts/critic.t b/t/scripts/critic.t
index 999f8ce..be2243d 100755
--- a/t/scripts/critic.t
+++ b/t/scripts/critic.t
@@ -16,12 +16,20 @@ diag('libppix-regexp-perl is needed to enable some checks') if $@;
 
 Test::Perl::Critic->import( -profile => "$ENV{LINTIAN_ROOT}/.perlcriticrc" );
 
-all_critic_ok("$ENV{LINTIAN_ROOT}/checks",
-	      "$ENV{LINTIAN_ROOT}/collection",
-	      "$ENV{LINTIAN_ROOT}/frontend",
-	      "$ENV{LINTIAN_ROOT}/lib",
-	      "$ENV{LINTIAN_ROOT}/unpack");
+our @CHECKS = glob ("$ENV{LINTIAN_ROOT}/checks/*[!.]*[!c]");
 
+plan tests => scalar(@CHECKS)+1;
+
+for my $check (@CHECKS) {
+    critic_ok($check);
+}
+
+subtest 'All scripts with correct shebang or extension' => sub {
+    all_critic_ok("$ENV{LINTIAN_ROOT}/collection",
+		  "$ENV{LINTIAN_ROOT}/frontend",
+		  "$ENV{LINTIAN_ROOT}/lib",
+		  "$ENV{LINTIAN_ROOT}/unpack");
+};
 
 sub should_skip($) {
     my $path = shift;

-- 
Debian package checker


Reply to: