[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.4.3-187-gb536ff5



The following commit has been merged in the master branch:
commit b536ff57409c822863690492720e6168d9c25e51
Author: Raphael Geissert <atomo64@gmail.com>
Date:   Thu Jan 27 11:59:36 2011 -0600

    Remove useless interpolation from checks/files

diff --git a/checks/files b/checks/files
index 2435614..a11b565 100644
--- a/checks/files
+++ b/checks/files
@@ -283,11 +283,11 @@ foreach my $file (@{$info->sorted_index}) {
     # ---------------- /etc
     if ($file =~ m,^etc/,) {
 	if ($file =~ m,^etc/nntpserver, ) {
-	    tag 'package-uses-obsolete-file', "$file";
+	    tag 'package-uses-obsolete-file', $file;
 	}
 	# ---------------- /etc/cron.daily, etc.
 	elsif ($file =~ m,^etc/cron\.(?:daily|hourly|monthly|weekly)/[^\.].*\., ) {
-	    tag 'run-parts-cron-filename-contains-full-stop', "$file";
+	    tag 'run-parts-cron-filename-contains-full-stop', $file;
 	}
 	# ---------------- /etc/cron.d
 	elsif ($file =~ m,^etc/cron\.d/\S, and $operm != 0644) {
@@ -300,7 +300,7 @@ foreach my $file (@{$info->sorted_index}) {
 	}
 	# ---------------- /etc/gconf/schemas
 	elsif ($file =~ m,^etc/gconf/schemas/\S,) {
-	    tag 'package-installs-into-etc-gconf-schemas', "$file";
+	    tag 'package-installs-into-etc-gconf-schemas', $file;
 	}
 	# ---------------- /etc/init.d
 	elsif ($file =~ m,^etc/init\.d/\S,
@@ -312,7 +312,7 @@ foreach my $file (@{$info->sorted_index}) {
 	}
 	#----------------- /etc/ld.so.conf.d
 	elsif ($file =~ m,^etc/ld\.so\.conf\.d/.+$, and $pkg !~ /^libc/) {
-	    tag 'package-modifies-ld.so-search-path', "$file";
+	    tag 'package-modifies-ld.so-search-path', $file;
 	}
 	#----------------- /etc/modprobe.d
 	elsif ($file =~ m,^etc/modprobe\.d/(.+)$, and $1 !~ m,\.conf$, and $index_info->{type} !~ m/^d/) {
@@ -335,19 +335,19 @@ foreach my $file (@{$info->sorted_index}) {
 	}
 	# ---------------- /etc/rc.d
 	elsif ($type ne 'udeb' and $file =~ m,^etc/rc\.d/\S, and $pkg !~ /^(?:sysvinit|file-rc)$/) {
-	    tag 'package-installs-into-etc-rc.d', "$file";
+	    tag 'package-installs-into-etc-rc.d', $file;
 	}
 	# ---------------- /etc/rc?.d
 	elsif ($type ne 'udeb' and $file =~ m,^etc/rc(?:\d|S)\.d/\S, and $pkg !~ /^(?:sysvinit|file-rc)$/) {
-	    tag 'package-installs-into-etc-rc.d', "$file";
+	    tag 'package-installs-into-etc-rc.d', $file;
 	}
 	# ---------------- /etc/rc.boot
 	elsif ($file =~ m,^etc/rc\.boot/\S,) {
-	    tag 'package-installs-into-etc-rc.boot', "$file";
+	    tag 'package-installs-into-etc-rc.boot', $file;
 	}
 	# ---------------- /etc/udev/rules.d
 	elsif ($file =~ m,^etc/udev/rules\.d/\S,) {
-	    tag 'udev-rule-in-etc', "$file";
+	    tag 'udev-rule-in-etc', $file;
 	}
     }
     # ---------------- /usr
@@ -355,7 +355,7 @@ foreach my $file (@{$info->sorted_index}) {
 	# ---------------- /usr/share/doc
 	if ($file =~ m,^usr/share/doc/\S,) {
 	    if ($type eq 'udeb') {
-		tag 'udeb-contains-documentation-file', "$file";
+		tag 'udeb-contains-documentation-file', $file;
 	    } else {
 		# file not owned by root?
 		if ($owner ne 'root/root') {
@@ -364,7 +364,7 @@ foreach my $file (@{$info->sorted_index}) {
 
 		# file directly in /usr/share/doc ?
 		if ($index_info->{type} =~ m/^[-h]/ and $file =~ m,^usr/share/doc/[^/]+$,) {
-		    tag 'file-directly-in-usr-share-doc', "$file";
+		    tag 'file-directly-in-usr-share-doc', $file;
 		}
 
 		# executable in /usr/share/doc ?
@@ -372,7 +372,7 @@ foreach my $file (@{$info->sorted_index}) {
 		    $file !~ m,^usr/share/doc/(?:[^/]+/)?examples/, and
 		    ($operm & 01 or $operm & 010 or $operm & 0100)) {
 		    if ($script{$file}) {
-			tag 'script-in-usr-share-doc', "$file";
+			tag 'script-in-usr-share-doc', $file;
 		    } else {
 			tag 'executable-in-usr-share-doc', $file, (sprintf '%04o', $operm);
 		    }
@@ -386,7 +386,7 @@ foreach my $file (@{$info->sorted_index}) {
 		    unless ($file =~ m,^usr/share/doc/(?:[^/]+/)?examples/,
 			    or $file =~ m,^usr/share/doc/(?:.+/)?html/.*\.map$,
 			    or $file =~ m,^usr/share/doc/(?:.+/)?__init__\.py$,) {
-			tag 'zero-byte-file-in-doc-directory', "$file";
+			tag 'zero-byte-file-in-doc-directory', $file;
 		    }
 		}
 		# gzipped zero byte files:
@@ -395,14 +395,14 @@ foreach my $file (@{$info->sorted_index}) {
 		    and $index_info->{type} =~ m,^[-h],
 		    and $info->file_info->{$file} =~ m/gzip compressed/) {
 		    unless (`gzip -dc unpacked/$file`) {
-			tag 'zero-byte-file-in-doc-directory', "$file";
+			tag 'zero-byte-file-in-doc-directory', $file;
 		    }
 		}
 
 		# contains an INSTALL file?
 		my $tmp = quotemeta($pkg);
 		if ($file =~ m,^usr/share/doc/$tmp/INSTALL(?:\..+)*$,) {
-		    tag 'package-contains-upstream-install-documentation', "$file";
+		    tag 'package-contains-upstream-install-documentation', $file;
 		}
 
 		# contains a README for another distribution/platform?
@@ -410,13 +410,13 @@ foreach my $file (@{$info->sorted_index}) {
 		                cygwin|darwin|irix|gentoo|freebsd|mac|macos|macosx|netbsd|
 				openbsd|osf|redhat|sco|sgi|solaris|suse|sun|vms|win32|win9x|
 				windows)(?:\.txt)?(?:\.gz)?$,xi){
-		    tag 'package-contains-readme-for-other-platform-or-distro', "$file";
+		    tag 'package-contains-readme-for-other-platform-or-distro', $file;
 		}
 
 		# contains a compressed version of objects.inv in sphinx-generated documentation?
 		if ($file =~ m,^usr/share/doc/$tmp/(?:[^/]+/)+objects\.inv\.gz$,
 		    and $info->file_info->{$file} =~ m/gzip compressed/) {
-		    tag 'compressed-objects.inv', "$file";
+		    tag 'compressed-objects.inv', $file;
 		}
 
 	    }
@@ -424,30 +424,30 @@ foreach my $file (@{$info->sorted_index}) {
 	# ---------------- /usr/doc
 	elsif ($file =~ m,^usr/doc/\S,) {
 	    if ($file =~ m,^usr/doc/examples/\S+, and $index_info->{type} eq 'd') {
-		tag 'old-style-example-dir', "$file";
+		tag 'old-style-example-dir', $file;
 	    }
 	}
 	# ---------------- /usr/X11R6/lib/X11/app-defaults
 	elsif ($file =~ m,usr/X11R6/lib/X11/app-defaults,) {
-	    tag 'old-app-defaults-directory', "$file";
+	    tag 'old-app-defaults-directory', $file;
 	}
 
 	#----------------- /usr/X11R6/
 	elsif ($file =~ m,^usr/X11R6/bin, && $pkg ne 'x11-common') {
-	    tag 'package-installs-file-to-usr-x11r6-bin', "$file";
+	    tag 'package-installs-file-to-usr-x11r6-bin', $file;
 	}
 	elsif ($file =~ m,^usr/X11R6/lib/X11/fonts,) {
-	    tag 'package-installs-font-to-usr-x11r6', "$file";
+	    tag 'package-installs-font-to-usr-x11r6', $file;
 	}
 	elsif ($file =~ m,^usr/X11R6/, and
 	       $index_info->{type} !~ m,^l,) { #links to FHS locations are allowed
-	    tag 'package-installs-file-to-usr-x11r6', "$file";
+	    tag 'package-installs-file-to-usr-x11r6', $file;
 	}
 
 	# ---------------- /usr/lib/debug
 	elsif ($file =~ m,^usr/lib/debug/\S,) {
 	    unless ($warned_debug_name) {
-		tag 'debug-package-should-be-named-dbg', "$file"
+		tag 'debug-package-should-be-named-dbg', $file
 		    unless ($pkg =~ /-dbg$/);
 		$warned_debug_name = 1;
 	    }
@@ -455,7 +455,7 @@ foreach my $file (@{$info->sorted_index}) {
 	    if ($index_info->{type} =~ m/^[-h]/o &&
 		$file =~ m,^usr/lib/debug/usr/lib/pyshared/(python\d?(?:\.\d+))/(.++)$,o){
 		my $correct = "/usr/lib/debug/usr/lib/pymodules/$1/$2";
-		tag 'python-debug-in-wrong-location', "$file", "$correct";
+		tag 'python-debug-in-wrong-location', $file, $correct;
 	    }
 	}
 
@@ -465,11 +465,11 @@ foreach my $file (@{$info->sorted_index}) {
 	}
 	# ---------------- perllocal.pod
 	elsif ($file =~ m,^usr/lib/perl.*/perllocal.pod$,) {
-	    tag 'package-installs-perllocal-pod', "$file";
+	    tag 'package-installs-perllocal-pod', $file;
 	}
 	# ---------------- .packlist files
 	elsif ($file =~ m,^usr/lib/perl.*/.packlist$,) {
-	    tag 'package-installs-packlist', "$file";
+	    tag 'package-installs-packlist', $file;
 	}
 	elsif ($file =~ m,^usr/lib/perl5/.*\.(?:pl|pm)$,) {
 	    push @nonbinary_perl_files_in_lib, $file;
@@ -480,15 +480,15 @@ foreach my $file (@{$info->sorted_index}) {
 	# ---------------- /usr/lib -- needs to go after the other usr/lib/*
 	elsif ($file =~ m,^usr/lib/,) {
 	    if ($type ne 'udeb' and $file =~ m,\.(?:bmp|gif|jpeg|jpg|png|tiff|xpm|xbm)$, and not defined $link) {
-		tag 'image-file-in-usr-lib', "$file"
+		tag 'image-file-in-usr-lib', $file
 	    }
 	}
 	# ---------------- /usr/local
 	elsif ($file =~ m,^usr/local/\S+,) {
 	    if ($index_info->{type} =~ m/^d/) {
-		tag 'dir-in-usr-local', "$file";
+		tag 'dir-in-usr-local', $file;
 	    } else {
-		tag 'file-in-usr-local', "$file";
+		tag 'file-in-usr-local', $file;
 	    }
 	}
 	# ---------------- /usr/share/applications
@@ -498,14 +498,14 @@ foreach my $file (@{$info->sorted_index}) {
 	# ---------------- /usr/share/man and /usr/X11R6/man
 	elsif ($file =~ m,^usr/X11R6/man/\S+, or $file =~ m,^usr/share/man/\S+,) {
 	    if ($type eq 'udeb') {
-		tag 'documentation-file', "$file";
+		tag 'documentation-file', $file;
 	    }
 	    if ($index_info->{type} =~ m/^d/) {
-		tag 'stray-directory-in-manpage-directory', "$file"
+		tag 'stray-directory-in-manpage-directory', $file
 		    if ($file !~ m,^usr/(?:X11R6|share)/man/(?:[^/]+/)?(?:man\d/)?$,);
 	    } elsif ($index_info->{type} =~ m,^[-h], and
 		($operm & 01 or $operm & 010 or $operm & 0100)) {
-		tag 'executable-manpage', "$file";
+		tag 'executable-manpage', $file;
 	    }
 	}
 	# ---------------- /usr/share/fonts/X11
@@ -523,7 +523,7 @@ foreach my $file (@{$info->sorted_index}) {
 	# ---------------- /usr/share/info
 	elsif ($file =~ m,^usr/share/info\S+,) {
 	    if ($type eq 'udeb') {
-		tag 'documentation-file', "$file";
+		tag 'documentation-file', $file;
 	    }
 	    if ($file =~ m,^usr/share/info/dir(?:\.old)?(?:\.gz)?$,) {
 		tag 'package-contains-info-dir-file', $file;
@@ -540,19 +540,19 @@ foreach my $file (@{$info->sorted_index}) {
 	# ---------------- /usr/share
 	elsif ($file =~ m,^usr/share/[^/]+$,) {
 	    if ($index_info->{type} =~ m/^[-h]/) {
-		tag 'file-directly-in-usr-share', "$file";
+		tag 'file-directly-in-usr-share', $file;
 	    }
 	}
         # ---------------- /usr/bin
 	elsif ($file =~ m,^usr/bin/,) {
 	    if ($index_info->{type} =~ m/^d/ and $file =~ m,^usr/bin/., and $file !~ m,^usr/bin/(?:X11|mh)/,) {
-		tag 'subdir-in-usr-bin', "$file";
+		tag 'subdir-in-usr-bin', $file;
 	    }
 	}
 	# ---------------- /usr subdirs
 	elsif ($type ne 'udeb' and $file =~ m,^usr/[^/]+/$,) { # FSSTND dirs
 	    if ( $file =~ m,^usr/(?:dict|doc|etc|info|man|adm|preserve)/,) {
-		tag 'FSSTND-dir-in-usr', "$file";
+		tag 'FSSTND-dir-in-usr', $file;
 	    }
 	    # FHS dirs
 	    elsif ($file !~ m,^usr/(?:X11R6|X386|
@@ -560,9 +560,9 @@ foreach my $file (@{$info->sorted_index}) {
 				    lib|lib32|lib64|
 				    local|sbin|share|
 				    src|spool|tmp)/,x) {
-		tag 'non-standard-dir-in-usr', "$file";
+		tag 'non-standard-dir-in-usr', $file;
 	    } elsif ($file =~ m,^usr/share/doc,) {
-		tag 'uses-FHS-doc-dir', "$file";
+		tag 'uses-FHS-doc-dir', $file;
 	    }
 
 	    # unless $file =~ m,^usr/[^/]+-linuxlibc1/,; was tied into print
@@ -601,7 +601,7 @@ foreach my $file (@{$info->sorted_index}) {
     # ---------------- /var subdirs
     elsif ($type ne 'udeb' and $file =~ m,^var/[^/]+/$,) { # FSSTND dirs
 	if ( $file =~ m,^var/(?:adm|catman|named|nis|preserve)/, ) {
-	    tag 'FSSTND-dir-in-var', "$file";
+	    tag 'FSSTND-dir-in-var', $file;
 	}
 	# base-files is special
 	elsif ($pkg eq 'base-files' && $file =~ m,^var/(?:backups|local)/,) {
@@ -609,18 +609,18 @@ foreach my $file (@{$info->sorted_index}) {
 	}
 	# FHS dirs with exception in Debian policy
 	elsif ( $file !~ m,^var/(?:account|lib|cache|crash|games|lock|log|opt|run|spool|state|tmp|www|yp)/,) {
-	    tag 'non-standard-dir-in-var', "$file";
+	    tag 'non-standard-dir-in-var', $file;
 	}
     }
     elsif ($type ne 'udeb' and $file =~ m,^var/lib/games/.,) {
-	tag 'non-standard-dir-in-var', "$file";
+	tag 'non-standard-dir-in-var', $file;
     }
     # ---------------- /var/lock, /var/run
     elsif ($type ne 'udeb' and $file =~ m,^var/lock/.,) {
-	tag 'dir-or-file-in-var-lock', "$file";
+	tag 'dir-or-file-in-var-lock', $file;
     }
     elsif ($type ne 'udeb' and $file =~ m,^var/run/.,) {
-	tag 'dir-or-file-in-var-run', "$file";
+	tag 'dir-or-file-in-var-run', $file;
     }
     # ---------------- /var/www
     # Packages are allowed to create /var/www since it's historically been the
@@ -631,7 +631,7 @@ foreach my $file (@{$info->sorted_index}) {
     }
     # ---------------- /opt
     elsif ($file =~ m,^opt/.,) {
-	tag 'dir-or-file-in-opt', "$file";
+	tag 'dir-or-file-in-opt', $file;
     }
     elsif ($file =~ m,^hurd/.,) {
 	next;
@@ -640,21 +640,21 @@ foreach my $file (@{$info->sorted_index}) {
     }
     # ---------------- /tmp, /var/tmp, /usr/tmp
     elsif ($file =~ m,^tmp/., or $file =~ m,^(?:var|usr)/tmp/.,) {
-	tag 'dir-or-file-in-tmp', "$file";
+	tag 'dir-or-file-in-tmp', $file;
     }
     # ---------------- /mnt
     elsif ($file =~ m,^mnt/.,) {
-	tag 'dir-or-file-in-mnt', "$file";
+	tag 'dir-or-file-in-mnt', $file;
     }
     # ---------------- /bin
     elsif ($file =~ m,^bin/,) {
 	if ($index_info->{type} =~ m/^d/ and $file =~ m,^bin/.,) {
-	    tag 'subdir-in-bin', "$file";
+	    tag 'subdir-in-bin', $file;
 	}
     }
     # ---------------- /srv
     elsif ($file =~ m,^srv/.,) {
-	tag 'dir-or-file-in-srv', "$file";
+	tag 'dir-or-file-in-srv', $file;
     }
     # ---------------- FHS directory?
     elsif ($file =~ m,^[^/]+/$, and $file ne './' and
@@ -666,7 +666,7 @@ foreach my $file (@{$info->sorted_index}) {
 	#
 	# Also make an exception for /emul, which is used for multiarch
 	# support in Debian at the moment.
-	tag 'non-standard-toplevel-dir', "$file"
+	tag 'non-standard-toplevel-dir', $file
 	    unless $pkg eq 'base-files'
 		or $pkg eq 'hurd'
 		or $pkg eq 'hurd-udeb'
@@ -678,12 +678,12 @@ foreach my $file (@{$info->sorted_index}) {
     if ($file =~ m,^usr/(?:spool|tmp)/, or
 	$file =~ m,^usr/(?:doc|bin)/X11/, or
 	$file =~ m,^var/adm/,) {
-	tag 'use-of-compat-symlink', "$file";
+	tag 'use-of-compat-symlink', $file;
     }
 
     # ---------------- .ali files (Ada Library Information)
     if ($file =~ m,^usr/lib/.*\.ali$, && $operm != 0444) {
-	tag 'bad-permissions-for-ali-file', "$file";
+	tag 'bad-permissions-for-ali-file', $file;
     }
 
     # ---------------- any files
@@ -700,7 +700,7 @@ foreach my $file (@{$info->sorted_index}) {
 		or $file =~ m,^usr/iraf/,
 		# not allowed, but tested indivudually
 		or $file =~ m,^(?:mnt|opt|srv|(?:(?:usr|var)/)?tmp)|var/www/,) {
-	    tag 'file-in-unusual-dir', "$file";
+	    tag 'file-in-unusual-dir', $file;
 	}
     }
 
@@ -716,12 +716,12 @@ foreach my $file (@{$info->sorted_index}) {
 
     # ---------------- .pyc (compiled python files
     if ($file =~ m,^usr/lib/python\d\.\d/.*.pyc$,) {
-	tag 'package-installs-python-pyc', "$file"
+	tag 'package-installs-python-pyc', $file
     }
 
     # ---------------- /usr/lib/site-python
     if ($file =~ m,^usr/lib/site-python/\S,) {
-	tag 'file-in-usr-lib-site-python', "$file";
+	tag 'file-in-usr-lib-site-python', $file;
     }
 
     # ---------------- pythonX.Y extensions
@@ -735,7 +735,7 @@ foreach my $file (@{$info->sorted_index}) {
 		$is_python = 1 if /^python(?:\d\.\d)?(?:$|\s)/;
 	    }
 	}
-	tag 'third-party-package-in-python-dir', "$file"
+	tag 'third-party-package-in-python-dir', $file
 	    unless $is_python;
     }
     # ---------------- perl modules
@@ -748,7 +748,7 @@ foreach my $file (@{$info->sorted_index}) {
                $is_perl = 1 if /^perl(?:$|\s)/;
            }
        }
-       tag 'perl-module-in-core-directory', "$file"
+       tag 'perl-module-in-core-directory', $file
            unless $is_perl;
     }
 
@@ -779,7 +779,7 @@ foreach my $file (@{$info->sorted_index}) {
 	and not $file =~ m,/under\S+License\.docbook$,
 	and not $file =~ m,^usr/share/doc/[^/]+/examples/,
 	and not defined $link) {
-	tag 'extra-license-file', "$file";
+	tag 'extra-license-file', $file;
     }
 
     # ---------------- .devhelp2? files
@@ -793,7 +793,7 @@ foreach my $file (@{$info->sorted_index}) {
 
     # ---------------- weird file names
     if ($file =~ m,\s+\z,) {
-	tag 'file-name-ends-in-whitespace', "$file";
+	tag 'file-name-ends-in-whitespace', $file;
     }
     if ($file =~ m,/\*\z,) {
 	tag 'star-file', $file;
@@ -803,7 +803,7 @@ foreach my $file (@{$info->sorted_index}) {
     my $tmp = quotemeta($pkg);
     if ($file =~ m,^usr/share/doc/$tmp/override\.[lL]intian(?:\.gz)?$, or
 	$file =~ m,^usr/share/lintian/overrides/$tmp/.+,) {
-	tag 'override-file-in-wrong-location', "$file";
+	tag 'override-file-in-wrong-location', $file;
     }
 
     # ---------------- pyshared-data
@@ -859,51 +859,51 @@ foreach my $file (@{$info->sorted_index}) {
     if ($index_info->{type} =~ m/^[-h]/) {
 	# ---------------- backup files and autosave files
 	if ($file =~ /~$/ or $file =~ m,\#[^/]+\#$, or $file =~ m,/\.[^/]+\.swp$,) {
-	    tag 'backup-file-in-package', "$file";
+	    tag 'backup-file-in-package', $file;
 	}
 	if ($file =~ m,/\.nfs[^/]+$,) {
-	    tag 'nfs-temporary-file-in-package', "$file";
+	    tag 'nfs-temporary-file-in-package', $file;
 	}
 
 	# ---------------- vcs control files
 	if ($file =~ m/\.(?:(?:cvs|git|hg)ignore|arch-inventory|hgtags|hg_archival\.txt)$/) {
-	    tag 'package-contains-vcs-control-file', "$file";
+	    tag 'package-contains-vcs-control-file', $file;
 	}
 
 	# ---------------- subversion and svk commit message backups
 	if ($file =~ m/svn-commit.*\.tmp$/) {
-	    tag 'svn-commit-file-in-package', "$file";
+	    tag 'svn-commit-file-in-package', $file;
 	}
 	if ($file =~ m/svk-commit.+\.tmp$/) {
-	    tag 'svk-commit-file-in-package', "$file";
+	    tag 'svk-commit-file-in-package', $file;
 	}
 
 	# ---------------- executables with language extensions
 	if ($file =~ m,^(?:usr/)?(?:s?bin|games)/[^/]+\.(?:pl|sh|py|php|rb|tcl|bsh|csh|tcl)$,) {
-	    tag 'script-with-language-extension', "$file";
+	    tag 'script-with-language-extension', $file;
 	}
 
 	# ---------------- Devel files for Windows
 	if ($file =~ m,/.+\.(?:vcproj|sln|dsp|dsw)(?:\.gz)?$,
 	    and $file !~ m,^usr/share/doc/,) {
-	    tag 'windows-devel-file-in-package', "$file";
+	    tag 'windows-devel-file-in-package', $file;
 	}
 
 	# ---------------- Autogenerated databases from other OSes
 	if ($file =~ m,/Thumbs\.db(?:\.gz)?$,i) {
-	    tag 'windows-thumbnail-database-in-package', "$file";
+	    tag 'windows-thumbnail-database-in-package', $file;
 	}
 	if ($file =~ m,/\.DS_Store(?:\.gz)?$,) {
-	    tag 'macos-ds-store-file-in-package', "$file";
+	    tag 'macos-ds-store-file-in-package', $file;
 	}
 	if ($file =~ m,/\._[^_/][^/]*$, and $file !~ m/\.swp$/) {
-	    tag 'macos-resource-fork-file-in-package', "$file";
+	    tag 'macos-resource-fork-file-in-package', $file;
 	}
 
 	# ---------------- embedded Javascript libraries
 	foreach my $jslibrary (@jslibraries) {
 	    if ($file =~ m,/$jslibrary->[0], and $pkg !~ m,^$jslibrary->[1]$,) {
-		tag 'embedded-javascript-library', "$file";
+		tag 'embedded-javascript-library', $file;
 	    }
 	}
 
@@ -912,7 +912,7 @@ foreach my $file (@{$info->sorted_index}) {
 	    open(FEEDPARSER, '<', "unpacked/$file") or fail("cannot open feedparser.py file: $!");
 	    while (<FEEDPARSER>) {
 		if (m,Universal feed parser,) {
-		    tag 'embedded-feedparser-library', "$file";
+		    tag 'embedded-feedparser-library', $file;
 		    last;
 		}
 	    }
@@ -925,7 +925,7 @@ foreach my $file (@{$info->sorted_index}) {
 		open (PEAR, '<', "unpacked/$file") or fail("cannot open PHP file: $!");
 		while (<PEAR>) {
 		    if (m,/pear[/.],i) {
-			tag 'embedded-pear-module', "$file";
+			tag 'embedded-pear-module', $file;
 			last;
 		    }
 		}
@@ -936,7 +936,7 @@ foreach my $file (@{$info->sorted_index}) {
 	# ---------------- embedded php libraries
 	foreach my $phplibrary (@phplibraries) {
 	    if ($file =~ m,/$phplibrary->[0], and $pkg ne $phplibrary->[1]) {
-		tag 'embedded-php-library', "$file";
+		tag 'embedded-php-library', $file;
 	    }
 	}
 
@@ -965,7 +965,7 @@ foreach my $file (@{$info->sorted_index}) {
 	if ($file =~ m/\.gz$/) {
 	    my $info = $info->file_info->{$file} || '';
 	    if ($info !~ m/gzip compressed/) {
-		tag 'gz-file-not-gzip', "$file";
+		tag 'gz-file-not-gzip', $file;
 	    }
 	}
 
@@ -1087,23 +1087,23 @@ foreach my $file (@{$info->sorted_index}) {
 		sprintf('%04o != 0755', $operm);
 	}
 	if ($file =~ m,/CVS/?$,) {
-	    tag 'package-contains-vcs-control-dir', "$file";
+	    tag 'package-contains-vcs-control-dir', $file;
 	}
 	if ($file =~ m,/\.(?:svn|bzr|git|hg)/?$,) {
-	    tag 'package-contains-vcs-control-dir', "$file";
+	    tag 'package-contains-vcs-control-dir', $file;
 	}
 	if (($file =~ m,/\.arch-ids/?$,)
 	    || ($file =~ m,/\{arch\}/?$,)) {
-	    tag 'package-contains-vcs-control-dir', "$file";
+	    tag 'package-contains-vcs-control-dir', $file;
 	}
 	if ($file =~ m,/\.(?:be|ditrack)/?$,) {
-	    tag 'package-contains-bts-control-dir', "$file";
+	    tag 'package-contains-bts-control-dir', $file;
 	}
 	if ($file =~ m,/.xvpics/?$,) {
-	    tag 'package-contains-xvpics-dir', "$file";
+	    tag 'package-contains-xvpics-dir', $file;
 	}
 	if ($file =~ m,usr/share/doc/[^/]+/examples/examples/?$,) {
-	    tag 'nested-examples-directory', "$file";
+	    tag 'nested-examples-directory', $file;
 	}
 	if ($file =~ m,^usr/share/locale/([^/]+)/$,) {
 	    # Without encoding:
@@ -1282,7 +1282,7 @@ if($pkg ne 'base-files'){
 
 if (!$has_binary_perl_file && @nonbinary_perl_files_in_lib) {
     foreach my $file (@nonbinary_perl_files_in_lib) {
-	tag 'package-installs-nonbinary-perl-in-usr-lib-perl5', "$file";
+	tag 'package-installs-nonbinary-perl-in-usr-lib-perl5', $file;
     }
 }
 

-- 
Debian package checker


Reply to: