[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.4.3-170-g3335dff



The following commit has been merged in the master branch:
commit 3335dffd6b02797ce73503db0290153ef72d75c2
Author: Niels Thykier <niels@thykier.net>
Date:   Wed Jan 26 12:14:08 2011 +0100

    Fixed reused variables (not a false-positive after all)

diff --git a/reporting/html_reports b/reporting/html_reports
index f0c0261..4b142d2 100755
--- a/reporting/html_reports
+++ b/reporting/html_reports
@@ -338,9 +338,9 @@ for my $source (keys %source_info) {
 my (%qa, %maintainers, %packages);
 my @maintainers;
 {
-    my %seen;
+    my %unique;
     @maintainers =
-        sort grep { !$seen{$_}++ } keys (%by_maint), keys (%by_uploader);
+        sort grep { !$unique{$_}++ } keys (%by_maint), keys (%by_uploader);
 }
 for my $maintainer (@maintainers) {
     my $id = maintainer_url ($maintainer);
@@ -445,7 +445,7 @@ for my $id (keys %clean) {
     my $maintainer = $clean{$id};
     my ($name, $email) = ($maintainer =~ /^(.*) <([^>]+)>/);
     $email = 'unknown' unless $email;
-    my %data = (
+    my %maint_data = (
         id         => $id,
         email      => html_quote (uri_escape ($email)),
         maintainer => html_quote ($maintainer),
@@ -453,8 +453,8 @@ for my $id (keys %clean) {
         clean      => 1,
     );
     print "Generating clean page for $id\n";
-    output_template ("maintainer/$id", $templates{clean}, \%data);
-    output_template ("full/$id", $templates{clean}, \%data);
+    output_template ("maintainer/$id", $templates{clean}, \%maint_data);
+    output_template ("full/$id", $templates{clean}, \%maint_data);
 }
 
 # Create the pages for each tag.  Each page shows the extended description for
@@ -464,11 +464,11 @@ for my $tag (sort keys %by_tag) {
     next unless $info;
     my $description = $info->description('html', '    ');
     my ($count, $overrides) = (0, 0);
-    my %seen;
+    my %seen_tags;
     foreach (@{$by_tag{$tag}}) {
         if ($_->{code} ne 'O') {
             $count++;
-            $seen{$_->{xref}}++;
+            $seen_tags{$_->{xref}}++;
         } else {
             $overrides++;
         }
@@ -484,7 +484,7 @@ for my $tag (sort keys %by_tag) {
 
     $tag_statistics{$tag}{'count'} = $count;
     $tag_statistics{$tag}{'overrides'} = $overrides;
-    $tag_statistics{$tag}{'packages'} = scalar keys %seen;
+    $tag_statistics{$tag}{'packages'} = scalar keys %seen_tags;
 }
 
 # Create the general tag indices.

-- 
Debian package checker


Reply to: