[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.4.3-130-g96de144



The following commit has been merged in the master branch:
commit 96de1445a9aec741a0915ebbf19963e3395200d0
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Jan 16 21:55:04 2011 +0100

    Added check for missing dependency on python-central
    
      * Summary of tag changes:
        + Added:
          - missing-dependency-on-python-central
      * checks/files{,.desc}:
        + [NT] Added check for missing dependency on python-central.
          Thanks to Jakub Wilk for the report.  (Closes: #592533)

diff --git a/checks/files b/checks/files
index e2bde0d..e42cfa6 100644
--- a/checks/files
+++ b/checks/files
@@ -805,6 +805,12 @@ foreach my $file (@{$info->sorted_index}) {
 	tag "override-file-in-wrong-location", "$file";
     }
 
+    # ---------------- pyshared-data
+    if ($file =~ m,^usr/share/pyshared-data/$tmp$,){
+	my $dep = Lintian::Relation->new($info->field('depends')//'');
+	tag "missing-dependency-on-python-central" unless ($dep->implies('python-central (>= 0.6)'));
+    }
+
     # ---------------- plain files
     if ($index_info->{type} =~ m/^[-h]/) {
 	my $wanted_operm;
diff --git a/checks/files.desc b/checks/files.desc
index 8897d2b..047131b 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -751,6 +751,16 @@ Info: The package appears to be installing debug modules in
  should be installed in /usr/lib/debug/usr/lib/pymodules/pythonX.Y/
  instead.
 
+Tag: missing-dependency-on-python-central
+Severity: important
+Certainty: possible
+Ref: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=592533
+Info: The package installs a file with the package name in
+ /usr/share/pyshared-data/ without depending on python-central (>= 0.6).
+ .
+ This can happen if ${python:Depends} was omitted from the Depends field
+ in debian/control.
+
 Tag: package-installs-python-pyc
 Severity: serious
 Certainty: certain
diff --git a/debian/changelog b/debian/changelog
index cf72178..03cdde2 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -12,6 +12,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
       - unused-build-dependency-on-cdbs
       - python-debug-in-wrong-location
       - debian-watch-contains-dh_make-template
+      - missing-dependency-on-python-central
 
   * checks/*:
     + [NT] Use the new pre-sorted file {index,info} when iterating over files.
@@ -69,6 +70,8 @@ lintian (2.4.4) UNRELEASED; urgency=low
       (Closes: #608810)
     + [NT] Added check for misplaced python debug files.  Thanks to
       Jakub Wilk for the report.  (Closes: #576014)
+    + [NT] Added check for missing dependency on python-central.
+      Thanks to Jakub Wilk for the report.  (Closes: #592533)
   * checks/menu-format.desc:
     + [CW] Fix several typos.
   * checks/menus.desc:
diff --git a/t/tests/files-objects-inv/debian/debian/control.in b/t/tests/files-python-helpers/debian/debian/control.in
similarity index 86%
copy from t/tests/files-objects-inv/debian/debian/control.in
copy to t/tests/files-python-helpers/debian/debian/control.in
index 79a6d1c..a0ca828 100644
--- a/t/tests/files-objects-inv/debian/debian/control.in
+++ b/t/tests/files-python-helpers/debian/debian/control.in
@@ -3,9 +3,9 @@ Priority: extra
 Section: python
 Maintainer: {$author}
 Standards-Version: {$standards_version}
-Build-Depends: debhelper (>= 7.0.50~)
+Build-Depends: debhelper (>= 7)
 
-Package: python-kinterbasdb
+Package: python-foo
 Architecture: all
 Depends: $\{misc:Depends\},
 Description: {$description}
@@ -13,4 +13,3 @@ Description: {$description}
  Lintian.  It is part of the Lintian test suite and may do very odd
  things.  It should not be installed like a regular package.  It may
  be an empty package.
-
diff --git a/t/tests/files-python-helpers/debian/debian/install b/t/tests/files-python-helpers/debian/debian/install
new file mode 100644
index 0000000..c2d69f8
--- /dev/null
+++ b/t/tests/files-python-helpers/debian/debian/install
@@ -0,0 +1 @@
+python-foo usr/share/pyshared-data/
diff --git a/t/tests/changelog-file-missing/upstream/README b/t/tests/files-python-helpers/debian/python-foo
similarity index 100%
copy from t/tests/changelog-file-missing/upstream/README
copy to t/tests/files-python-helpers/debian/python-foo
diff --git a/t/tests/files-python-helpers/desc b/t/tests/files-python-helpers/desc
new file mode 100644
index 0000000..722e78b
--- /dev/null
+++ b/t/tests/files-python-helpers/desc
@@ -0,0 +1,6 @@
+Testname: files-python-helpers
+Sequence: 6000
+Version: 1.0
+Description: Test tags for missing depends on python helpers
+Test-For:
+ missing-dependency-on-python-central
diff --git a/t/tests/files-python-helpers/tags b/t/tests/files-python-helpers/tags
new file mode 100644
index 0000000..e30598d
--- /dev/null
+++ b/t/tests/files-python-helpers/tags
@@ -0,0 +1 @@
+E: python-foo: missing-dependency-on-python-central

-- 
Debian package checker


Reply to: