[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Spelling error with no single correct



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2011-01-08 12:11, Niels Thykier wrote:
> On 2011-01-06 19:37, Raphael Geissert wrote:
>> Russ Allbery wrote:
>>> While I agree with this message that idiomatic English would call for
>>> different phrasing in a lot of places, I think correcting "allows to" to
>>> "allows one to" would be acceptable, if not ideal, phrasing in every
>>> example given there.
> 
> 
>> This one was on my ToDo list and had the following temp commit:
>> +(?i)allows to||allows _object_ to
>> +(?i)requires to||requires _object_ to
>> +(?i)helps to||helps _object_ to
>> +(?i)permits to||permits _object_ to
> 
>> [...]

Hi again,

I have created a second patch, including all of Raphael's other catches
using the "$VERB one to" notation.  I will apply it to the master branch
in a couple of days, unless someone feels strongly about it.

~Niels

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNMBO5AAoJEAVLu599gGRCLagP/im/mGj1gek5ryltrxjaOmbk
b1uuw4xvonwc8uuXK+00l/Q6OfasuAsJiV6ZEvD3VXMrodKP1i5MWDrrG9ObEz4W
dW2fp9bwfAYPMw9ONSt5TYMPr/V6ZGwvcZw85qXbkZjphpN3btSvkILoeSGd3BLl
UO/ZcgHXMtjDvOwYmPtihTowEpKSW+fA1dtO3xKf5zbNhN63DW6doU94g+t9gOET
KSl9RBIr71xMxOo9FS0MV60t3zNgT4+GfaPtWJpscM0tBzPo4VuePsLspHXLjxB6
iqIv+0KtAdz/5UEjTkm2pMm4jJOEpLpXRgmGppjOHZSF676AjMb2+m+0TCaguEkB
LOu/iLPOaZdK7yx7D/Gb8H495IeyzQ0g11JUtQv3+gKp2pA981pC/6yip9540Rxt
Z1tbOwYYgO8Xh32jKWXotBnSmFdmLvkGTe6Mr63zKAIMDJRHW00lAYg5zn5yEYnt
tow6p219n5y9F+laJb1I3wxsNQ6VrCPZPg9dBcAkh9HdwP7203CyOAWIKHzf9CHV
9Gjk6Q8rHnEva6KhpVn0iiLddaxxdPO3ht8o9Ee55eiaA2VCYaxruT3YMODN3Wv9
UdqeNZykQWdICDZHDSS3dqMXSTrJsEbTurJKunoKD+9nH7C3VFYkC8JgvK3euXoa
jl5mX/1TODghUYtY1nAX
=P2f7
-----END PGP SIGNATURE-----
>From 5ae1cd01b71641c252eb40225f7c347309573e36 Mon Sep 17 00:00:00 2001
From: Niels Thykier <niels@thykier.net>
Date: Thu, 6 Jan 2011 12:29:13 +0100
Subject: [PATCH] Catch "allows to" as a spelling error. LP: 608231

---
 data/spelling/corrections-multiword                |    5 +++++
 .../spelling-multiword/debian/debian/control.in    |    6 +++++-
 t/tests/spelling-multiword/tags                    |    4 ++++
 3 files changed, 14 insertions(+), 1 deletions(-)

diff --git a/data/spelling/corrections-multiword b/data/spelling/corrections-multiword
index 71a066e..6a706d3 100644
--- a/data/spelling/corrections-multiword
+++ b/data/spelling/corrections-multiword
@@ -5,7 +5,12 @@
 # The format of each line is:
 # SPELLING_MISTAKE_REGEX||correction
 
+(?i)allows to||allows one to
 (?i)an other||another
 (?i)debian/gnu linux||Debian GNU/Linux
+(?i)helps to||helps one to
+(?i)permits to||permits one to
+(?i)requires to||requires one to
 (?i)these package||this package
 (?i)this packages||these packages
+
diff --git a/t/tests/spelling-multiword/debian/debian/control.in b/t/tests/spelling-multiword/debian/debian/control.in
index fa441cc..a5b7830 100644
--- a/t/tests/spelling-multiword/debian/debian/control.in
+++ b/t/tests/spelling-multiword/debian/debian/control.in
@@ -15,8 +15,12 @@ Description: {$description}
  be an empty package.
  .
  Spelling errors:
-   * Debian/GNU Linux
+   * Allows to
    * An other error
+   * Debian/GNU Linux
+   * Helps to
+   * Permits to
+   * Requires to
    * This packages
  .
  Not errors:
diff --git a/t/tests/spelling-multiword/tags b/t/tests/spelling-multiword/tags
index a954125..4a5e916 100644
--- a/t/tests/spelling-multiword/tags
+++ b/t/tests/spelling-multiword/tags
@@ -1,3 +1,7 @@
+W: spelling-multiword: spelling-error-in-description Allows to Allows one to
 W: spelling-multiword: spelling-error-in-description An other Another
 W: spelling-multiword: spelling-error-in-description Debian/GNU Linux Debian GNU/Linux
+W: spelling-multiword: spelling-error-in-description Helps to Helps one to
+W: spelling-multiword: spelling-error-in-description Permits to Permits one to
+W: spelling-multiword: spelling-error-in-description Requires to Requires one to
 W: spelling-multiword: spelling-error-in-description This packages These packages
-- 
1.7.2.3

Attachment: 0001-Catch-allows-to-as-a-spelling-error.-LP-608231.patch.sig
Description: Binary data


Reply to: