[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#609153: lintian: Explanation for diff-contains-git-control-dir gives wrong advise for native packages



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

tags 609153 + patch
thanks

On 2011-01-06 21:37, Axel Beckert wrote:
> Package: lintian
> Version: 2.4.3
> Severity: minor
> 
> When checking a "3.0 (native)" source package which contains a .git
> directory, lintian explains:
> 
> W: hobbit-plugins source: diff-contains-git-control-dir .git
> N:
> N:    The Debian diff or native package contains files in a .git directory.
> N:    These are usually artifacts of the revision control system used by the
> N:    Debian maintainer and not useful in a diff or native package. Passing -i
> N:    to dpkg-buildpackage or the equivalent will automatically exclude them.
> N:
> N:    Severity: normal, Certainty: certain
> N:
> 
> Passing -i to dpkg-source (!) does not help in case of a native package
> as in that case -I must be used to exclude the .git directory.
> 
> Additionally, the explanation should mention dpkg-source instead of
> dpkg-buildpackage (or maybe both) because in the end, -i (and -I) is an
> dpkg-source option passed to it by dpkg-buildpackage if it is called
> with that option.
> 
> 

I have attached a proposed rewording.  Since other similar tags also
appeared affected I have included the change in those tags as well.

~Niels

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNJjQPAAoJEAVLu599gGRCeukQAIAheP/3qWiA4nI/LpYbIOkU
msaH5jqkTnCvOzgb79POktvPWQGFG1+5gn8RB5ID1Ibd8MuQqgPNu7zojsxg8p96
+YzP07T+4x/Dii3aqmyQPAawaHSAxFAeWmoo535EBtpEPpPeVAQVJGfuEzl5ztYP
TGSSmxjBubTbVKI1HetRLVhYZ3/FkiJFB2kIToH+DYEro7NBnuSMQaSweNK8sOe8
p9eTbW7bykztglBpbLDbl+4Uzj3UIA590BrMnmkB98TEvrEHVd0fMZrhT4jmTxbI
+Y4GSXCtrnoNh061Tdi4rkSzemPocrfmP+Kcq8nscOfZjT7TkMlTyXWVU0XcXo7n
zNFDkAES1eUQDm5HHGDtSd/j5HPe9ZJLgvR3n4piCk5C4bSYNKLG2/JCQkTxMmtK
ZX27XnGbtm/wXqzgduhhpBDVnzjFjozDCsPDao3y8RudFIXJP6yLiwlnxalzrgBn
oHe2CJbladDBX5QC5+4GmYQ/t39bNdMflLjXyB667RXp4wzU1JI9xWH3yzHjULq/
g4KU3A8ZAz+Cx8Ge+ZqaSp3hwDa7NG2MtDEbhZu3r0fAPo17RZ4zOXFOkbavTmE0
HpH7Z4+df4H50oCu1qxMOWCPS/EkrIrOU6tRo/cY2NHmp3ksfWSor/47C6tLt7Hq
Ydj3FefyXrUZpjYA55UA
=rWdQ
-----END PGP SIGNATURE-----
>From 7df2cd9a12dc118f6d5270284e4dceb9173cd657 Mon Sep 17 00:00:00 2001
From: Niels Thykier <niels@thykier.net>
Date: Thu, 6 Jan 2011 22:24:57 +0100
Subject: [PATCH] Proposed rewording for diff-contains-${VCS_stuff} tags (#609153)

---
 checks/cruft.desc |   33 ++++++++++++++++++++-------------
 1 files changed, 20 insertions(+), 13 deletions(-)

diff --git a/checks/cruft.desc b/checks/cruft.desc
index 3fdc364..3d35628 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -61,9 +61,10 @@ Severity: normal
 Certainty: certain
 Info: The Debian diff or native package contains files in a CVS directory.
  These are usually artifacts of the revision control system used by the
- Debian maintainer and not useful in a diff or native package.  Passing
- <tt>-i</tt> to <tt>dpkg-buildpackage</tt> or the equivalent will
- automatically exclude them.
+ Debian maintainer and not useful in a diff or native package.
+ <tt>dpkg-source</tt> will automatically exclude these if it is passed
+ <tt>-I</tt> or <tt>-i</tt> for native and non-native packages respectively.
+Ref: dpkg-source(1)
 
 Tag: source-contains-cvs-control-dir
 Severity: pedantic
@@ -80,8 +81,9 @@ Certainty: certain
 Info: The Debian diff or native package contains files in an .svn
  directory.  These are usually artifacts of the revision control system
  used by the Debian maintainer and not useful in a diff or native package.
- Passing <tt>-i</tt> to <tt>dpkg-buildpackage</tt> or the equivalent will
- automatically exclude them.
+ <tt>dpkg-source</tt> will automatically exclude these if it is passed
+ <tt>-I</tt> or <tt>-i</tt> for native and non-native packages respectively.
+Ref: dpkg-source(1)
 
 Tag: source-contains-svn-control-dir
 Severity: pedantic
@@ -99,8 +101,9 @@ Certainty: certain
 Info: The Debian diff or native package contains files in a .bzr
  directory.  These are usually artifacts of the revision control system
  used by the Debian maintainer and not useful in a diff or native package.
- Passing <tt>-i</tt> to <tt>dpkg-buildpackage</tt> or the equivalent will
- automatically exclude them.
+ <tt>dpkg-source</tt> will automatically exclude these if it is passed
+ <tt>-I</tt> or <tt>-i</tt> for native and non-native packages respectively.
+Ref: dpkg-source(1)
 
 Tag: source-contains-bzr-control-dir
 Severity: pedantic
@@ -119,8 +122,10 @@ Info: The Debian diff or native package contains files in an {arch} or
  .arch-ids directory or a directory starting with <tt>,,</tt> (used by baz
  for debugging traces).  These are usually artifacts of the revision
  control system used by the Debian maintainer and not useful in a diff or
- native package.  Passing <tt>-i</tt> to <tt>dpkg-buildpackage</tt> or the
- equivalent will automatically exclude them.
+ native package.  <tt>dpkg-source</tt> will automatically exclude these if
+ it is passed <tt>-I</tt> or <tt>-i</tt> for native and non-native
+ packages respectively.
+Ref: dpkg-source(1)
 
 Tag: source-contains-arch-control-dir
 Severity: pedantic
@@ -138,8 +143,9 @@ Certainty: certain
 Info: The Debian diff or native package contains files in a .git
  directory.  These are usually artifacts of the revision control system
  used by the Debian maintainer and not useful in a diff or native package.
- Passing <tt>-i</tt> to <tt>dpkg-buildpackage</tt> or the equivalent will
- automatically exclude them.
+ <tt>dpkg-source</tt> will automatically exclude these if it is passed
+ <tt>-I</tt> or <tt>-i</tt> for native and non-native packages respectively.
+Ref: dpkg-source(1)
 
 Tag: source-contains-git-control-dir
 Severity: pedantic
@@ -156,8 +162,9 @@ Certainty: certain
 Info: The Debian diff or native package contains files in a .hg
  directory.  These are usually artifacts of the revision control system
  used by the Debian maintainer and not useful in a diff or native package.
- Passing <tt>-i</tt> to <tt>dpkg-buildpackage</tt> or the equivalent will
- automatically exclude them.
+ <tt>dpkg-source</tt> will automatically exclude these if it is passed
+ <tt>-I</tt> or <tt>-i</tt> for native and non-native packages respectively.
+Ref: dpkg-source(1)
 
 Tag: source-contains-hg-control-dir
 Severity: pedantic
-- 
1.7.2.3

Attachment: 0001-Proposed-rewording-for-diff-contains-VCS_stuff-tags-.patch.sig
Description: Binary data


Reply to: