[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#602655: lintian: Please check for missing comma in Uploaders field (must in Policy 5.6.3)



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2011-01-06 01:01, Russ Allbery wrote:
> Niels Thykier <niels@thykier.net> writes:
> 
>> I am considering to just make the switch to use Email::Valid. I have
>> attached a patch that makes the switch and introduces a regression test
>> to catch the particular issue in #602619.
> 
> The only caveat with using Email::Valid is that Debian Policy explicitly
> permits the non-RFC5322 address format:
> 
>     John N. Doe <jnd@debian.org>
> 
> where the name component contains a period and isn't quoted.  Does
> Email::Valid cope with that case?  If so, this sounds great, but we do
> need to allow that.
> 

I rechecked the code and it is not a problem. Email::Valid does indeed
reject these names, but it is currently only applied to check the
<mail@debian.org> part. The names are still checked by the old
"home-made" regex approach.
  Nevertheless I have added a name containing full stops in
fields-uploaders to check potential regressions if we start using
Email::Valid on the names as well.

~Niels
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNJZ1PAAoJEAVLu599gGRC1WsP/j7uuOYd4Zm37VqPYNaE/uJp
Fxv3WlC7v+AmI2cigEGezsj6Kj9dj6RnN93cR8Up5j6czdaoIVLRxdmx8sJOXvkT
r0vYLABJFXGxZU9laAJJOEBe4BnlMzMRteVtBR5RmeKKQ7IExxQ6tFBNgvCvegsl
2TlFPefzQwjVF462hlziHP2EKO+gUtygObluDlP2B7aqwAAqUs3AojsbPNElgmNl
ORTZO8nGbR8xvdLlP89KXuluzgYPbN7S5LvpjqwK4YJRECENn2NoS04mWGnDV55q
soJUto0pb4wthK1HadO1rnOnGt6pL6rPJiqzzxh5LXPtGSGAd9ewYrgEnyluvs+t
C/gDZw7rntZXvFyFJk8/i0h+o1UV4npI77EZk346jNcR/OkLBZYOG8Td6Idmn1qL
+wCizG70s/xeL++N6s5dXNInBO31qX3UiWqMAtfMd7qjjlvJe7tzDWPWQd1qblSA
Xb4T1e8bhKaqFSaUD3aOHLegpG8w5U96gvaGAuCvdxlGegzosx+fQ5Qg5MylC62o
TOce0kkrx+D3+YQiUir/U4awf5XktCEaqNtil2pF1j/6xue2iZbewMh1Pq42VBnm
0wCa56gm9yY1zYoWu/YS1NU9T0PFz6G+rLsrQSgtGS7cifBq8vnN3xTRsPzrKtN5
THHi5Amdzl9YxG+YL0fq
=bpq2
-----END PGP SIGNATURE-----



Reply to: