[SCM] Debian package checker branch, master, updated. 2.5.3-231-g9233505

["Niels Thykier" <niels@thykier.net>]

The following commit has been merged in the master branch:
commit 92335050b2c4f6795f83af160e29427cc2b04c18
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Nov 20 16:22:31 2011 +0100

    Added tracker tag for packages targeted in the build-arch goal
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/rules b/checks/rules
index 6200bb5..e07e55c 100644
--- a/checks/rules
+++ b/checks/rules
@@ -110,6 +110,8 @@ sub run {
 my $pkg = shift;
 my $type = shift;
 my $info = shift;
+my $proc = shift;
+my $group = shift;
 
 my $rules = $info->debfiles('rules');
 
@@ -362,14 +364,28 @@ while (<RULES>) {
 close RULES;
 
 unless ($includes) {
+    my $rec = 0;
     # Make sure all the required rules were seen.
     for my $target (sort keys %required) {
         tag 'debian-rules-missing-required-target', $target
             unless $seen{$target};
     }
     for my $target (sort keys %recommended) {
-        tag 'debian-rules-missing-recommended-target', $target
-            unless $seen{$target};
+        unless ($seen{$target}) {
+            tag 'debian-rules-missing-recommended-target', $target;
+            $rec++;
+        }
+    }
+
+    if ($rec) {
+        my $all = 0;
+        my $notall = 0;
+        foreach my $p ($group->get_processables) {
+            next if $p->pkg_type eq 'source' or $p->pkg_type eq 'changes';
+            $all++ if $p->pkg_arch eq 'all';
+            $notall++ if $p->pkg_arch ne 'all';
+        }
+        tag 'package-would-benefit-from-build-arch-targets' if $all && $notall;
     }
 }
 
diff --git a/checks/rules.desc b/checks/rules.desc
index 99f73de..5a9dfe7 100644
--- a/checks/rules.desc
+++ b/checks/rules.desc
@@ -212,3 +212,13 @@ Info: The rules files appear to be reading or modifying a variable not
  can be used by users, who wants to re-compile debian packages with
  special (or non-standard) build flags.
 
+Tag: package-would-benefit-from-build-arch-targets
+Severity: normal
+Certainty: certain
+Ref: #629385, https://wiki.debian.org/ReleaseGoals/BuildArchTarget
+Info: The source package does not have both a build-arch and a build-indep
+ target.  Furthermore it is part of the selected set of packages to
+ be fixed for Wheezy.
+ .
+ Please consider adding both the build-arch and build-indep targets.
+
diff --git a/debian/changelog b/debian/changelog
index 9f7f5da..10a4ac4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,6 +7,7 @@ lintian (2.5.4) UNRELEASED; urgency=low
       - init.d-script-does-not-implement-optional-option
       - missing-build-dependency-for-dh-addon
       - package-depends-on-lower-priority-package
+      - package-would-benefit-from-build-arch-targets
       - python-depends-but-no-python-helper
       - python3-depends-but-no-python3-helper
 
@@ -89,7 +90,7 @@ lintian (2.5.4) UNRELEASED; urgency=low
       (Closes: #647250)
     + [NT] Fixed deprecation warning when using perl 5.14.
       (Closes: #649133)
-  * checks/rules:
+  * checks/rules{,.desc}:
     + [JW] Fixed false negative "missing-build-dependency" when using
       "dh --with=X" rather than "dh --with X".  (Closes: #643714)
     + [NT] Do not emit missing-build-dependency for missing dh sequences,
@@ -97,6 +98,8 @@ lintian (2.5.4) UNRELEASED; urgency=low
     + [JW] Parse continuation lines in d/rules.  (Closes: #644021)
     + [JW] Check for versioned dependency on dpkg-dev when using the new
       dpkg makefiles.  (Closes: #646495)
+    + [NT] Added tracker tag for the build-arch target goal.
+      (Closes: #647227)
   * checks/scripts:
     + [RA] Exclude files ending in *.erb from several shell script
       checks.  ERB is a Ruby templating language, so these will probably
diff --git a/t/tests/rules-missing-targets/desc b/t/tests/rules-missing-targets/desc
index 852d495..f92d7bb 100644
--- a/t/tests/rules-missing-targets/desc
+++ b/t/tests/rules-missing-targets/desc
@@ -2,4 +2,6 @@ Testname: rules-missing-targets
 Sequence: 6000
 Version: 1.0
 Description: Test for missing targets in debian/rules
-Test-For: debian-rules-missing-recommended-target
+Test-For:
+ debian-rules-missing-recommended-target
+ package-would-benefit-from-build-arch-targets
diff --git a/t/tests/rules-missing-targets/tags b/t/tests/rules-missing-targets/tags
index 38367e1..ef2f56a 100644
--- a/t/tests/rules-missing-targets/tags
+++ b/t/tests/rules-missing-targets/tags
@@ -1,2 +1,3 @@
 W: rules-missing-targets source: debian-rules-missing-recommended-target build-arch
 W: rules-missing-targets source: debian-rules-missing-recommended-target build-indep
+W: rules-missing-targets source: package-would-benefit-from-build-arch-targets
diff --git a/testset/tags.binary b/testset/tags.binary
index 5e31b21..71edc92 100644
--- a/testset/tags.binary
+++ b/testset/tags.binary
@@ -65,6 +65,7 @@ W: binary source: debian-rules-uses-pwd line 9
 W: binary source: intra-source-package-circular-dependency binary binary-data
 W: binary source: maintainer-upload-has-incorrect-version-number 4-1.1
 W: binary source: native-package-with-dash-version
+W: binary source: package-would-benefit-from-build-arch-targets
 W: binary source: substvar-source-version-is-deprecated binary
 W: binary source: substvar-source-version-is-deprecated binary-data
 W: binary-data: control-file-is-empty md5sums

-- 
Debian package checker