Bug#485705: lintian: doesn't properly detect comma in control file email address quoted strings
tags 485705 + patch
thanks
I promised in #509935, I wrote a patch to fix this bug.
--
Jakub Wilk
diff --git a/checks/fields b/checks/fields
--- a/checks/fields
+++ b/checks/fields
@@ -342,7 +342,7 @@
unfold($f, \$maintainer);
if ($f eq 'uploaders') {
- my @uploaders = split /\s*,\s*/, $maintainer;
+ my @uploaders = split />\K\s*,\s*/, $maintainer;
my %duplicate_uploaders;
for my $uploader (@uploaders) {
check_maintainer($uploader, 'uploader');
diff --git a/checks/nmu b/checks/nmu
--- a/checks/nmu
+++ b/checks/nmu
@@ -96,7 +96,7 @@
my $upload_is_nmu = $uploader ne $maintainer;
if (defined $uploaders) {
- my @uploaders = map { canonicalize($_) } split /,/, $uploaders;
+ my @uploaders = map { canonicalize($_) } split />\K\s*,\s*/, $uploaders;
$upload_is_nmu = 0 if grep /^\s*\Q$uploader\E\s*$/, @uploaders;
}
diff --git a/reporting/html_reports b/reporting/html_reports
--- a/reporting/html_reports
+++ b/reporting/html_reports
@@ -312,7 +312,7 @@
# If the package had uploaders listed, also add the information to
# %by_uploaders (still sharing the data between hashes).
if ($uploaders) {
- my @uploaders = split (/\s*,\s*/, $uploaders);
+ my @uploaders = split (/>\K\s*,\s*/, $uploaders);
for (@uploaders) {
my $uploader = map_maintainer ($_);
next if $uploader eq $maintainer;
Reply to: