[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#644344: [checks/debhelper] multiple identical brace-expansion-in-debhelper-config-file



Package: lintian
Version: 2.5.3
Severity: minor
Tags: patch

Using the stock lintian:

$ lintian -C debhelper dpkg_1.16.1.dsc W: dpkg source: brace-expansion-in-debhelper-config-file debian/dpkg-dev.install
W: dpkg source: brace-expansion-in-debhelper-config-file debian/dpkg-dev.install
W: dpkg source: brace-expansion-in-debhelper-config-file debian/dpkg-dev.install
[snip - even more identical tags]
W: dpkg source: brace-expansion-in-debhelper-config-file debian/dpkg.install
W: dpkg source: brace-expansion-in-debhelper-config-file debian/dpkg.install
W: dpkg source: brace-expansion-in-debhelper-config-file debian/dpkg.install
[snip - even more identical tags]
W: dpkg source: brace-expansion-in-debhelper-config-file debian/dselect.install
W: dpkg source: brace-expansion-in-debhelper-config-file debian/dselect.install

With the attached patch:

$ lintian -C debhelper dpkg_1.16.1.dsc
W: dpkg source: brace-expansion-in-debhelper-config-file debian/dpkg-dev.install
W: dpkg source: brace-expansion-in-debhelper-config-file debian/dpkg.install
W: dpkg source: brace-expansion-in-debhelper-config-file debian/dselect.install

--
Jakub Wilk
diff --git a/checks/debhelper b/checks/debhelper
--- a/checks/debhelper
+++ b/checks/debhelper
@@ -329,6 +329,7 @@
                 if (m/(?<!\\)\{(?:[^\s\\\}]+?,)+[^\\\}\s]+\}/) {
                     tag 'brace-expansion-in-debhelper-config-file',
                         "debian/$file";
+                    last;
                 }
             }
             close IN;

Reply to: