[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#633507: lintian: duplicate missing-build-dependency{,-for-dh_-command} for dh_pysupport



tags 633507 + patch
thanks

* Jakub Wilk <jwilk@debian.org>, 2011-07-11, 00:24:
My package was using dh_pysupport in debian/rules without build-dependency on python-support. lintian yelled at me twice:

E: libvigraimpex source: missing-build-dependency-for-dh_-command dh_pysupport=python-support
E: libvigraimpex source: missing-build-dependency python-support

The attached patch makes lintian stop emitting the latter tag for python-central and python-suppport. (Probably similar thing should be done for for dh-ocaml, but it's not _that_ easy.)

However, there are some gotchas:
- missing-build-dependency has higher severity than ...-for-dh_-command. - missing-build-dependency is on ftp-masters' auto-reject list, automatically ...-for-dh_-command is not.

Couldn't we merge these two tags into one? If there's a reason to keep them separate, at least severity should be unified and ftp-masters should be asked to add ...-for-dh_-command to their list.

--
Jakub Wilk
diff --git a/checks/rules b/checks/rules
--- a/checks/rules
+++ b/checks/rules
@@ -63,8 +63,6 @@
 my @GLOBAL_DEPENDS =
     (
      [ 'dh-ocaml, ocaml-nox | ocaml' => qr'^\t\s*dh_ocaml(?:init|doc)\s' ],
-     [ 'python-central' => qr'^\t\s*dh_pycentral\s' ],
-     [ 'python-support' => qr'^\t\s*dh_pysupport\s' ],
      [ 'python-central' => qr'^DEB_PYTHON_SYSTEM\s*:?=\s*pycentral' ],
      [ 'python-support' => qr'^DEB_PYTHON_SYSTEM\s*:?=\s*pysupport' ],
     );

Reply to: