[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#642833: [checks/source-copyright] use Config::Model



On Mon, 2011-09-26 at 09:18 +0300, jari wrote:
> On 2011-09-25 20:17, Jakub Wilk wrote:
> | * jari <jari.aalto@cante.net>, 2011-09-25, 15:19:
> | >|>       run config-edit -application dpkg-copyright -ui none
> |
[...]
> | I don't see anything[0] wrong with the copyright file you attached,
> 
> It is just that config-edit displayd the error, which didn't show up
> in lintian.

Which might mean that config-edit is wrong.  "Tool X displays a
warning/error that tool Y does not" in no way implies that tool X is
correct, or that if it is then the correct manner of fixing tool Y is to
simply have it call tool X.

[...]
> | Care to explain us why Config::Model complains?
> 
> Not Config::Model, but config-edit, Lintian does not display messages
> for the sample file.

Pedantry doesn't help.  In any case, you didn't answer the question -
*why* is the message being output?

> | [0] Except that you shouldn't use X-prefixed fields. But that's not
> | a syntax error.
> 
> Not quite. Apart from being useful to record additional information
> about the upstream Vcs, bug contact URL etc, the extra fields are part
> of the DEP 5 spec as it was modeled after RFC 822/2822. From DEP 5:
> 
>     http://dep.debian.net/deps/dep5
> 
>     FILE SYNTAX
> 
>     (...) Extra fields can be added to any paragraph. No prefixing is
>     necessary or desired, but please avoid names similar to standard
>     ones so that mistakes are easier to catch.

"No prefixing is necessary or desired" means "you can use extra fields
but just call them 'foo', not 'X-foo' or 'dep5-foo'".  That's not really
an argument in favour of your case; if anything, it's the reverse.

> See also how DEP 5 work was carried forwad:
> 
>     http://anonscm.debian.org/viewvc/dep/web/deps/dep5.mdwn?revision=100
> 
>     Extra fields can be added to any section. Their name starts by **`X-`

That revision is two years old, as can be seen from the text.  The
version you initially quoted is far more current and, as per your own
quote above, indicates that "X-" should *not* be used - things change
and specifications evolve.

Regards,

Adam




Reply to: