Bug#642092: [checks/binaries] please don't complain about /usr/lib/<sourcepackage> RPATH
Package: lintian
Version: 2.5.3
Severity: wishlist
Tags: patch
I think I'd reasonable not to emit binary-or-shlib-defines-rpath if
RPATH is set to /usr/lib/<sourcepackage>. With the attached patch the
following (overridden) tags won't be emitted anymore:
O: bacula-traymonitor: binary-or-shlib-defines-rpath usr/bin/bacula-tray-monitor /usr/lib/bacula
O: bacula-console: binary-or-shlib-defines-rpath usr/sbin/bacula-console /usr/lib/bacula
O: bacula-console-qt: binary-or-shlib-defines-rpath usr/bin/bat /usr/lib/bacula
O: bacula-sd-pgsql: binary-or-shlib-defines-rpath usr/bin/bcopy /usr/lib/bacula
O: bacula-sd-pgsql: binary-or-shlib-defines-rpath usr/bin/bscan /usr/lib/bacula
O: bacula-sd-pgsql: binary-or-shlib-defines-rpath usr/sbin/btape /usr/lib/bacula
O: bacula-sd-sqlite3: binary-or-shlib-defines-rpath usr/bin/bcopy /usr/lib/bacula
O: bacula-sd-sqlite3: binary-or-shlib-defines-rpath usr/bin/bscan /usr/lib/bacula
O: bacula-sd-sqlite3: binary-or-shlib-defines-rpath usr/sbin/btape /usr/lib/bacula
O: bacula-sd-mysql: binary-or-shlib-defines-rpath usr/bin/bcopy /usr/lib/bacula
O: bacula-sd-mysql: binary-or-shlib-defines-rpath usr/bin/bscan /usr/lib/bacula
O: bacula-sd-mysql: binary-or-shlib-defines-rpath usr/sbin/btape /usr/lib/bacula
O: dia-gnome: binary-or-shlib-defines-rpath usr/bin/dia-gnome /usr/lib/dia
O: freeradius-utils: binary-or-shlib-defines-rpath usr/bin/radclient /usr/lib/freeradius
O: freeradius-utils: binary-or-shlib-defines-rpath usr/bin/radeapclient /usr/lib/freeradius
O: freeradius-utils: binary-or-shlib-defines-rpath usr/bin/radsniff /usr/lib/freeradius
O: freeradius-utils: binary-or-shlib-defines-rpath usr/bin/radwho /usr/lib/freeradius
O: freeradius-utils: binary-or-shlib-defines-rpath usr/bin/rlm_dbm_cat /usr/lib/freeradius
O: freeradius-utils: binary-or-shlib-defines-rpath usr/bin/rlm_dbm_parser /usr/lib/freeradius
O: freeradius-utils: binary-or-shlib-defines-rpath usr/bin/rlm_ippool_tool /usr/lib/freeradius
O: freeradius-utils: binary-or-shlib-defines-rpath usr/bin/smbencrypt /usr/lib/freeradius
O: gcin-qt4-immodule: binary-or-shlib-defines-rpath usr/lib/qt4/plugins/inputmethods/im-gcin.so /usr/lib/gcin
O: python-gtk-gnash: binary-or-shlib-defines-rpath usr/lib/pyshared/python2.6/gtk-2.0/gnash.so /usr/lib/gnash
O: gnash-cygnal: binary-or-shlib-defines-rpath usr/bin/cygnal /usr/lib/gnash
O: gnash-cygnal: binary-or-shlib-defines-rpath usr/lib/cygnal/plugins/echo.so /usr/lib/gnash
O: gnash-cygnal: binary-or-shlib-defines-rpath usr/lib/cygnal/plugins/oflaDemo.so /usr/lib/gnash
O: klash: binary-or-shlib-defines-rpath usr/bin/qt4-gnash /usr/lib/gnash
O: gnash-tools: binary-or-shlib-defines-rpath usr/bin/findmicrophones /usr/lib/gnash
O: gnash-tools: binary-or-shlib-defines-rpath usr/bin/findwebcams /usr/lib/gnash
O: gnash-tools: binary-or-shlib-defines-rpath usr/bin/flvdumper /usr/lib/gnash
O: gnash-tools: binary-or-shlib-defines-rpath usr/bin/gprocessor /usr/lib/gnash
O: gnash-tools: binary-or-shlib-defines-rpath usr/bin/rtmpget /usr/lib/gnash
O: gnash-tools: binary-or-shlib-defines-rpath usr/bin/soldumper /usr/lib/gnash
O: python-gnucash: binary-or-shlib-defines-rpath usr/lib/python2.6/dist-packages/gnucash/_gnucash_core_c.so /usr/lib/gnucash/gnucash
O: python-gnucash: binary-or-shlib-defines-rpath usr/lib/python2.6/dist-packages/gnucash/_gnucash_core_c.so /usr/lib/gnucash
O: paraview-python: binary-or-shlib-defines-rpath usr/bin/pvpython /usr/lib/paraview
O: paraview-python: binary-or-shlib-defines-rpath usr/bin/vtkWrapHierarchy /usr/lib/paraview
O: paraview-python: binary-or-shlib-defines-rpath usr/bin/vtkWrapPython /usr/lib/paraview
O: paraview-python: binary-or-shlib-defines-rpath usr/bin/vtkWrapPythonInit /usr/lib/paraview
O: libscilab2-java: binary-or-shlib-defines-rpath usr/lib/jni/libjavasci2.so.5.3.3 /usr/lib/scilab
O: libscilab-java: binary-or-shlib-defines-rpath usr/lib/jni/libjavasci.so.5.3.3 /usr/lib/scilab
O: virtualbox-fuse: binary-or-shlib-defines-rpath usr/bin/vdfuse /usr/lib/virtualbox
--
Jakub Wilk
diff --git a/checks/binaries b/checks/binaries
--- a/checks/binaries
+++ b/checks/binaries
@@ -140,6 +140,7 @@
my %SONAME;
$arch = $info->field('architecture')//'';
+my $srcpkg = $proc->pkg_src()//'';
foreach my $file (sort keys %{$info->objdump_info}) {
my $objdump = $info->objdump_info->{$file};
@@ -313,7 +314,7 @@
# rpath is disallowed, except in private directories
if (exists $objdump->{RPATH}) {
foreach my $rpath (map {File::Spec->canonpath($_)} keys %{$objdump->{RPATH}}) {
- next if $rpath =~ m,^/usr/lib/(?:games/)?\Q$pkg\E(?:/|\z),;
+ next if $rpath =~ m,^/usr/lib/(?:games/)?(?:\Q$pkg\E|\Q$srcpkg\E)(?:/|\z),;
next if $rpath =~ m,^\$\{?ORIGIN\}?,;
next if $directories{$rpath} and $rpath !~ m,^(?:/usr)?/lib(?:/$madir)?/?\z,;
tag 'binary-or-shlib-defines-rpath', "$file $rpath";
Reply to: