[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#641983: [checks/files] package-installs-packlist description suggests "find ... | xargs ..." pipeline



Package: lintian
Version: 2.5.3
Severity: wishlist
Tags: patch

package-installs-packlist suggests to use "find ... | xargs rm -f" pipe to delete files. However, "find ... -delete" should be both faster and more robust.

--
Jakub Wilk
diff --git a/checks/files.desc b/checks/files.desc
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -628,21 +628,21 @@
 Tag: package-installs-packlist
 Severity: important
 Certainty: certain
 Info: Packages built using the perl MakeMaker package will have a file
  named .packlist in them.  Those files are useless, and (in some cases)
  have the additional problem of creating an architecture-specific
  directory name in an architecture-independent package.
  .
  They can be suppressed by adding the following to <tt>debian/rules</tt>:
  .
-   find debian/<i>pkg</i> -type f -name .packlist | xargs rm -f
+   find debian/<i>pkg</i> -type f -name .packlist -delete
  .
  or by telling MakeMaker to use vendor install dirs; consult a recent
  version of Perl policy. Perl 5.6.0-12 or higher supports this.
 Ref: perl-policy 4.1
 
 Tag: zero-byte-file-in-doc-directory
 Severity: normal
 Certainty: possible
 Info: The documentation directory for this package contains an empty
  file.  This is often due to installing an upstream NEWS or README file

Reply to: