[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.3-14-g48cdec9



The following commit has been merged in the master branch:
commit 48cdec97c4c86132f9f3ea90005b69980840efac
Author: Niels Thykier <niels@thykier.net>
Date:   Sat Sep 17 09:26:02 2011 +0200

    Style: Prefer "Class->new" over "new Class"

diff --git a/checks/cruft b/checks/cruft
index 7d26f1f..664c0d3 100644
--- a/checks/cruft
+++ b/checks/cruft
@@ -41,7 +41,7 @@ use File::Basename;
 # autoconf and automake and then use autoreconf to update config.guess and
 # config.sub, and automake depends on autotools-dev.
 our $AUTOTOOLS = Lintian::Relation->new(join(' | ',
-    new Lintian::Data('cruft/autotools')->all()));
+    Lintian::Data->new ('cruft/autotools')->all));
 
 # The files that contain error messages from tar, which we'll check and issue
 # tags for if they contain something unexpected, and their corresponding tags.
diff --git a/frontend/lintian b/frontend/lintian
index eb58674..336646a 100755
--- a/frontend/lintian
+++ b/frontend/lintian
@@ -770,13 +770,13 @@ if (defined $experimental_output_opts) {
 	if ($_ eq 'format') {
 	    if ($opts{$_} eq 'colons') {
 		require Lintian::Output::ColonSeparated;
-		$Lintian::Output::GLOBAL = new Lintian::Output::ColonSeparated;
+		$Lintian::Output::GLOBAL = Lintian::Output::ColonSeparated->new;
 	    } elsif ($opts{$_} eq 'letterqualifier') {
 		require Lintian::Output::LetterQualifier;
-		$Lintian::Output::GLOBAL = new Lintian::Output::LetterQualifier;
+		$Lintian::Output::GLOBAL = Lintian::Output::LetterQualifier->new;
 	    } elsif ($opts{$_} eq 'xml') {
 		require Lintian::Output::XML;
-		$Lintian::Output::GLOBAL = new Lintian::Output::XML;
+		$Lintian::Output::GLOBAL = Lintian::Output::XML->new;
 	    }
 	}
 	no strict 'refs';
diff --git a/lib/Lab.pm b/lib/Lab.pm
index 79eda17..9b330e6 100644
--- a/lib/Lab.pm
+++ b/lib/Lab.pm
@@ -298,8 +298,8 @@ sub _do_delete {
         $dir = $self->{dir} . '/' . $vpkg_type . '/' . $pkg_name;
         $dir .= '/' . $pkg_version if $self->_supports_multiple_versions();
         $dir .= '/' . $pkg_arch if $self->_supports_multiple_architectures();
-        return new Lab::Package($self, $pkg_name, $pkg_version, $vpkg_type,
-                                $realpath, $dir);
+        return Lab::Package->new ($self, $pkg_name, $pkg_version, $vpkg_type,
+                                  $realpath, $dir);
 
     }
 }
diff --git a/lib/Lab/Package.pm b/lib/Lab/Package.pm
index 76921f3..f3e3e9f 100644
--- a/lib/Lab/Package.pm
+++ b/lib/Lab/Package.pm
@@ -29,14 +29,14 @@ Lab::Package - A package inside the Lab
 
  use Lab;
  
- my $lab = new Lab("dir", "dist");
- my $lpkg = $lab->get_lab_package("name", "version", "arch", "type", "path");
+ my $lab = Lab->new ("dir", "dist");
+ my $lpkg = $lab->get_lab_package ("name", "version", "arch", "type", "path");
 
  # create the entry if it does not exist
  $lpkg->create_entry unless $lpkg->entry_exists;
 
  # Remove package from lab.
- $lpkg->delete_lab_entry();
+ $lpkg->delete_lab_entry;
 
 =head1 DESCRIPTION
 
@@ -62,7 +62,7 @@ use Lab qw(:constants); # LAB_FORMAT
 
 =over 4
 
-=item new Lab::Package($lab, $pkg_type, $pkg_name, $pkg_path, $base_dir)
+=item Lab::Package->new ($lab, $pkg_type, $pkg_name, $pkg_path, $base_dir)
 
 Creates a new Lab::Package inside B<$lab>.  B<$pkg_type> denotes the
 (long) type of package (e.g. binary, source, udeb ...) and
diff --git a/lib/Lintian/Output.pm b/lib/Lintian/Output.pm
index e43d2f7..e9b11f6 100644
--- a/lib/Lintian/Output.pm
+++ b/lib/Lintian/Output.pm
@@ -55,7 +55,7 @@ Lintian::Output - Lintian messaging handling
     # OO
     use Lintian::Output;
 
-    my $out = new Lintian::Output;
+    my $out = Lintian::Output->new;
 
     $out->verbosity_level(-1);
     $out->msg("Something interesting");
@@ -134,7 +134,7 @@ Lintian::Output->mk_accessors(qw(verbosity_level debug color colors stdout
 my %default_colors = ( 'E' => 'red' , 'W' => 'yellow' , 'I' => 'cyan',
 		       'P' => 'green' );
 
-our $GLOBAL = new Lintian::Output;
+our $GLOBAL = Lintian::Output->new;
 
 sub new {
     my ($class, %options) = @_;

-- 
Debian package checker


Reply to: