Bug#641609: Lintian::Collect::Source::binary_relation broken

[Jakub Wilk <jwilk@debian.org>]

Package: lintian
Version: 2.5.3
Severity: minor
Tags: patch

Lintian::Collect::Source::binary_relation() doesn't work at all. The 
attached patch fixes it.

BTW, once it's fixed, we could use it to simplify implementation of 
{debhelper-but-no,weak-dependency-on}-misc-depends tags.

--
Jakub Wilk

diff --git a/lib/Lintian/Collect/Source.pm b/lib/Lintian/Collect/Source.pm
--- a/lib/Lintian/Collect/Source.pm
+++ b/lib/Lintian/Collect/Source.pm
@@ -23,6 +23,7 @@
 use warnings;
 use base 'Lintian::Collect::Package';
 
+use Carp qw(croak);
 use Cwd();
 
 use Lintian::Relation;
@@ -186,7 +187,7 @@
         my $merged;
         for my $f (@{ $special{$field} }) {
 	    # sub binary_relation Needs-Info :binary_field
-            my $value = $self->binary_field($f);
+            my $value = $self->binary_field($package, $f);
             $merged .= ', ' if (defined($merged) and defined($value));
             $merged .= $value if defined($value);
         }
@@ -201,7 +202,7 @@
     }
     $result = Lintian::Relation->new($result);
     $self->{binary_relation}->{$package}->{$field} = $result;
-    return $self->{binary_relation}->{$field};
+    return $result;
 }