tags 474590 + patch thanks Hi I am considering to the attached patch to the master branch. It solves collecting the override comments and printing them (with --show-overrides). A comment is "not carried through" to the next override (of same tag); but this is matter of updated file_overrides. Furthermore, any empty line will discard the "currently collected comment" (if any). If an empty line should be in the comment to be collected, simply add a comment marker with nothing after it[0]. It will not mark override comments with anything "special". I wonder if we should extend the Lintian::Output API to get these comments marked with a special marker. Finally (as a side thing), this patch makes lintian pre-compute the pattern-overrides (any override using "*"). I did consider merging the statistics with the Lintian::Tag::Override; my "argument" against it is that L::T::Override would then lose its immutability. For non-pattern overrides, Lintian will use its current hash look up, since it has (on average) constant running time. I could not figure out a way to use L::T::Override->overrides (without hash look up) without losing that property. ~Niels [0] This allow people to do: # General comment about the overrides which is not displayed # This will be displayed # # ... and so will this. some-tag: some extra
Attachment:
0001-Collect-comments-from-override-files.patch
Description: application/wine-extension-patch