Re: [SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7
Niels Thykier <niels@thykier.net> writes:
> I usually buy the "All caps" as global variables, but I still like to
> differ between "exported/public" variables and "internal global" variables.
[...]
> My second reason is that I like to know that if I want to change (the
> format of) a variable, I know I only have to check the current file and
> nothing else.
Yeah, that's a valid point. Okay, you've convinced me.
> A final note on it, is that we had variables in frontend/lintian
> declared as "our" without being all caps... and one of them was actually
> used in a check (the --checksums variable).
> If we do formalize a code-style, I hope we can agree that this is not
> good. :)
Oh, yeah, I can agree on that. :)
> I normally like constants, but some how they feel "wrong" in perl...
> like a second-grade citizen or so. To use a constant in a regex you
> have to do stuff like "${\CONSTANT}". >.>
Yes, that's a very good point as well. Let's not do that. :)
> All right, I am ready to buy that approach in moderate doses. Maybe it
> is a familiarity thing. Perhaps we can declare both variables at the
> same place.
That's a good idea.
--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>
Reply to:
- References:
- [SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7
- From: "Niels Thykier" <niels@thykier.net>
- Re: [SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7
- From: Russ Allbery <rra@debian.org>
- Re: [SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7
- From: Niels Thykier <niels@thykier.net>
- Re: [SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7
- From: Russ Allbery <rra@debian.org>
- Re: [SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7
- From: Niels Thykier <niels@thykier.net>