[SCM] Debian package checker branch, master, updated. 2.5.1-49-gfe48e18
The following commit has been merged in the master branch:
commit fe48e1897b67a3735befb1dd58df54e2ece9cc40
Author: Niels Thykier <niels@thykier.net>
Date: Fri Jul 8 22:01:21 2011 +0200
Removed perl-suid related tags
The tags are not triggered in any packages on lintian.debian.org
and the perl-suid package is no longer built.
diff --git a/checks/scripts b/checks/scripts
index 2a49c86..b2c05da 100644
--- a/checks/scripts
+++ b/checks/scripts
@@ -302,7 +302,6 @@ sub script_tag {
sub run {
my %executable = ();
-my %suid = ();
my %ELF = ();
my %scripts = ();
@@ -321,7 +320,6 @@ foreach (@{$info->sorted_index}) {
$operm & 010 or $operm & 0100));
my $is_suid = $operm & 04000;
$executable{$_} = 1;
- $suid{$_} = $is_suid;
}
for my $file (@{$info->sorted_file_info}) {
@@ -441,8 +439,6 @@ for my $filename (sort keys %{$info->scripts}) {
} elsif ($executable{'.' . $interpreter}) {
# Package installs the interpreter itself, so it's probably ok. Don't
# emit any tag for this.
- } elsif ($base eq 'suidperl') {
- tag("calls-suidperl-directly", $filename);
} elsif ($interpreter eq '/bin/env') {
script_tag("script-uses-bin-env", $filename);
} else {
@@ -507,10 +503,6 @@ for my $filename (sort keys %{$info->scripts}) {
"($filename)");
}
}
- if ($base eq 'perl' && $suid{$filename}) {
- tag("suid-perl-script-but-no-perl-suid-dep", $filename)
- unless $all_parsed->implies('perl-suid');
- }
} elsif ($versioned_interpreters{$base}) {
my @versions = @$data[4 .. @$data - 1];
my @depends = map {
diff --git a/checks/scripts.desc b/checks/scripts.desc
index 7e9d955..240868c 100644
--- a/checks/scripts.desc
+++ b/checks/scripts.desc
@@ -181,15 +181,6 @@ Info: The Debian policy for scripts explicitly warns against using csh
and tcsh as scripting languages.
Ref: policy 10.4
-Tag: suid-perl-script-but-no-perl-suid-dep
-Severity: important
-Certainty: certain
-Info: Packages that use perl scripts that are suid must depend on the
- perl-suid package.
- .
- In some cases a weaker relationship, such as Suggests or Recommends, will
- be more appropriate.
-
Tag: wrong-path-for-interpreter
Severity: important
Certainty: certain
@@ -302,14 +293,6 @@ Info: Packages that include tclsh scripts must depend on the virtual
In some cases a weaker relationship, such as Suggests or Recommends, will
be more appropriate.
-Tag: calls-suidperl-directly
-Severity: important
-Certainty: certain
-Info: Since perl version 5.8.3-3, /usr/bin/suidperl shouldn't be called
- directly anymore (and doing so will lead to errors in most cases) but the
- script should just use /usr/bin/perl as interpreter which will call
- suidperl automatically if the script has the suid permission bit set.
-
Tag: shell-script-fails-syntax-check
Severity: important
Certainty: certain
diff --git a/debian/changelog b/debian/changelog
index 7cccc78..3350d3e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,9 @@ lintian (2.5.2) UNRELEASED; urgency=low
- source-package-component-has-long-file-name
- upstart-job-in-etc-init.d-not-registered-via-update-rc.d
- debian-rules-uses-deprecated-makefile
+ + Removed:
+ - calls-suidperl-directly
+ - suid-perl-script-but-no-perl-suid-dep
* checks/binaries:
+ [NT] Added lib/${MULTIARCH_DIR} to the list of paths to
@@ -76,6 +79,10 @@ lintian (2.5.2) UNRELEASED; urgency=low
as they are both deprecated by source format 3.0 (quilt).
Thanks to Nelson A. de Oliveira for reporting and Luk Claes
for providing an initial patch. (Closes: #624201)
+ * checks/scripts{,.desc}:
+ + [NT] Removed perl-suid related tags as the package is no
+ longer available and we have no known packages triggering
+ the tags at the moment. (Closes: #631432)
* checks/symlinks:
+ [NT] Symlink checking extended to relative paths as well.
(Closes: #217023)
diff --git a/t/COVERAGE b/t/COVERAGE
index 637ba69..e5cce89 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,4 +1,4 @@
-Last generated 2011-06-26
+Last generated 2011-07-08
The following tags are not tested by the test suite:
@@ -306,7 +306,6 @@ scripts ancient-dpkg-epoch-check
scripts ancient-dpkg-long-filenames-check
scripts ancient-dpkg-multi-conrep-check
scripts ancient-dpkg-predepends-check
-scripts calls-suidperl-directly
scripts executable-not-elf-or-script
scripts maintainer-script-ignores-errors
scripts maintainer-script-removes-device-files
@@ -314,7 +313,6 @@ scripts php-script-but-no-phpX-cli-dep
scripts python-script-but-no-python-dep
scripts script-not-executable
scripts shell-script-fails-syntax-check
-scripts suid-perl-script-but-no-perl-suid-dep
scripts update-alternatives-remove-called-in-postrm
shared-libs duplicate-entry-in-symbols-control-file
@@ -492,7 +490,6 @@ maintainer-scripts
relations
scripts
- calls-suidperl-directly
duplicate-updaterc.d-calls-in-postrm
executable-is-not-world-readable
init.d-script-has-bad-lsb-line
@@ -509,4 +506,3 @@ scripts
script-with-language-extension
setuid-binary
shell-script-fails-syntax-check
- suid-perl-script-but-no-perl-suid-dep
diff --git a/testset/tags.scripts b/testset/tags.scripts
index cd97194..47122d4 100644
--- a/testset/tags.scripts
+++ b/testset/tags.scripts
@@ -2,7 +2,6 @@ E: scripts source: dpatch-index-references-non-existent-patch 01_not_here_right_
E: scripts source: dpatch-index-references-non-existent-patch 01_some_other_patch_thats_not_in_the_package.dpatch
E: scripts source: missing-build-dependency debhelper
E: scripts source: package-uses-debhelper-but-lacks-build-depends
-E: scripts: calls-suidperl-directly usr/bin/suidperlfoo
E: scripts: copyright-file-lacks-pointer-to-perl-license
E: scripts: duplicate-updaterc.d-calls-in-postrm lsb-other
E: scripts: init.d-script-does-not-implement-required-option etc/init.d/lsb-broken force-reload
@@ -17,7 +16,6 @@ E: scripts: php-script-but-no-phpX-cli-dep usr/share/scripts/phpfoo
E: scripts: python-script-but-no-python-dep usr/bin/py2foo
E: scripts: python-script-but-no-python-dep usr/bin/pyfoo
E: scripts: shell-script-fails-syntax-check usr/bin/sh-broken
-E: scripts: suid-perl-script-but-no-perl-suid-dep usr/bin/suidperlfoo2
E: scripts: wrong-path-for-interpreter usr/bin/lefty-foo (#!/usr/local/bin/lefty != /usr/bin/lefty)
E: scripts: wrong-path-for-interpreter usr/bin/rubyfoo (#!/bin/ruby1.8 != /usr/bin/ruby1.8)
E: scripts_6ds-1ubuntu0.5.10.1_arch changes: bad-ubuntu-distribution-in-changes-file unstable
--
Debian package checker
Reply to: