Bug#631872: lintian: Please split script-in-etc-init.d-not-registered-via-update-rc.d

[Benjamin Drung <bdrung@debian.org>]

Package: lintian
Version: 2.5.2
Severity: normal

Please apply the attached upstart patch and create a new tag for upstart
symlinks in /etc/init.d that are not registered via update-rc.d. This allows
Ubuntu to disable the new tag. There are currently three overrides for the
script-in-etc-init.d-not-registered-via-update-rc.d tag, but they are
unrelated to upstart. So this change wouldn't influence them.

diff -Nru lintian-2.5.1/checks/init.d lintian-2.5.1ubuntu1/checks/init.d
--- lintian-2.5.1/checks/init.d	2011-04-12 11:22:06.000000000 +0200
+++ lintian-2.5.1ubuntu1/checks/init.d	2011-06-21 18:25:17.000000000 +0200
@@ -188,6 +188,15 @@
     my $script = $_;
     next if grep {$script eq $_} qw(. .. README skeleton rc rcS);
 
+    # In an upstart system, such as Ubuntu, init scripts are symlinks to
+    # upstart-job which are not registered with update-rc.d.
+    if (-l "init.d/$_") {
+        my $target = readlink("init.d/$_");
+        if ($target =~ m,(?:\A|/)lib/init/upstart-job\z,) {
+            next;
+        }
+    }
+
     # If $initd_postinst is true for this script, we already checked the
     # syntax in the above loop.  Check the syntax of unregistered scripts so
     # that we get more complete Lintian coverage in the first pass.