Bug#629288: lintian: Check for GLee, GLEW, libtheora embedded code copies

[Niels Thykier <niels@thykier.net>]

On 2011-06-06 08:02, Paul Wise wrote:
> On Sun, 2011-06-05 at 13:11 +0200, Niels Thykier wrote:
> 
>> I am not really sure what to say about the detection strings, except I
>> feel they seem very generic (but I could be wrong)[1].  With
>> embedded-library being an auto-reject tag now (about 45 minutes ago), I
>> think we have to be more careful about false-positives here.
>>
>> ~Niels
>>
>> [1] I do not know how common "This app uses Xiph.Org libtheora for
>> feature XYZ" etc. strings are in applications or libraries.
> 
> Agreed about false positives.
> 
> Good to hear it was added to ftp-master autorejects, hopefully that is
> in the overridable set? Since probably a fair few embedded code copies
> are modified versions.
> 

It is overridable; as we merged embedded-zlib into embedded-library, all
other embedded-library tags were "bumped" to the non-fatal list.

> Before submitting it I searched the lintian laboratory strings files for
> the detection strings I suggested and verified the resulting list (see
> below) actually contained embedded code copies using buildd logs.
> 

Nice. :)

> In any case these libraries have very few strings in them and the
> strings I suggested are the most specific ones I could find.
> 

Beyond their symbols, but yes, I agree I could not find any
discriminating strings in them either last I checked.

> [...]

Okay, I will give the other maintainers a couple of days to think and
comment on this before I commit it.  Thanks for the research. :)

~Niels