[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#570380: [checks/shared-libs] symbols-declares-dependency-on-other-package trailing space in extra info



Package: lintian
Version: 2.3.3
Severity: minor
File: /usr/share/lintian/checks/shared-libs
Tags: patch

Hello,

if dependency is not versioned, symbols-declares-dependency-on-other-package
tag will have a trailing space. This makes it tricky to declare overrides.
Patch below.

--- /usr/share/lintian/checks/shared-libs.orig	2010-02-18 14:35:13.000000000 +0200
+++ /usr/share/lintian/checks/shared-libs	2010-02-18 14:47:55.000000000 +0200
@@ -403,10 +403,10 @@
 
 		foreach my $part (split /\s*,\s*/) {
 		    foreach my $subpart (split /\s*\|\s*/, $part) {
-			$subpart =~ m,^(\S+)\s*(\(\S+\s+\S+\)|#MINVER#)?$,;
+			$subpart =~ m,^(\S+)(\s*(?:\(\S+\s+\S+\)|#MINVER#))?$,;
 			($dep_package, $dep) = ($1, $2 || '');
 			if (defined $dep_package) {
-			    push @symbols_depends, $dep_package . ' ' . $dep;
+			    push @symbols_depends, $dep_package . $dep;
 			} else {
 			    tag "syntax-error-in-symbols-file", $.
 				unless $warned;
@@ -433,10 +433,10 @@
 
 	    foreach my $part (split /\s*,\s*/) {
 		foreach my $subpart (split /\s*\|\s*/, $part) {
-		    $subpart =~ m,^(\S+)\s*(\(\S+\s+\S+\)|#MINVER#)?$,;
+		    $subpart =~ m,^(\S+)(\s*(?:\(\S+\s+\S+\)|#MINVER#))?$,;
 		    ($dep_package, $dep) = ($1, $2 || '');
 		    if (defined $dep_package) {
-			push @symbols_depends, $dep_package . ' ' . $dep;
+			push @symbols_depends, $dep_package . $dep;
 		    } else {
 			tag "syntax-error-in-symbols-file", $. unless $warned;
 			$warned = 1;

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-2-amd64 (SMP w/1 CPU core)
Locale: LANG=lt_LT.UTF-8, LC_CTYPE=lt_LT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils               2.20-6            The GNU assembler, linker and bina
ii  diffstat               1.47-1            produces graph of changes introduc
ii  dpkg-dev               1.15.5.6          Debian package development tools
ii  file                   5.04-1            Determines file type using "magic"
ii  gettext                0.17-9            GNU Internationalization utilities
ii  intltool-debian        0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-perl        0.1.24            Perl interface to libapt-pkg
ii  libclass-accessor-perl 0.34-1            Perl module that automatically gen
ii  libipc-run-perl        0.84-1            Perl module for running processes
ii  libparse-debianchangel 1.1.1-2           parse Debian changelogs and output
ii  libtimedate-perl       1.2000-1          collection of modules to manipulat
ii  liburi-perl            1.52-1            module to manipulate and access UR
ii  locales                2.10.2-6          Embedded GNU C Library: National L
ii  man-db                 2.5.7-1           on-line manual pager
ii  perl [libdigest-sha-pe 5.10.1-11         Larry Wall's Practical Extraction 

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch            <none>     (no description available)
ii  libtext-template-perl         1.45-1     Text::Template perl module
ii  man-db                        2.5.7-1    on-line manual pager

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/lintian/checks/shared-libs (from lintian package)



Reply to: